diff options
| author | Zhizhou Zhang <zhizhouzhang@asrmicro.com> | 2018-06-12 17:07:37 +0800 |
|---|---|---|
| committer | Catalin Marinas <catalin.marinas@arm.com> | 2018-06-19 14:19:24 +0100 |
| commit | b154886f7892499d0d3054026e19dfb9a731df61 (patch) | |
| tree | b6b747f8a056ef64bc9ed3c93108b7b21b4c0706 /arch/arm64 | |
| parent | dd65a941f6ba473a5cb9d013d57fa43b48450a04 (diff) | |
| download | talos-obmc-linux-b154886f7892499d0d3054026e19dfb9a731df61.tar.gz talos-obmc-linux-b154886f7892499d0d3054026e19dfb9a731df61.zip | |
arm64: make secondary_start_kernel() notrace
We can't call function trace hook before setup percpu offset.
When entering secondary_start_kernel(), percpu offset has not
been initialized. So this lead hotplug malfunction.
Here is the flow to reproduce this bug:
echo 0 > /sys/devices/system/cpu/cpu1/online
echo function > /sys/kernel/debug/tracing/current_tracer
echo 1 > /sys/kernel/debug/tracing/tracing_on
echo 1 > /sys/devices/system/cpu/cpu1/online
Acked-by: Mark Rutland <mark.rutland@arm.com>
Tested-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Zhizhou Zhang <zhizhouzhang@asrmicro.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Diffstat (limited to 'arch/arm64')
| -rw-r--r-- | arch/arm64/kernel/smp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index f3e2e3aec0b0..2faa9863d2e5 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -179,7 +179,7 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle) * This is the secondary CPU boot entry. We're using this CPUs * idle thread stack, but a set of temporary page tables. */ -asmlinkage void secondary_start_kernel(void) +asmlinkage notrace void secondary_start_kernel(void) { u64 mpidr = read_cpuid_mpidr() & MPIDR_HWID_BITMASK; struct mm_struct *mm = &init_mm; |
