summaryrefslogtreecommitdiffstats
path: root/.cocciconfig
diff options
context:
space:
mode:
authorMasahiro Yamada <yamada.masahiro@socionext.com>2018-01-18 01:28:13 +0900
committerUlf Hansson <ulf.hansson@linaro.org>2018-03-05 13:03:48 +0100
commitc7cd630a9751b9ec8bba37edbba06a29e7d9a14b (patch)
treee2477df48b6f37621895b045cc11d3d165d93556 /.cocciconfig
parent497d1f965c207f1d670066e9c87a2ffad1ce4e5e (diff)
downloadtalos-obmc-linux-c7cd630a9751b9ec8bba37edbba06a29e7d9a14b.tar.gz
talos-obmc-linux-c7cd630a9751b9ec8bba37edbba06a29e7d9a14b.zip
mmc: tmio: fix never-detected card insertion bug
The TMIO mmc cannot detect the card insertion in native_hotplug mode if the driver is probed without a card inserted. The reason is obvious; all IRQs are disabled by tmio_mmc_host_probe(), as follows: tmio_mmc_disable_mmc_irqs(_host, TMIO_MASK_ALL); The card event IRQs are first enabled by tmio_mmc_start_command() as follows: if (!host->native_hotplug) irq_mask &= ~(TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT); tmio_mmc_enable_mmc_irqs(host, irq_mask); If the driver is probed without a card, tmio_mmc_start_command() is never called in the first place. So, the card is never detected. The card event IRQs must be enabled in probe/resume functions. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Diffstat (limited to '.cocciconfig')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud