summaryrefslogtreecommitdiffstats
path: root/src/import/chips/centaur/procedures/hwp/memory/p9c_mss_unmask_errors.C
blob: d51b829bed8f1916cc9e28a040fdf89173021b24 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2505
/* IBM_PROLOG_BEGIN_TAG                                                   */
/* This is an automatically generated prolog.                             */
/*                                                                        */
/* $Source: src/import/chips/centaur/procedures/hwp/memory/p9c_mss_unmask_errors.C $ */
/*                                                                        */
/* OpenPOWER HostBoot Project                                             */
/*                                                                        */
/* Contributors Listed Below - COPYRIGHT 2016,2018                        */
/* [+] International Business Machines Corp.                              */
/*                                                                        */
/*                                                                        */
/* Licensed under the Apache License, Version 2.0 (the "License");        */
/* you may not use this file except in compliance with the License.       */
/* You may obtain a copy of the License at                                */
/*                                                                        */
/*     http://www.apache.org/licenses/LICENSE-2.0                         */
/*                                                                        */
/* Unless required by applicable law or agreed to in writing, software    */
/* distributed under the License is distributed on an "AS IS" BASIS,      */
/* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or        */
/* implied. See the License for the specific language governing           */
/* permissions and limitations under the License.                         */
/*                                                                        */
/* IBM_PROLOG_END_TAG                                                     */

///
/// @file p9c_mss_unmask_errors.C
/// @brief Tools for DDR4 DIMMs centaur procedures
///
/// *HWP HWP Owner: Andre Marin <aamarin@us.ibm.com>
/// *HWP HWP Backup: Louis Stermole <stermole@us.ibm.com>
/// *HWP Team: Memory
/// *HWP Level: 2
/// *HWP Consumed by: HB:CI
//
//

//------------------------------------------------------------------------------
//  Includes
//------------------------------------------------------------------------------

#include <p9c_mss_unmask_errors.H>
#include <cen_gen_scom_addresses.H>
#include <fapi2.H>
#include <generic/memory/lib/utils/find.H>

///
/// @brief Sets action regs and mask settings for pervasive errors to their runtime settings.
/// @param[in] i_target Centaur target
/// @return FAPI2_RC_SUCCESS iff okay
///
fapi2::ReturnCode mss_unmask_pervasive_errors(const fapi2::Target<fapi2::TARGET_TYPE_MEMBUF_CHIP>& i_target)
{
    FAPI_INF("ENTER mss_unmask_pervasive_errors()");

    //*************************
    //*************************
    // TP_PERV_LFIR
    //*************************
    //*************************

    fapi2::buffer<uint64_t> l_tp_perv_lfir_mask_or;
    fapi2::buffer<uint64_t> l_tp_perv_lfir_mask_and;
    fapi2::buffer<uint64_t> l_tp_perv_lfir_action0;
    fapi2::buffer<uint64_t> l_tp_perv_lfir_action1;
    fapi2::buffer<uint64_t> l_mem_perv_lfir_mask_or;
    fapi2::buffer<uint64_t> l_mem_perv_lfir_mask_and;
    fapi2::buffer<uint64_t> l_mem_perv_lfir_action0;
    fapi2::buffer<uint64_t> l_mem_perv_lfir_action1;
    fapi2::buffer<uint64_t> l_nest_perv_lfir_mask_or;
    fapi2::buffer<uint64_t> l_nest_perv_lfir_mask_and;
    fapi2::buffer<uint64_t> l_nest_perv_lfir_action0;
    fapi2::buffer<uint64_t> l_nest_perv_lfir_action1;

    //(Action0, Action1, Mask)
    //
    // (0,0,0) = checkstop
    // (0,1,0) = recoverable error
    // (1,0,0) = report unused
    // (1,1,0) = machine check
    // (x,x,1) = error is masked

    // Read action0
    FAPI_TRY(fapi2::getScom(i_target, CEN_LOCAL_FIR_ACTION0_PCB, l_tp_perv_lfir_action0));

    // Read action1
    FAPI_TRY(fapi2::getScom(i_target, CEN_LOCAL_FIR_ACTION1_PCB, l_tp_perv_lfir_action1));

    l_tp_perv_lfir_mask_or.flush<0>();
    l_tp_perv_lfir_mask_and.flush<1>();

    // 0    CFIR internal parity error          recoverable     unmask
    l_tp_perv_lfir_action0.clearBit<0>();
    l_tp_perv_lfir_action1.setBit<0>();
    l_tp_perv_lfir_mask_and.clearBit<0>();

    // 1    GPIO (PCB error)                    recoverable     mask (forever)
    // 2    CC (PCB error)                      recoverable     mask (forever)
    // 3    CC (OPCG, parity, scan collision)   recoverable     mask (forever)
    // 4    PSC (PCB error)                     recoverable     mask (forever)
    // 5    PSC (parity error)                  recoverable     mask (forever)
    // 6    Thermal (parity error)              recoverable     mask (forever)
    // 7    Thermal (PCB error)                 recoverable     mask (forever)
    // 8    Thermal (critical Trip error)       recoverable     mask (forever)
    // 9    Thermal (fatal Trip error)          recoverable     mask (forever)
    // 10   Thermal (Voltage trip error)        recoverable     mask (forever)
    // 11   Trace Array                         recoverable     mask (forever)
    // 12   Trace Array                         recoverable     mask (forever)
    l_tp_perv_lfir_action0.clearBit<1, 12>();
    l_tp_perv_lfir_action1.setBit<1, 12>();
    l_tp_perv_lfir_mask_or.setBit<1, 12>();

    // 13   ITR                                 recoverable     unmask
    l_tp_perv_lfir_action0.clearBit<13>();
    l_tp_perv_lfir_action1.setBit<13>();
    l_tp_perv_lfir_mask_and.clearBit<13>();

    // 14   ITR                                 recoverable     unmask
    l_tp_perv_lfir_action0.clearBit<14>();
    l_tp_perv_lfir_action1.setBit<14>();
    l_tp_perv_lfir_mask_and.clearBit<14>();


    // 15   ITR (itr_tc_pcbsl_slave_fir_err)    recoverable     mask (forever)
    // 16   PIB                                 recoverable     mask (forever)
    // 17   PIB                                 recoverable     mask (forever)
    // 18   PIB                                 recoverable     mask (forever)
    l_tp_perv_lfir_action0.clearBit<15, 4>();
    l_tp_perv_lfir_action1.setBit<15, 4>();
    l_tp_perv_lfir_mask_or.setBit<15, 4>();


    // NOTE: 19 and 20 already cleared and unmasked in cen_mem_pll_setup.C
    // 19   nest PLLlock                        recoverable     unmask
    // 20   mem PLLlock                         recoverable     unmask

    // 21:39    unused local errors             recoverable     mask (forever)
    // 40   local xstop in another chiplet      recoverable     mask (forever)
    l_tp_perv_lfir_action0.clearBit<21, 20>();
    l_tp_perv_lfir_action1.setBit<21, 20>();
    l_tp_perv_lfir_mask_or.setBit<21, 20>();

    // 41:63    Reserved            not implemented, so won't touch these


    // Write action0
    FAPI_TRY(fapi2::putScom(i_target, CEN_LOCAL_FIR_ACTION0_PCB, l_tp_perv_lfir_action0));

    // Write action1
    FAPI_TRY(fapi2::putScom(i_target, CEN_LOCAL_FIR_ACTION1_PCB, l_tp_perv_lfir_action1));

    // Write mask OR
    FAPI_TRY(fapi2::putScom(i_target, CEN_LOCAL_FIR_MASK_PCB2, l_tp_perv_lfir_mask_or));

    // Write mask AND
    FAPI_TRY(fapi2::putScom(i_target,  CEN_LOCAL_FIR_MASK_PCB1, l_tp_perv_lfir_mask_and));


    //*************************
    //*************************
    // NEST_PERV_LFIR
    //*************************
    //*************************


    //(Action0, Action1, Mask)
    //
    // (0,0,0) = checkstop
    // (0,1,0) = recoverable error
    // (1,0,0) = report unused
    // (1,1,0) = machine check
    // (x,x,1) = error is masked

    l_nest_perv_lfir_action0.flush<0>();
    l_nest_perv_lfir_action1.flush<0>();
    l_nest_perv_lfir_mask_or.flush<0>();
    l_nest_perv_lfir_mask_and.flush<1>();

    // 0    CFIR internal parity error          recoverable     unmask
    l_nest_perv_lfir_action0.clearBit<0>();
    l_nest_perv_lfir_action1.setBit<0>();
    l_nest_perv_lfir_mask_and.clearBit<0>();

    // 1    GPIO (PCB error)                    recoverable     mask (forever)
    // 2    CC (PCB error)                      recoverable     mask (forever)
    // 3    CC (OPCG, parity, scan collision)   recoverable     mask (forever)
    // 4    PSC (PCB error)                     recoverable     mask (forever)
    // 5    PSC (parity error)                  recoverable     mask (forever)
    // 6    Thermal (parity error)              recoverable     mask (forever)
    // 7    Thermal (PCB error)                 recoverable     mask (forever)
    // 8    Thermal (critical Trip error)       recoverable     mask (forever)
    // 9    Thermal (fatal Trip error)          recoverable     mask (forever)
    // 10   Thermal (Voltage trip error)        recoverable     mask (forever)
    // 11   Trace Array                         recoverable     mask (forever)
    // 12   Trace Array                         recoverable     mask (forever)
    // 13:39    unused local errors             recoverable     mask (forever)
    // 40   local xstop in another chiplet      recoverable     mask (forever)
    l_nest_perv_lfir_action0.clearBit<1, 40>();
    l_nest_perv_lfir_action1.setBit<1, 40>();
    l_nest_perv_lfir_mask_or.setBit<1, 40>();

    // 41:63    Reserved            not implemented, so won't touch these

    // Write action0
    FAPI_TRY(fapi2::putScom(i_target, CEN_TCN_LOCAL_FIR_ACTION0_PCB, l_nest_perv_lfir_action0));

    // Write action1
    FAPI_TRY(fapi2::putScom(i_target, CEN_TCN_LOCAL_FIR_ACTION1_PCB, l_nest_perv_lfir_action1));

    // Write mask OR
    FAPI_TRY(fapi2::putScom(i_target, CEN_TCN_LOCAL_FIR_MASK_PCB2, l_nest_perv_lfir_mask_or));

    // Write mask AND
    FAPI_TRY(fapi2::putScom(i_target,  CEN_TCN_LOCAL_FIR_MASK_PCB1, l_nest_perv_lfir_mask_and));

    //*************************
    //*************************
    // MEM_PERV_LFIR
    //*************************
    //*************************

    //(Action0, Action1, Mask)
    //
    // (0,0,0) = checkstop
    // (0,1,0) = recoverable error
    // (1,0,0) = report unused
    // (1,1,0) = machine check
    // (x,x,1) = error is masked

    l_mem_perv_lfir_action0.flush<0>();
    l_mem_perv_lfir_action1.flush<0>();
    l_mem_perv_lfir_mask_or.flush<0>();
    l_mem_perv_lfir_mask_and.flush<1>();

    // 0    CFIR internal parity error          recoverable     unmask
    l_mem_perv_lfir_action0.clearBit<0>();
    l_mem_perv_lfir_action1.setBit<0>();
    l_mem_perv_lfir_mask_and.clearBit<0>();

    // 1    GPIO (PCB error)                    recoverable     mask (forever)
    // 2    CC (PCB error)                      recoverable     mask (forever)
    // 3    CC (OPCG, parity, scan collision)   recoverable     mask (forever)
    // 4    PSC (PCB error)                     recoverable     mask (forever)
    // 5    PSC (parity error)                  recoverable     mask (forever)
    // 6    Thermal (parity error)              recoverable     mask (forever)
    // 7    Thermal (PCB error)                 recoverable     mask (forever)
    // 8    Thermal (critical Trip error)       recoverable     mask (forever)
    // 9    Thermal (fatal Trip error)          recoverable     mask (forever)
    // 10   Thermal (Voltage trip error)        recoverable     mask (forever)
    // 11   mba01 Trace Array                   recoverable     mask (forever)
    // 12   mba01 Trace Array                   recoverable     mask (forever)
    // 13   mba23 Trace Array                   recoverable     mask (forever)
    // 14   mba23 Trace Array                   recoverable     mask (forever)
    // 15:39    unused local errors             recoverable     mask (forever)
    // 40   local xstop in another chiplet      recoverable     mask (forever)
    l_mem_perv_lfir_action0.clearBit<1, 40>();
    l_mem_perv_lfir_action1.setBit<1, 40>();
    l_mem_perv_lfir_mask_or.setBit<1, 40>();

    // 41:63    Reserved            not implemented, so won't touch these

    // Write action0
    FAPI_TRY(fapi2::putScom(i_target, CEN_TCM_LOCAL_FIR_ACTION0_PCB, l_mem_perv_lfir_action0));

    // Write action1
    FAPI_TRY(fapi2::putScom(i_target, CEN_TCM_LOCAL_FIR_ACTION1_PCB, l_mem_perv_lfir_action1));

    // Write mask OR
    FAPI_TRY(fapi2::putScom(i_target, CEN_TCM_LOCAL_FIR_MASK_PCB2, l_mem_perv_lfir_mask_or));

    // Write mask AND
    FAPI_TRY(fapi2::putScom(i_target,  CEN_TCM_LOCAL_FIR_MASK_PCB1, l_mem_perv_lfir_mask_and));

fapi_try_exit:
    FAPI_INF("EXIT mss_unmask_pervasive_errors()");
    return fapi2::current_err;
}

///
/// @brief  Sets action regs and mask settings for inband errors to their runtime settings.
/// @param[in]  i_target Centaur target
/// @return FAPI2_RC_SUCCESS iff okay
/// @note To be called at the end of cen_mem_startclocks.C
///
fapi2::ReturnCode mss_unmask_inband_errors(const fapi2::Target<fapi2::TARGET_TYPE_MEMBUF_CHIP>& i_target)

{
    const auto l_attached_proc_target = mss::find_target<fapi2::TARGET_TYPE_PROC_CHIP>(i_target);

    // Get attribute for HW414700 workaround
    uint8_t l_hw414700 = 0;
    FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CHIP_EC_FEATURE_HW414700, l_attached_proc_target, l_hw414700),
             "Error getting ATTR_CHIP_EC_FEATURE_HW414700");

    FAPI_TRY(unmask_inband_errors_helper(i_target, l_hw414700));

fapi_try_exit:
    return fapi2::current_err;
}

///
/// @brief Helper function for unit testing mss_unmask_inband_errors
/// @param[in]  i_target Centaur target
/// @param[in]  i_hw414700 value of ATTR_CHIP_EC_FEATURE_HW414700
/// @return FAPI2_RC_SUCCESS iff okay
///
fapi2::ReturnCode unmask_inband_errors_helper(const fapi2::Target<fapi2::TARGET_TYPE_MEMBUF_CHIP>& i_target,
        const uint8_t i_hw414700)

{
    FAPI_INF("ENTER mss_unmask_inband_errors()");

    //*************************
    //*************************
    // MBS_FIR_REG
    //*************************
    //*************************

    fapi2::buffer<uint64_t> l_mbs_fir_mask;
    fapi2::buffer<uint64_t> l_mbs_fir_mask_or;
    fapi2::buffer<uint64_t> l_mbs_fir_mask_and;
    fapi2::buffer<uint64_t> l_mbs_fir_action0;
    fapi2::buffer<uint64_t> l_mbs_fir_action1;

    uint8_t l_dd2_fir_bit_defn_changes = 0;

    // Get attribute that tells us if mbspa 0 cmd complete attention is fixed for dd2
    FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CEN_CENTAUR_EC_FEATURE_DD2_FIR_BIT_DEFN_CHANGES, i_target,
                           l_dd2_fir_bit_defn_changes),
             "Error getting ATTR_CEN_CENTAUR_EC_FEATURE_DD2_FIR_BIT_DEFN_CHANGES");

    // Read mask
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBS_FIR_MASK_REG, l_mbs_fir_mask));


    //(Action0, Action1, Mask)
    //
    // (0,0,0) = checkstop
    // (0,1,0) = recoverable error
    // (1,0,0) = report unused
    // (1,1,0) = machine check
    // (x,x,1) = error is masked

    l_mbs_fir_action0.flush<0>();
    l_mbs_fir_action1.flush<0>();
    l_mbs_fir_mask_or.flush<0>();
    l_mbs_fir_mask_and.flush<1>();

    // 0    host_protocol_error     channel checkstop   unmask
    l_mbs_fir_action0.clearBit<0>();
    l_mbs_fir_action1.clearBit<0>();
    l_mbs_fir_mask_and.clearBit<0>();

    // 1    int_protocol_error      channel checkstop   unmask
    l_mbs_fir_action0.clearBit<1>();
    l_mbs_fir_action1.clearBit<1>();
    l_mbs_fir_mask_and.clearBit<1>();

    // 2    invalid_address_error   channel checkstop   mask (until unmask_fetch_errors)
    l_mbs_fir_action0.clearBit<2>();
    l_mbs_fir_action1.clearBit<2>();
    l_mbs_fir_mask_or.setBit<2>();

    // 3    external_timeout        masked off as request for Obus cable recovery support
    l_mbs_fir_action0.clearBit<3>();
    l_mbs_fir_action1.setBit<3>();
    l_mbs_fir_mask_or.setBit<3>();

    // 4    internal_timeout        recoverable         mask (until unmask_fetch_errors)
    l_mbs_fir_action0.clearBit<4>();
    l_mbs_fir_action1.setBit<4>();
    l_mbs_fir_mask_or.setBit<4>();

    // 5    int_buffer_ce           recoverable         unmask
    l_mbs_fir_action0.clearBit<5>();
    l_mbs_fir_action1.setBit<5>();
    l_mbs_fir_mask_and.clearBit<5>();

    // 6    int_buffer_ue           channel checkstop   unmask
    // HW278850: 8B ecc UE from SRB,PFB not transformed to SUE when allocating into L4
    l_mbs_fir_action0.clearBit<6>();
    l_mbs_fir_action1.clearBit<6>();
    l_mbs_fir_mask_and.clearBit<6>();

    // 7    int_buffer_sue          recoverable         mask (forever)
    l_mbs_fir_action0.clearBit<7>();
    l_mbs_fir_action1.setBit<7>();
    l_mbs_fir_mask_or.setBit<7>();

    // 8    int_parity_error        channel checkstop   unmask
    l_mbs_fir_action0.clearBit<8>();
    l_mbs_fir_action1.clearBit<8>();
    l_mbs_fir_mask_and.clearBit<8>();

    // 9    cache_srw_ce            recoverable         mask (until unmask_fetch_errors)
    l_mbs_fir_action0.clearBit<9>();
    l_mbs_fir_action1.setBit<9>();
    l_mbs_fir_mask_or.setBit<9>();

    // 10    cache_srw_ue           recoverable         mask (until unmask_fetch_errors)
    //       hw414700               channel checkstop   mask (until unmask_fetch_errors)

    if (i_hw414700)
    {
        l_mbs_fir_action0.clearBit<10>();
        l_mbs_fir_action1.clearBit<10>();
        l_mbs_fir_mask_or.setBit<10>();
    }
    else
    {
        l_mbs_fir_action0.clearBit<10>();
        l_mbs_fir_action1.setBit<10>();
        l_mbs_fir_mask_or.setBit<10>();
    }

    // 11    cache_srw_sue          recoverable         mask (forever)
    l_mbs_fir_action0.clearBit<11>();
    l_mbs_fir_action1.setBit<11>();
    l_mbs_fir_mask_or.setBit<11>();

    // 12    cache_co_ce            recoverable         mask (until unmask_fetch_errors)
    l_mbs_fir_action0.clearBit<12>();
    l_mbs_fir_action1.setBit<12>();
    l_mbs_fir_mask_or.setBit<12>();

    // 13    cache_co_ue            recoverable         mask (until unmask_fetch_errors)
    //       hw414700               channel checkstop   mask (until unmask_fetch_errors)
    if (i_hw414700)
    {
        l_mbs_fir_action0.clearBit<13>();
        l_mbs_fir_action1.clearBit<13>();
        l_mbs_fir_mask_or.setBit<13>();
    }
    else
    {
        l_mbs_fir_action0.clearBit<13>();
        l_mbs_fir_action1.setBit<13>();
        l_mbs_fir_mask_or.setBit<13>();
    }

    // 14    cache_co_sue           recoverable         mask (forever)
    l_mbs_fir_action0.clearBit<14>();
    l_mbs_fir_action1.setBit<14>();
    l_mbs_fir_mask_or.setBit<14>();

    // 15    dir_ce                 recoverable    DD1: mask (forever)
    // 15    dir_ce                 recoverable    DD2: mask (until unmask_fetch_errors)
    l_mbs_fir_action0.clearBit<15>();
    l_mbs_fir_action1.setBit<15>();
    l_mbs_fir_mask_or.setBit<15>();

    // 16    dir_ue                 channel checkstop   mask (until unmask_fetch_errors)
    l_mbs_fir_action0.clearBit<16>();
    l_mbs_fir_action1.clearBit<16>();
    l_mbs_fir_mask_or.setBit<16>();

    // 17    dir_member_deleted     recoverable         mask (forever)
    l_mbs_fir_action0.clearBit<17>();
    l_mbs_fir_action1.setBit<17>();
    l_mbs_fir_mask_or.setBit<17>();

    // 18    dir_all_members_deleted channel checkstop  mask (until unmask_fetch_errors)
    l_mbs_fir_action0.clearBit<18>();
    l_mbs_fir_action1.clearBit<18>();
    l_mbs_fir_mask_or.setBit<18>();

    // 19    lru_error               recoverable        mask (until unmask_fetch_errors)
    l_mbs_fir_action0.clearBit<19>();
    l_mbs_fir_action1.setBit<19>();
    l_mbs_fir_mask_or.setBit<19>();

    // 20    eDRAM error             channel checkstop  mask (until unmask_fetch_errors)
    l_mbs_fir_action0.clearBit<20>();
    l_mbs_fir_action1.clearBit<20>();
    l_mbs_fir_mask_or.setBit<20>();

    // 21    emergency_throttle_set  recoverable        mask (forever)
    l_mbs_fir_action0.clearBit<21>();
    l_mbs_fir_action1.setBit<21>();
    l_mbs_fir_mask_or.setBit<21>();

    // 22    Host Inband Read Error  recoverable        mask (forever)
    l_mbs_fir_action0.clearBit<22>();
    l_mbs_fir_action1.setBit<22>();
    l_mbs_fir_mask_or.setBit<22>();

    // 23    Host Inband Write Error recoverable        mask (forever)
    l_mbs_fir_action0.clearBit<23>();
    l_mbs_fir_action1.setBit<23>();
    l_mbs_fir_mask_or.setBit<23>();

    // 24    OCC Inband Read Error   recoverable        mask (forever)
    l_mbs_fir_action0.clearBit<24>();
    l_mbs_fir_action1.setBit<24>();
    l_mbs_fir_mask_or.setBit<24>();

    // 25    OCC Inband Write Error  recoverable        mask (forever)
    l_mbs_fir_action0.clearBit<25>();
    l_mbs_fir_action1.setBit<25>();
    l_mbs_fir_mask_or.setBit<25>();

    // 26    srb_buffer_ce           recoverable        mask (until unmask_fetch_errors)
    l_mbs_fir_action0.clearBit<26>();
    l_mbs_fir_action1.setBit<26>();
    l_mbs_fir_mask_or.setBit<26>();

    // 27    srb_buffer_ue           recoverable         mask (until unmask_fetch_errors)
    //       hw414700                channel checkstop   mask (until unmask_fetch_errors)
    if (i_hw414700)
    {
        l_mbs_fir_action0.clearBit<27>();
        l_mbs_fir_action1.clearBit<27>();
        l_mbs_fir_mask_or.setBit<27>();
    }
    else
    {
        l_mbs_fir_action0.clearBit<27>();
        l_mbs_fir_action1.setBit<27>();
        l_mbs_fir_mask_or.setBit<27>();
    }

    // 28    srb_buffer_sue          recoverable         mask (forever)
    l_mbs_fir_action0.clearBit<28>();
    l_mbs_fir_action1.setBit<28>();
    l_mbs_fir_mask_or.setBit<28>();

    if (l_dd2_fir_bit_defn_changes)
    {
        // 29    dir_purge_ce               recoverable          mask
        l_mbs_fir_action0.clearBit<29>();
        l_mbs_fir_action1.setBit<29>();
        l_mbs_fir_mask_or.setBit<29>();

        // 30    proximal_ce_ue             channel checkstop    mask (until unmask_fetch_errors)
        l_mbs_fir_action0.clearBit<30>();
        l_mbs_fir_action1.clearBit<30>();
        l_mbs_fir_mask_or.setBit<30>();

        // 31    spare                      recoverable          mask
        l_mbs_fir_action0.clearBit<31>();
        l_mbs_fir_action1.setBit<31>();
        l_mbs_fir_mask_or.setBit<31>();

        // 32    spare                      recoverable          mask
        l_mbs_fir_action0.clearBit<32>();
        l_mbs_fir_action1.setBit<32>();
        l_mbs_fir_mask_or.setBit<33>();

        // 33    internal_scom_error        recoverable          unmask
        l_mbs_fir_action0.clearBit<33>();
        l_mbs_fir_action1.setBit<33>();
        l_mbs_fir_mask_and.clearBit<33>();

        // 34    internal_scom_error_copy   recoverable          unmask
        l_mbs_fir_action0.clearBit<34>();
        l_mbs_fir_action1.setBit<34>();
        l_mbs_fir_mask_and.clearBit<34>();

        // 35:63    Reserved                not implemented, so won't touch these
    }

    else
    {
        // 29    internal_scom_error     recoverable         unmask
        l_mbs_fir_action0.clearBit<29>();
        l_mbs_fir_action1.setBit<29>();
        l_mbs_fir_mask_and.clearBit<29>();

        // 30    internal_scom_error_copy recoverable        unmask
        l_mbs_fir_action0.clearBit<30>();
        l_mbs_fir_action1.setBit<30>();
        l_mbs_fir_mask_and.clearBit<30>();

        // 31:63    Reserved                not implemented, so won't touch these
    }

    // Write action0
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBS_FIR_ACTION0_REG_RO, l_mbs_fir_action0));
    // Write action1
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBS_FIR_ACTION1_REG_RO, l_mbs_fir_action1));


    // Write mask OR
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBS_FIR_MASK_REG_WO_OR, l_mbs_fir_mask_or));
    // Write mask AND
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBS_FIR_MASK_REG_WO_AND, l_mbs_fir_mask_and))


    //************************************************
    // DEBUG: read them all back to verify
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBS_FIR_ACTION0_REG_RO, l_mbs_fir_action0));
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBS_FIR_ACTION1_REG_RO, l_mbs_fir_action1));
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBS_FIR_MASK_REG, l_mbs_fir_mask));

    //************************************************

fapi_try_exit:
    FAPI_INF("EXIT mss_unmask_inband_errors()");
    return fapi2::current_err;

}

///
/// @brief Sets action regs and mask settings for ddr phy errors to runtime settings.
/// @param[in]  i_target MBA target
/// @return FAPI2_RC_SUCCESS iff okay
/// @note To be called at the end of proc_cen_framelock.C
///
fapi2::ReturnCode mss_unmask_ddrphy_errors(const fapi2::Target<fapi2::TARGET_TYPE_MBA>& i_target)
{
    FAPI_INF("ENTER mss_unmask ddrphy_errors()");

    //*************************
    //*************************
    // DDRPHY_FIR_REG
    //*************************
    //*************************

    fapi2::buffer<uint64_t> l_ddrphy_fir_mask;
    fapi2::buffer<uint64_t> l_ddrphy_fir_mask_or;
    fapi2::buffer<uint64_t> l_ddrphy_fir_mask_and;
    fapi2::buffer<uint64_t> l_ddrphy_fir_action0;
    fapi2::buffer<uint64_t> l_ddrphy_fir_action1;
    fapi2::buffer<uint64_t> l_mbafir_mask;
    fapi2::buffer<uint64_t> l_mbafir_mask_or;
    fapi2::buffer<uint64_t> l_mbafir_mask_and;
    fapi2::buffer<uint64_t> l_mbafir_action0;
    fapi2::buffer<uint64_t> l_mbafir_action1;

    uint8_t l_dd2_fir_bit_defn_changes = 0;
    fapi2::Target<fapi2::TARGET_TYPE_MEMBUF_CHIP> l_targetCentaur;

    //(Action0, Action1, Mask)
    //
    // (0,0,0) = checkstop
    // (0,1,0) = recoverable error
    // (1,0,0) = report unused
    // (1,1,0) = machine check
    // (x,x,1) = error is masked

    l_ddrphy_fir_action0.flush<0>();
    l_ddrphy_fir_action1.flush<0>();
    l_ddrphy_fir_mask_or.flush<0>();
    l_ddrphy_fir_mask_and.flush<0>();
    l_ddrphy_fir_mask_and.setBit<48, 16>();

    // 0:47 Reserved                not implemented, so won't touch these

    // 48   ddr0_fsm_ckstp          channel checkstop   unmask
    l_ddrphy_fir_action0.clearBit<48>();
    l_ddrphy_fir_action1.clearBit<48>();
    l_ddrphy_fir_mask_and.clearBit<48>();

    // 49   ddr0_parity_ckstp       channel checkstop   unmask
    l_ddrphy_fir_action0.clearBit<49>();
    l_ddrphy_fir_action1.clearBit<49>();
    l_ddrphy_fir_mask_and.clearBit<49>();

    // 50   ddr0_calibration_error  recoverable         mask (forever)
    l_ddrphy_fir_action0.clearBit<50>();
    l_ddrphy_fir_action1.setBit<50>();
    l_ddrphy_fir_mask_or.setBit<50>();

    // 51   ddr0_fsm_err            recoverable         unmask
    l_ddrphy_fir_action0.clearBit<51>();
    l_ddrphy_fir_action1.setBit<51>();
    l_ddrphy_fir_mask_and.clearBit<51>();

    // 52   ddr0_parity_err         recoverable         unmask
    l_ddrphy_fir_action0.clearBit<52>();
    l_ddrphy_fir_action1.setBit<52>();
    l_ddrphy_fir_mask_and.clearBit<52>();

    // 53   ddr01_fir_parity_err    recoverable         unmask
    l_ddrphy_fir_action0.clearBit<53>();
    l_ddrphy_fir_action1.setBit<53>();
    l_ddrphy_fir_mask_and.clearBit<53>();

    // 54   Reserved                recoverable         mask (forever)
    l_ddrphy_fir_action0.clearBit<54>();
    l_ddrphy_fir_action1.setBit<54>();
    l_ddrphy_fir_mask_or.setBit<54>();

    // 55   Reserved                recoverable         mask (forever)
    l_ddrphy_fir_action0.clearBit<55>();
    l_ddrphy_fir_action1.setBit<55>();
    l_ddrphy_fir_mask_or.setBit<55>();

    // 56   ddr1_fsm_ckstp          channel checkstop   unmask
    l_ddrphy_fir_action0.clearBit<56>();
    l_ddrphy_fir_action1.clearBit<56>();
    l_ddrphy_fir_mask_and.clearBit<56>();

    // 57   ddr1_parity_ckstp       channel checkstop   unmask
    l_ddrphy_fir_action0.clearBit<57>();
    l_ddrphy_fir_action1.clearBit<57>();
    l_ddrphy_fir_mask_and.clearBit<57>();

    // 58   ddr1_calibration_error  recoverable         mask (forever)
    l_ddrphy_fir_action0.clearBit<58>();
    l_ddrphy_fir_action1.setBit<58>();
    l_ddrphy_fir_mask_or.setBit<58>();

    // 59   ddr1_fsm_err            recoverable         unmask
    l_ddrphy_fir_action0.clearBit<59>();
    l_ddrphy_fir_action1.setBit<59>();
    l_ddrphy_fir_mask_and.clearBit<59>();

    // 60   ddr1_parity_err         recoverable         unmask
    l_ddrphy_fir_action0.clearBit<60>();
    l_ddrphy_fir_action1.setBit<60>();
    l_ddrphy_fir_mask_and.clearBit<60>();

    // 61   Reserved                recoverable         mask (forever)
    l_ddrphy_fir_action0.clearBit<61>();
    l_ddrphy_fir_action1.setBit<61>();
    l_ddrphy_fir_mask_or.setBit<61>();

    // 62   Reserved                recoverable         mask (forever)
    l_ddrphy_fir_action0.clearBit<62>();
    l_ddrphy_fir_action1.setBit<62>();
    l_ddrphy_fir_mask_or.setBit<62>();

    // 63   Reserved                recoverable         mask (forever)
    l_ddrphy_fir_action0.clearBit<63>();
    l_ddrphy_fir_action1.setBit<63>();
    l_ddrphy_fir_mask_or.setBit<63>();

    // Write action0
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBA_PHY01_DDRPHY_FIR_ACTION0_REG_RO, l_ddrphy_fir_action0));

    // Write action1
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBA_PHY01_DDRPHY_FIR_ACTION1_REG_RO, l_ddrphy_fir_action1));

    // Write mask OR
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBA_PHY01_DDRPHY_FIR_MASK_REG_WO_OR, l_ddrphy_fir_mask_or));
    // Write mask AND
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBA_PHY01_DDRPHY_FIR_MASK_REG_WO_AND, l_ddrphy_fir_mask_and));

    //************************************************
    // DEBUG: read them all back to verify
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBA_PHY01_DDRPHY_FIR_ACTION0_REG_RO, l_ddrphy_fir_action0));
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBA_PHY01_DDRPHY_FIR_ACTION1_REG_RO, l_ddrphy_fir_action1));
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBA_PHY01_DDRPHY_FIR_MASK_REG, l_ddrphy_fir_mask));

    //************************************************


    //*************************
    //*************************
    // MBAFIR
    //*************************
    //*************************

    // Get Centaur target for the given MBA
    l_targetCentaur = i_target.getParent<fapi2::TARGET_TYPE_MEMBUF_CHIP>();
    // Get attribute that tells us if mbspa 0 cmd complete attention is fixed for dd2
    FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CEN_CENTAUR_EC_FEATURE_DD2_FIR_BIT_DEFN_CHANGES, l_targetCentaur,
                           l_dd2_fir_bit_defn_changes), "Error getting ATTR_CEN_CENTAUR_EC_FEATURE_DD2_FIR_BIT_DEFN_CHANGES");


    // Read mask
    FAPI_TRY(fapi2::getScom(i_target,
                            CEN_MBA_MBAFIRMASK,
                            l_mbafir_mask));

    //(Action0, Action1, Mask)
    //
    // (0,0,0) = checkstop
    // (0,1,0) = recoverable error
    // (1,0,0) = report unused
    // (1,1,0) = machine check
    // (x,x,1) = error is masked

    l_mbafir_action0.flush<0>();
    l_mbafir_action1.flush<0>();
    l_mbafir_mask_or.flush<0>();
    l_mbafir_mask_and.flush<1>();


    // 0    Invalid_Maint_Cmd           recoverable         masked (forever)
    l_mbafir_action0.clearBit<0>();
    l_mbafir_action1.setBit<0>();
    l_mbafir_mask_or.setBit<0>();

    // 1    Invalid_Maint_Address       recoverable         masked (forever)
    l_mbafir_action0.clearBit<1>();
    l_mbafir_action1.setBit<1>();
    l_mbafir_mask_or.setBit<1>();

    // 2    Multi_address_Maint_timeout recoverable         masked (until mss_unmask_maint_errors)
    l_mbafir_action0.clearBit<2>();
    l_mbafir_action1.setBit<2>();
    l_mbafir_mask_or.setBit<2>();

    // 3    Internal_fsm_error          channel checkstop   unmask
    l_mbafir_action0.clearBit<3>();
    l_mbafir_action1.clearBit<3>();
    l_mbafir_mask_and.clearBit<3>();

    // 4    MCBIST_Error                recoverable         mask (forever)
    l_mbafir_action0.clearBit<4>();
    l_mbafir_action1.setBit<4>();
    l_mbafir_mask_or.setBit<4>();

    // 5    scom_cmd_reg_pe             channel checkstop   unmask
    l_mbafir_action0.clearBit<5>();
    l_mbafir_action1.clearBit<5>();
    l_mbafir_mask_and.clearBit<5>();

    // 6    channel_chkstp_err          channel checkstop   unmask
    l_mbafir_action0.clearBit<6>();
    l_mbafir_action1.clearBit<6>();
    l_mbafir_mask_and.clearBit<6>();

    // 7    wrd_caw2_data_ce_ue_err     channel checkstop   masked (until mss_unmask_maint_errors)
    l_mbafir_action0.clearBit<7>();
    l_mbafir_action1.clearBit<7>();
    l_mbafir_mask_or.setBit<7>();

    if (l_dd2_fir_bit_defn_changes)
    {
        // 8    maint_1hot_st_error_dd2 channel checkstop   unmask
        l_mbafir_action0.clearBit<8>();
        l_mbafir_action1.clearBit<8>();
        l_mbafir_mask_and.clearBit<8>();
    }
    else
    {
        // 8    RESERVED                recoverable         mask (forever)
        l_mbafir_action0.clearBit<8>();
        l_mbafir_action1.setBit<8>();
        l_mbafir_mask_or.setBit<8>();
    }

    // 9:14 RESERVED                    recoverable         mask (forever)
    l_mbafir_action0.clearBit<9, 6>();
    l_mbafir_action1.setBit<9, 6>();
    l_mbafir_mask_or.setBit<9, 6>();

    // 15   internal scom error         recoverable         unmask
    l_mbafir_action0.clearBit<15>();
    l_mbafir_action1.setBit<15>();
    l_mbafir_mask_and.clearBit<15>();

    // 16   internal scom error clone   recoverable         unmask
    l_mbafir_action0.clearBit<16>();
    l_mbafir_action1.setBit<16>();
    l_mbafir_mask_and.clearBit<16>();


    // 17:63 RESERVED           not implemented, so won't touch these

    // Write action0
    FAPI_TRY(fapi2::putScom(i_target,
                            CEN_MBA_MBAFIRACT0,
                            l_mbafir_action0));

    // Write action1
    FAPI_TRY(fapi2::putScom(i_target,
                            CEN_MBA_MBAFIRACT1,
                            l_mbafir_action1));

    // Write mask OR
    FAPI_TRY(fapi2::putScom(i_target,
                            CEN_MBA_MBAFIRMASK_WO_OR,
                            l_mbafir_mask_or));


    // Write mask AND
    FAPI_TRY(fapi2::putScom(i_target,
                            CEN_MBA_MBAFIRMASK_WO_AND,
                            l_mbafir_mask_and));


    //************************************************
    // DEBUG: read them all back to verify
    FAPI_TRY(fapi2::getScom(i_target,
                            CEN_MBA_MBAFIRACT0,
                            l_mbafir_action0));
    FAPI_TRY(fapi2::getScom(i_target,
                            CEN_MBA_MBAFIRACT1,
                            l_mbafir_action1));
    FAPI_TRY(fapi2::getScom(i_target,
                            CEN_MBA_MBAFIRMASK,
                            l_mbafir_mask));

    //************************************************

fapi_try_exit:
    FAPI_INF("EXIT mss_unmask_ddrphy_errors()");
    return fapi2::current_err;
}

///
/// @brief Sets MBACALFIR action regs to their runtime settings.
///        Unmasks errors that are valid for PRD to handle after mss_draminit procedure.
/// @param[in]  i_target MBA target
/// @return FAPI2_RC_SUCCESS iff okay
/// @note To be called at the end of mss_draminit.C.
///
fapi2::ReturnCode mss_unmask_draminit_errors(const fapi2::Target<fapi2::TARGET_TYPE_MBA>& i_target)
{
    FAPI_INF("ENTER mss_unmask_draminit_errors()");

    //*************************
    //*************************
    // MBACALFIR
    //*************************
    //*************************

    fapi2::buffer<uint64_t> l_mbacalfir_mask;
    fapi2::buffer<uint64_t> l_mbacalfir_mask_or;
    fapi2::buffer<uint64_t> l_mbacalfir_mask_and;
    fapi2::buffer<uint64_t> l_mbacalfir_action0;
    fapi2::buffer<uint64_t> l_mbacalfir_action1;

    uint8_t l_dd2_fir_bit_defn_changes = 0;
    fapi2::Target<fapi2::TARGET_TYPE_MEMBUF_CHIP> l_targetCentaur;
    uint8_t l_dimm_type = 0;
    uint8_t l_hw414700 = 0;

    // Get Centaur target for the given MBA
    l_targetCentaur = i_target.getParent<fapi2::TARGET_TYPE_MEMBUF_CHIP>();

    // Get DMI target for given Centaur, and processor for given DMI
    fapi2::Target<fapi2::TARGET_TYPE_DMI> l_attached_dmi_target = l_targetCentaur.getParent<fapi2::TARGET_TYPE_DMI>();
    fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP> l_attached_proc_target =
        l_attached_dmi_target.getParent<fapi2::TARGET_TYPE_PROC_CHIP>();

    // Get attribute for HW414700 workaround
    FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CHIP_EC_FEATURE_HW414700, l_attached_proc_target, l_hw414700),
             "Error getting ATTR_CHIP_EC_FEATURE_HW414700");

    // Get attribute that tells us if mbspa 0 cmd complete attention is fixed for dd2
    FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CEN_CENTAUR_EC_FEATURE_DD2_FIR_BIT_DEFN_CHANGES, l_targetCentaur,
                           l_dd2_fir_bit_defn_changes), "Error getting ATTR_CEN_CENTAUR_EC_FEATURE_DD2_FIR_BIT_DEFN_CHANGES");

    // Get DIMM type
    FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CEN_EFF_DIMM_TYPE, i_target, l_dimm_type), "Error getting ATTR_CEN_EFF_DIMM_TYPE");

    // Read mask
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBA_MBACALFIR_MASK, l_mbacalfir_mask));

    //(Action0, Action1, Mask)
    //
    // (0,0,0) = checkstop
    // (0,1,0) = recoverable error
    // (1,0,0) = report unused
    // (1,1,0) = machine check
    // (x,x,1) = error is masked

    l_mbacalfir_action0.flush<0>();
    l_mbacalfir_action1.flush<0>();
    l_mbacalfir_mask_or.flush<0>();
    l_mbacalfir_mask_and.flush<1>();

    // 0    MBA Recoverable Error       recoverable         mask (until after draminit_training)
    l_mbacalfir_action0.clearBit<0>();
    l_mbacalfir_action1.setBit<0>();
    l_mbacalfir_mask_or.setBit<0>();

    // 1    MBA Nonrecoverable Error    channel checkstop   mask (until after draminit_mc)
    l_mbacalfir_action0.clearBit<1>();
    l_mbacalfir_action1.clearBit<1>();
    l_mbacalfir_mask_or.setBit<1>();

    // 2    Refresh Overrun             recoverable         mask (until after draminit_mc)
    l_mbacalfir_action0.clearBit<2>();
    l_mbacalfir_action1.setBit<2>();
    l_mbacalfir_mask_or.setBit<2>();

    // 3    WAT error                   recoverable         mask (forever)
    l_mbacalfir_action0.clearBit<3>();
    l_mbacalfir_action1.setBit<3>();
    l_mbacalfir_mask_or.setBit<3>();

    // 4    RCD Parity Error 0          recoverable         unmask (if RDIMM or LRDIMM)
    l_mbacalfir_action0.clearBit<4>();
    l_mbacalfir_action1.setBit<4>();

    if ((l_dimm_type == fapi2::ENUM_ATTR_CEN_EFF_DIMM_TYPE_RDIMM)
        || (l_dimm_type == fapi2::ENUM_ATTR_CEN_EFF_DIMM_TYPE_LRDIMM))
    {
        l_mbacalfir_mask_and.clearBit<4>();
    }
    else
    {
        l_mbacalfir_mask_or.setBit<4>();
    }

    // 5    ddr0_cal_timeout_err        recoverable         mask (until after draminit_mc)
    l_mbacalfir_action0.clearBit<5>();
    l_mbacalfir_action1.setBit<5>();
    l_mbacalfir_mask_or.setBit<5>();

    // 6    ddr1_cal_timeout_err        recoverable         mask (until after draminit_mc)
    l_mbacalfir_action0.clearBit<6>();
    l_mbacalfir_action1.setBit<6>();
    l_mbacalfir_mask_or.setBit<6>();

    // 7    RCD Parity Error 1          recoverable         unmask (if RDIMM or LRDIMM)
    l_mbacalfir_action0.clearBit<7>();
    l_mbacalfir_action1.setBit<7>();

    if ((l_dimm_type == fapi2::ENUM_ATTR_CEN_EFF_DIMM_TYPE_RDIMM)
        || (l_dimm_type == fapi2::ENUM_ATTR_CEN_EFF_DIMM_TYPE_LRDIMM))
    {
        l_mbacalfir_mask_and.clearBit<7>();
    }
    else
    {
        l_mbacalfir_mask_or.setBit<7>();
    }

    // 8    mbx to mba par error        channel checkstop   mask (until after draminit_training_adv)
    l_mbacalfir_action0.clearBit<8>();
    l_mbacalfir_action1.clearBit<8>();
    l_mbacalfir_mask_or.setBit<8>();

    // 9    mba_wrd ue                  recoverable         mask (until mainline traffic)
    //      hw414700                    channel checkstop   mask (until mainline traffic)

    if (l_hw414700)
    {
        l_mbacalfir_action0.clearBit<9>();
        l_mbacalfir_action1.clearBit<9>();
        l_mbacalfir_mask_or.setBit<9>();
    }
    else
    {
        l_mbacalfir_action0.clearBit<9>();
        l_mbacalfir_action1.setBit<9>();
        l_mbacalfir_mask_or.setBit<9>();
    }

    // 10   mba_wrd ce                  recoverable         mask (until mainline traffic)
    l_mbacalfir_action0.clearBit<10>();
    l_mbacalfir_action1.setBit<10>();
    l_mbacalfir_mask_or.setBit<10>();

    // 11   mba_maint ue                recoverable         mask (until after draminit_training_adv)
    //      hw414700                    channel checkstop   mask (until after draminit_training_adv)
    if (l_hw414700)
    {
        l_mbacalfir_action0.clearBit<11>();
        l_mbacalfir_action1.clearBit<11>();
        l_mbacalfir_mask_or.setBit<11>();
    }
    else
    {
        l_mbacalfir_action0.clearBit<11>();
        l_mbacalfir_action1.setBit<11>();
        l_mbacalfir_mask_or.setBit<11>();
    }

    // 12   mba_maint ce                recoverable         mask (until after draminit_training_adv)
    l_mbacalfir_action0.clearBit<12>();
    l_mbacalfir_action1.setBit<12>();
    l_mbacalfir_mask_or.setBit<12>();

    // 13   ddr_cal_reset_timeout       channel checkstop   unmask
    l_mbacalfir_action0.clearBit<13>();
    l_mbacalfir_action1.clearBit<13>();
    l_mbacalfir_mask_and.clearBit<13>();

    // 14   wrq_data_ce                 recoverable         mask (until mainline traffic)
    l_mbacalfir_action0.clearBit<14>();
    l_mbacalfir_action1.setBit<14>();
    l_mbacalfir_mask_or.setBit<14>();

    // 15   wrq_data_ue                 recoverable         mask (until mainline traffic)
    //      hw414700                    channel checkstop   mask (until mainline traffic)
    if (l_hw414700)
    {
        l_mbacalfir_action0.clearBit<15>();
        l_mbacalfir_action1.clearBit<15>();
        l_mbacalfir_mask_or.setBit<15>();
    }
    else
    {
        l_mbacalfir_action0.clearBit<15>();
        l_mbacalfir_action1.setBit<15>();
        l_mbacalfir_mask_or.setBit<15>();
    }

    // 16   wrq_data_sue                recoverable         mask (forever)
    l_mbacalfir_action0.clearBit<16>();
    l_mbacalfir_action1.setBit<16>();
    l_mbacalfir_mask_or.setBit<16>();

    // 17   wrq_rrq_hang_err            recoverable         mask (until after draminit_training_adv)
    l_mbacalfir_action0.clearBit<17>();
    l_mbacalfir_action1.setBit<17>();
    l_mbacalfir_mask_or.setBit<17>();

    // 18   sm_1hot_err                 channel checkstop   unmask
    l_mbacalfir_action0.clearBit<18>();
    l_mbacalfir_action1.clearBit<18>();
    l_mbacalfir_mask_and.clearBit<18>();

    // 19   wrd_scom_error              recoverable         unmask
    l_mbacalfir_action0.clearBit<19>();
    l_mbacalfir_action1.setBit<19>();
    l_mbacalfir_mask_and.clearBit<19>();

    if (l_dd2_fir_bit_defn_changes)
    {
        // 20   rhmr_prim_reached_max       recoverable         mask (forever)
        l_mbacalfir_action0.clearBit<20>();
        l_mbacalfir_action1.setBit<20>();
        l_mbacalfir_mask_or.setBit<20>();

        // 21   rhmr_sec_reached_max        recoverable         mask (forever)
        l_mbacalfir_action0.clearBit<21>();
        l_mbacalfir_action1.setBit<21>();
        l_mbacalfir_mask_or.setBit<21>();

        // 22   rhmr_sec_already_full       recoverable         mask (forever)
        l_mbacalfir_action0.clearBit<22>();
        l_mbacalfir_action1.setBit<22>();
        l_mbacalfir_mask_or.setBit<22>();

        // 23   Reserved                    recoverable         mask (forever)
        l_mbacalfir_action0.clearBit<23>();
        l_mbacalfir_action1.setBit<23>();
        l_mbacalfir_mask_or.setBit<23>();

        // 24   internal_scom_error         recoverable         unmask
        l_mbacalfir_action0.clearBit<24>();
        l_mbacalfir_action1.setBit<24>();
        l_mbacalfir_mask_and.clearBit<24>();

        // 25   internal_scom_error_copy    recoverable         unmask
        l_mbacalfir_action0.clearBit<25>();
        l_mbacalfir_action1.setBit<25>();
        l_mbacalfir_mask_and.clearBit<25>();

        // 26-63    Reserved            not implemented, so won't touch these
    }
    else
    {
        // 20   internal_scom_error         recoverable         unmask
        l_mbacalfir_action0.clearBit<20>();
        l_mbacalfir_action1.setBit<20>();
        l_mbacalfir_mask_and.clearBit<20>();

        // 21   internal_scom_error_copy    recoverable         unmask
        l_mbacalfir_action0.clearBit<21>();
        l_mbacalfir_action1.setBit<21>();
        l_mbacalfir_mask_and.clearBit<21>();

        // 22-63    Reserved            not implemented, so won't touch these
    }


    // Write action0
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBA_MBACALFIR_ACTION0, l_mbacalfir_action0));

    // Write action1
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBA_MBACALFIR_ACTION1, l_mbacalfir_action1));

    // Write mask OR
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBA_MBACALFIR_MASK_WO_OR, l_mbacalfir_mask_or));

    // Write mask AND
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBA_MBACALFIR_MASK_WO_AND, l_mbacalfir_mask_and));

    //************************************************
    // DEBUG: read them all back to verify
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBA_MBACALFIR_ACTION0, l_mbacalfir_action0));
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBA_MBACALFIR_ACTION1, l_mbacalfir_action1));
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBA_MBACALFIR_MASK, l_mbacalfir_mask));

    //************************************************

fapi_try_exit:
    FAPI_INF("EXIT mss_unmask_draminit_errors()");
    return fapi2::current_err;
}

///
/// @brief Unmasks MBACALFIR errors that are valid for PRD to handle after mss_draminit_training
/// @param[in]  i_target MBA target
/// @return FAPI2_RC_SUCCESS iff okay
/// @note To be called at the end of mss_draminit_training.C.
///
fapi2::ReturnCode mss_unmask_draminit_training_errors(const fapi2::Target<fapi2::TARGET_TYPE_MBA>& i_target)
{
    FAPI_INF("ENTER mss_unmask_draminit_training_errors()");

    //*************************
    //*************************
    // MBACALFIR
    //*************************
    //*************************

    fapi2::buffer<uint64_t> l_mbacalfir_mask;
    fapi2::buffer<uint64_t> l_mbacalfir_mask_and;

    // NOTE: In the IPL sequence, mss_unmask_draminit_errors has already been
    // called, which has already set the MBACALFIR action regs to their runtime
    // values, so no need to touch the action regs here.

    // NOTE: In the IPL sequence, mss_unmask_draminit_errors has already been
    // called, which has already unmasked the approproiate MBACALFIR errors
    // following mss_draminit. So all we will do here is unmask a few more
    // errors that would be considered valid after the mss_draminit_training
    // procedure.

    // Read mask
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBA_MBACALFIR_MASK, l_mbacalfir_mask));

    //(Action0, Action1, Mask)
    //
    // (0,0,0) = checkstop
    // (0,1,0) = recoverable error
    // (1,0,0) = report unused
    // (1,1,0) = machine check
    // (x,x,1) = error is masked

    l_mbacalfir_mask_and.flush<1>();

    // 0    MBA Recoverable Error       recoverable         umask
    FAPI_TRY(l_mbacalfir_mask_and.clearBit(0));

    // Write mask AND
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBA_MBACALFIR_MASK_WO_AND, l_mbacalfir_mask_and));

    //************************************************
    // DEBUG: read them all back to verify
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBA_MBACALFIR_MASK, l_mbacalfir_mask));

    //************************************************

fapi_try_exit:
    FAPI_INF("EXIT mss_unmask_draminit_training_errors()");
    return fapi2::current_err;
}

///
/// @brief Unmasks MBACALFIR errors that are valid for PRD to handle after mss_draminit_training_advanced
/// @param[in]  i_target MBA target
/// @return FAPI2_RC_SUCCESS iff okay
/// @note To be called at the end of mss_draminit_training_advanced.C.
///
fapi2::ReturnCode mss_unmask_draminit_training_advanced_errors(const fapi2::Target<fapi2::TARGET_TYPE_MBA>& i_target)
{
    FAPI_INF("ENTER mss_unmask_draminit_training_advanced_errors()");

    //*************************
    //*************************
    // MBACALFIR
    //*************************
    //*************************

    fapi2::buffer<uint64_t> l_mbacalfir_mask;
    fapi2::buffer<uint64_t> l_mbacalfir_mask_and;
    fapi2::Target<fapi2::TARGET_TYPE_MEMBUF_CHIP> l_targetCentaur;
    uint8_t l_mbaPosition = 0;             // 0 = mba01, 1 = mba23

    constexpr uint32_t l_mbsfir_mask_address[] =
    {
        // port0/1                       port2/3
        CEN_MCBISTS01_MBSFIRMASK,     CEN_MCBISTS23_MBSFIRMASK
    };

    constexpr uint32_t l_mbsfir_mask_or_address[] =
    {
        // port0/1                       port2/3
        CEN_MCBISTS01_MBSFIRMASK_WO_OR,  CEN_MCBISTS23_MBSFIRMASK_WO_OR
    };

    constexpr uint32_t l_mbsfir_mask_and_address[] =
    {
        // port0/1                       port2/3
        CEN_MCBISTS01_MBSFIRMASK_WO_AND, CEN_MCBISTS23_MBSFIRMASK_WO_AND
    };

    constexpr uint32_t l_mbsfir_action0_address[] =
    {
        // port0/1                       port2/3
        CEN_MCBISTS01_MBSFIRACT0,     CEN_MCBISTS23_MBSFIRACT0
    };

    constexpr uint32_t l_mbsfir_action1_address[] =
    {
        // port0/1                       port2/3
        CEN_MCBISTS01_MBSFIRACT1,     CEN_MCBISTS23_MBSFIRACT1
    };

    fapi2::buffer<uint64_t> l_mbsfir_mask;
    fapi2::buffer<uint64_t> l_mbsfir_mask_or;
    fapi2::buffer<uint64_t> l_mbsfir_mask_and;
    fapi2::buffer<uint64_t> l_mbsfir_action0;
    fapi2::buffer<uint64_t> l_mbsfir_action1;

    // NOTE: In the IPL sequence, mss_unmask_draminit_errors has already been
    // called, which has already set the MBACALFIR action regs to their runtime
    // values, so no need to touch the action regs here.

    // NOTE: In the IPL sequence, mss_unmask_draminit_errors and
    // mss_unmask_draminit_training has already been
    // called, which has already unmasked the approproiate MBACALFIR errors
    // following mss_draminit and mss_draminit_training. So all we will do here
    // is unmask a few more errors that would be considered valid after the
    // mss_draminit_training_advanced procedure.

    // Read mask
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBA_MBACALFIR_MASK, l_mbacalfir_mask));


    //(Action0, Action1, Mask)
    //
    // (0,0,0) = checkstop
    // (0,1,0) = recoverable error
    // (1,0,0) = report unused
    // (1,1,0) = machine check
    // (x,x,1) = error is masked

    l_mbacalfir_mask_and.flush<1>();

    // 8    mbx to mba par error        channel checkstop   unmask
    l_mbacalfir_mask_and.clearBit<8>();

    // 11   mba_maint ue                recoverable         unmask
    l_mbacalfir_mask_and.clearBit<11>();

    // 12   mba_maint ce                recoverable         unmask
    l_mbacalfir_mask_and.clearBit<12>();

    // 17   wrq_rrq_hang_err            recoverable         unmask
    l_mbacalfir_mask_and.clearBit<17>();


    // Write mask AND
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBA_MBACALFIR_MASK_WO_AND, l_mbacalfir_mask_and));

    //************************************************
    // DEBUG: read them all back to verify
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBA_MBACALFIR_MASK, l_mbacalfir_mask));

    //************************************************

    //*************************
    //*************************
    // MBSFIR
    //*************************
    //*************************

    // Get Centaur target for the given MBA
    l_targetCentaur = i_target.getParent<fapi2::TARGET_TYPE_MEMBUF_CHIP>();
    // Get MBA position: 0 = mba01, 1 = mba23
    FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CHIP_UNIT_POS, i_target, l_mbaPosition), "Error getting MBA position");

    // Read mask
    FAPI_TRY(fapi2::getScom(l_targetCentaur,
                            l_mbsfir_mask_address[l_mbaPosition],
                            l_mbsfir_mask));

    //(Action0, Action1, Mask)
    //
    // (0,0,0) = checkstop
    // (0,1,0) = recoverable error
    // (1,0,0) = report unused
    // (1,1,0) = machine check
    // (x,x,1) = error is masked

    l_mbsfir_action0.flush<0>();
    l_mbsfir_action1.flush<0>();
    l_mbsfir_mask_or.flush<0>();
    l_mbsfir_mask_and.flush<1>();

    // 0    scom_par_errors             channel checkstop   unmask
    l_mbsfir_action0.clearBit<0>();
    l_mbsfir_action1.clearBit<0>();
    l_mbsfir_mask_and.clearBit<0>();

    // 1    mbx_par_errors              channel checkstop   unmask
    l_mbsfir_action0.clearBit<1>();
    l_mbsfir_action1.clearBit<1>();
    l_mbsfir_mask_and.clearBit<1>();

    // 2    DD1: reserved               recoverable         mask (forever)
    // 2    DD2: dram_eventn_bit0       recoverable         mask (forever)
    l_mbsfir_action0.clearBit<2>();
    l_mbsfir_action1.setBit<2>();
    l_mbsfir_mask_or.setBit<2>();

    // 3    DD1: reserved               recoverable         mask (forever)
    // 3    DD2: dram_eventn_bit1       recoverable         mask (forever)
    l_mbsfir_action0.clearBit<3>();
    l_mbsfir_action1.setBit<3>();
    l_mbsfir_mask_or.setBit<3>();

    // 4:14 RESERVED                    recoverable         mask (forever)
    l_mbsfir_action0.clearBit<4, 11>();
    l_mbsfir_action1.setBit<4, 11>();
    l_mbsfir_mask_or.setBit<4, 11>();

    // 2:14 RESERVED                    recoverable         mask (forever)
    l_mbsfir_action0.clearBit<2, 13>();
    l_mbsfir_action1.setBit<2, 13>();
    l_mbsfir_mask_or.setBit<2, 13>();

    // 15   internal scom error         recoverable         unmask
    l_mbsfir_action0.clearBit<15>();
    l_mbsfir_action1.setBit<15>();
    l_mbsfir_mask_and.clearBit<15>();

    // 16   internal scom error clone   recoverable         unmask
    l_mbsfir_action0.clearBit<16>();
    l_mbsfir_action1.setBit<16>();
    l_mbsfir_mask_and.clearBit<16>();

    // 17:63 RESERVED           not implemented, so won't touch these

    // Write action0
    FAPI_TRY(fapi2::putScom(l_targetCentaur,
                            l_mbsfir_action0_address[l_mbaPosition],
                            l_mbsfir_action0));

    // Write action1
    FAPI_TRY(fapi2::putScom(l_targetCentaur,
                            l_mbsfir_action1_address[l_mbaPosition],
                            l_mbsfir_action1));

    // Write mask OR
    FAPI_TRY(fapi2::putScom(l_targetCentaur,
                            l_mbsfir_mask_or_address[l_mbaPosition],
                            l_mbsfir_mask_or));

    // Write mask AND
    FAPI_TRY(fapi2::putScom(l_targetCentaur,
                            l_mbsfir_mask_and_address[l_mbaPosition],
                            l_mbsfir_mask_and));

    //************************************************
    // DEBUG: read them all back to verify
    FAPI_TRY(fapi2::getScom(l_targetCentaur,
                            l_mbsfir_action0_address[l_mbaPosition],
                            l_mbsfir_action0));

    FAPI_TRY(fapi2::getScom(l_targetCentaur,
                            l_mbsfir_action1_address[l_mbaPosition],
                            l_mbsfir_action1));

    FAPI_TRY(fapi2::getScom(l_targetCentaur,
                            l_mbsfir_mask_address[l_mbaPosition],
                            l_mbsfir_mask));

    //************************************************

fapi_try_exit:
    FAPI_INF("EXIT mss_unmask_draminit_training_advanced_errors()");
    return fapi2::current_err;

}

///
/// @brief Sets action regs and unmasks maint errors prior to the maint logic
///         Being used in memdiags so that PRD will be able to handle them
///         if they happen during memdiags.
/// @param[in]  i_target MBA target
/// @return FAPI2_RC_SUCCESS iff okay
/// @note To be called at the end of mss_draminit_mc.C.
///
fapi2::ReturnCode mss_unmask_maint_errors(const fapi2::Target<fapi2::TARGET_TYPE_MEMBUF_CHIP>& i_target)
{
    FAPI_INF("ENTER mss_unmask_maint_errors()");

    std::vector<fapi2::Target<fapi2::TARGET_TYPE_MBA>> l_mbaChiplets;
    uint8_t l_mbaPosition = 0;             // 0 = mba01, 1 = mba23

    fapi2::buffer<uint64_t> l_mbacalfir_mask;
    fapi2::buffer<uint64_t> l_mbacalfir_mask_and;

    fapi2::buffer<uint64_t> l_mbafir_mask;
    fapi2::buffer<uint64_t> l_mbafir_mask_and;

    fapi2::buffer<uint64_t> l_mbaspa_mask;

    constexpr uint32_t l_mbeccfir_mask_address[] =
    {
        // port0/1                            port2/3
        CEN_ECC01_MBECCFIR_MASK,   CEN_ECC23_MBECCFIR_MASK
    };

    constexpr uint32_t l_mbeccfir_mask_or_address[] =
    {
        // port0/1                            port2/3
        CEN_ECC01_MBECCFIR_MASK_WO_OR, CEN_ECC23_MBECCFIR_MASK_WO_OR
    };

    constexpr uint32_t l_mbeccfir_mask_and_address[] =
    {
        // port0/1                            port2/3
        CEN_ECC01_MBECCFIR_MASK_WO_AND, CEN_ECC23_MBECCFIR_MASK_WO_AND
    };

    constexpr uint32_t l_mbeccfir_action0_address[] =
    {
        // port0/1                            port2/3
        CEN_ECC01_MBECCFIR_ACTION0_RO, CEN_ECC23_MBECCFIR_ACTION0_RO
    };

    constexpr uint32_t l_mbeccfir_action1_address[] =
    {
        // port0/1                            port2/3
        CEN_ECC01_MBECCFIR_ACTION1_RO, CEN_ECC23_MBECCFIR_ACTION1_RO
    };

    fapi2::buffer<uint64_t> l_mbeccfir_mask;
    fapi2::buffer<uint64_t> l_mbeccfir_mask_or;
    fapi2::buffer<uint64_t> l_mbeccfir_mask_and;
    fapi2::buffer<uint64_t> l_mbeccfir_action0;
    fapi2::buffer<uint64_t> l_mbeccfir_action1;

    uint8_t l_mbspa_0_fixed_for_dd2 = 0;
    uint8_t l_hw414700 = 0;

    fapi2::Target<fapi2::TARGET_TYPE_DMI> l_attached_dmi_target = i_target.getParent<fapi2::TARGET_TYPE_DMI>();
    fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP> l_attached_proc_target =
        l_attached_dmi_target.getParent<fapi2::TARGET_TYPE_PROC_CHIP>();

    // Get attribute for HW414700 workaround
    FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CHIP_EC_FEATURE_HW414700, l_attached_proc_target, l_hw414700),
             "Error getting ATTR_CHIP_EC_FEATURE_HW414700");

    // Get attribute that tells us if mbspa 0 cmd complete attention is fixed for dd2
    FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CEN_CENTAUR_EC_FEATURE_HW217608_MBSPA_0_CMD_COMPLETE_ATTN_FIXED, i_target,
                           l_mbspa_0_fixed_for_dd2), "Error getting ATTR_CEN_CENTAUR_EC_FEATURE_HW217608_MBSPA_0_CMD_COMPLETE_ATTN_FIXED");

    // Get associated functional MBAs on this centaur
    l_mbaChiplets = i_target.getChildren<fapi2::TARGET_TYPE_MBA>();

    // Loop through functional MBAs on this Centaur
    for (uint32_t i = 0; i < l_mbaChiplets.size(); ++i)
    {

        // Get MBA position: 0 = mba01, 1 = mba23
        FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CHIP_UNIT_POS, l_mbaChiplets[i], l_mbaPosition), "Error getting MBA position");

        //*************************
        //*************************
        // MBACALFIR
        //*************************
        //*************************

        // NOTE: In the IPL sequence, mss_unmask_draminit_errors has already been
        // called, which has already set the MBACALFIR action regs to their runtime
        // values, so no need to touch the action regs here.

        // NOTE: In the IPL sequence, mss_unmask_draminit_errors,
        // mss_unmask_draminit_training and mss_unmask_draminit_training_advanced
        // have already been called, which have already unmasked the approproiate
        // MBACALFIR errors following mss_draminit, mss_draminit_training, and
        // mss_unmask_draminit_training_advanced. So all we will do here
        // is unmask a few more errors that would be considered valid after the
        // mss_draminit_mc procedure.

        // Read mask
        FAPI_TRY(fapi2::getScom(l_mbaChiplets[i],
                                CEN_MBA_MBACALFIR_MASK,
                                l_mbacalfir_mask));

        //(Action0, Action1, Mask)
        //
        // (0,0,0) = checkstop
        // (0,1,0) = recoverable error
        // (1,0,0) = report unused
        // (1,1,0) = machine check
        // (x,x,1) = error is masked

        l_mbacalfir_mask_and.flush<1>();

        // 1    MBA Nonrecoverable Error    channel checkstop   unmask
        l_mbacalfir_mask_and.clearBit<1>();

        // 2    Refresh Overrun             recoverable         unmask
        l_mbacalfir_mask_and.clearBit<2>();

        // 5    ddr0_cal_timeout_err        recoverable         unmask
        l_mbacalfir_mask_and.clearBit<5>();

        // 6    ddr1_cal_timeout_err        recoverable         unmask
        l_mbacalfir_mask_and.clearBit<6>();

        // Write mask AND
        FAPI_TRY(fapi2::putScom(l_mbaChiplets[i],
                                CEN_MBA_MBACALFIR_MASK_WO_AND,
                                l_mbacalfir_mask_and));

        //************************************************
        // DEBUG: read them all back to verify
        FAPI_TRY(fapi2::getScom(l_mbaChiplets[i],
                                CEN_MBA_MBACALFIR_MASK,
                                l_mbacalfir_mask));

        //************************************************


        //*************************
        //*************************
        // MBAFIR
        //*************************
        //*************************

        // NOTE: In the IPL sequence, mss_unmask_ddr_phy_errors has already been
        // called, which has already set the MBAFIR action regs to their runtime
        // values, so no need to touch the action regs here.

        // NOTE: In the IPL sequence, mss_unmask_ddr_phy_errors,
        // has already been called, which has already unmasked the approproiate
        // MBAFIR errors following mss_ddr_phy_reset. So all we will do here
        // is unmask a few more errors that would be considered valid after the
        // mss_draminit_mc procedure.

        // Read mask
        FAPI_TRY(fapi2::getScom(l_mbaChiplets[i],
                                CEN_MBA_MBAFIRMASK,
                                l_mbafir_mask));

        //
        // (0,0,0) = checkstop
        // (0,1,0) = recoverable error
        // (1,0,0) = report unused
        // (1,1,0) = machine check
        // (x,x,1) = error is masked

        l_mbafir_mask_and.flush<1>();

        // 2    Multi_address_Maint_timeout recoverable         unmask
        l_mbafir_mask_and.clearBit<2>();


        // 7    wrd_caw2_data_ce_ue_err     channel checkstop   unmask
        l_mbafir_mask_and.clearBit<7>();

        // Write mask AND
        FAPI_TRY(fapi2::putScom(l_mbaChiplets[i],
                                CEN_MBA_MBAFIRMASK_WO_AND,
                                l_mbafir_mask_and));

        //************************************************
        // DEBUG: read them all back to verify
        FAPI_TRY(fapi2::getScom(l_mbaChiplets[i],
                                CEN_MBA_MBAFIRMASK,
                                l_mbafir_mask));

        //************************************************

        //*************************
        //*************************
        // MBSPA
        //*************************
        //*************************


        // Read mask
        FAPI_TRY(fapi2::getScom(l_mbaChiplets[i],
                                CEN_MBA_MBSPAMSKQ,
                                l_mbaspa_mask));

        // 0    Command_Complete
        if (l_mbspa_0_fixed_for_dd2)
        {
            l_mbaspa_mask.clearBit<0>();         // DD2: unmask (fixed)
        }
        else
        {
            l_mbaspa_mask.setBit<0>();           // DD1: masked (broken)
        }

        // 1    Hard_CE_ETE_Attn                             mask (forever)
        // NOTE: FW wants to mask these and rely instead on detecting the
        // cmd complete attention, then checking these manually to see if
        // they cause the cmd to stop
        // NOTE: Hards counted during super fast read, but can't be called
        // true hard CEs since super fast read doesn't write back and read again.
        l_mbaspa_mask.setBit<1>();
        // 2    Soft_CE_ETE_Attn                             mask (forever)
        // NOTE: FW wants to mask these and rely instead on detecting the
        // cmd complete attention, then checking these manually to see if
        // they cause the cmd to stop
        // NOTE: Softs not counted during super fast read.
        l_mbaspa_mask.setBit<2>();

        // 3    Intermittent_ETE_Attn                        mask (forever)
        // NOTE: FW wants to mask these and rely instead on detecting the
        // cmd complete attention, then checking these manually to see if
        // they cause the cmd to stop
        // NOTE: Intermittents not counted during super fast read.
        l_mbaspa_mask.setBit<3>();

        // 4    RCE_ETE_Attn                                 mask (forever)
        // NOTE: FW wants to mask these and rely instead on detecting the
        // cmd complete attention, then checking these manually to see if
        // they cause the cmd to stop
        // NOTE: RCEs not counted during super fast read.
        l_mbaspa_mask.setBit<4>();

        // 5    Emergency_Throttle_Attn                      masked (forever)
        l_mbaspa_mask.setBit<5>();

        // 6    Firmware_Attn0                               masked (forever)
        l_mbaspa_mask.setBit<6>();

        // 7    Firmware_Attn1                               masked (forever)
        l_mbaspa_mask.setBit<7>();

        // 8    wat_debug_attn
        if (l_mbspa_0_fixed_for_dd2)
        {
            l_mbaspa_mask.setBit<8>();           // DD2: masked (workaround for mbspa 0 not needed)
        }
        else
        {
            l_mbaspa_mask.clearBit<8>();         // DD1: unmasked (workaround for mbspa 0 needed)
        }

        // 9    Spare_Attn1                                  masked (forever)
        l_mbaspa_mask.setBit<9>();

        // 10   MCBIST_Done                                  masked (forever)
        l_mbaspa_mask.setBit<10>();

        // 11:63 RESERVED     not implemented, so won't touch these


        // Write mask
        FAPI_TRY(fapi2::putScom(l_mbaChiplets[i],
                                CEN_MBA_MBSPAMSKQ,
                                l_mbaspa_mask));

        // DEBUG: read them all back to verify
        FAPI_TRY(fapi2::getScom(l_mbaChiplets[i],
                                CEN_MBA_MBSPAMSKQ,
                                l_mbaspa_mask));

        //*************************
        //*************************
        // MBECCFIR
        //*************************
        //*************************

        // Read mask
        FAPI_TRY(fapi2::getScom(i_target,
                                l_mbeccfir_mask_address[l_mbaPosition],
                                l_mbeccfir_mask));



        l_mbeccfir_action0.flush<0>();
        l_mbeccfir_action1.flush<0>();
        l_mbeccfir_mask_or.flush<0>();
        l_mbeccfir_mask_and.flush<1>();

        // 0:7  Memory MPE Rank 0:7         recoverable         mask (until mainline traffic)
        l_mbeccfir_action0.clearBit<0, 8>();
        l_mbeccfir_action1.setBit<0, 8>();
        l_mbeccfir_mask_or.setBit<0, 8>();

        // 8:15 Reserved                    recoverable         mask (forever)
        l_mbeccfir_action0.clearBit<8, 8>();
        l_mbeccfir_action1.setBit<8, 8>();
        l_mbeccfir_mask_or.setBit<8, 8>();

        // 16   Memory NCE                  recoverable         mask (until mainline traffic)
        l_mbeccfir_action0.clearBit<16>();
        l_mbeccfir_action1.setBit<16>();
        l_mbeccfir_mask_or.setBit<16>();

        // 17   Memory RCE                  recoverable         mask (until mainline traffic)
        l_mbeccfir_action0.clearBit<17>();
        l_mbeccfir_action1.setBit<17>();

        l_mbeccfir_mask_or.setBit<17>();

        // 18   Memory SUE                  recoverable         mask (forever)
        l_mbeccfir_action0.clearBit<18>();
        l_mbeccfir_action1.setBit<18>();
        l_mbeccfir_mask_or.setBit<18>();

        // 19   Memory UE                   recoverable         mask (until mainline traffic)
        //      hw414700                    channel checkstop   mask (until mainline traffic)

        if (l_hw414700)
        {
            l_mbeccfir_action0.clearBit<19>();
            l_mbeccfir_action1.clearBit<19>();
            l_mbeccfir_mask_or.setBit<19>();
        }
        else
        {
            l_mbeccfir_action0.clearBit<19>();
            l_mbeccfir_action1.setBit<19>();
            l_mbeccfir_mask_or.setBit<19>();
        }

        // 20:27    Maint MPE Rank 0:7      recoverable         mask (forever)
        // NOTE: FW wants to mask these and rely instead on detecting the
        // cmd complete attention, then checking these manually to see if
        // they cause the cmd to stop
        l_mbeccfir_action0.clearBit<20, 8>();
        l_mbeccfir_action1.setBit<20, 8>();
        l_mbeccfir_mask_or.setBit<20, 8>();

        // 28:35    Reserved                recoverable         mask (forever)
        l_mbeccfir_action0.clearBit<28, 8>();
        l_mbeccfir_action1.setBit<28, 8>();
        l_mbeccfir_mask_or.setBit<28, 8>();

        // 36   Maintenance NCE             recoverable         mask (forever)
        // NOTE: PRD planning to use maint CE thresholds instead.
        l_mbeccfir_action0.clearBit<36>();
        l_mbeccfir_action1.setBit<36>();
        l_mbeccfir_mask_or.setBit<36>();

        // 37   Maintenance SCE             recoverable         mask (forever)
        // NOTE: Don't care if symbol still bad after it's symbol marked.
        l_mbeccfir_action0.clearBit<37>();
        l_mbeccfir_action1.setBit<37>();
        l_mbeccfir_mask_or.setBit<37>();

        // 38   Maintenance MCE             recoverable         mask (forever)
        // NOTE: PRD plans to check manually as part of verify chip mark procedure.
        l_mbeccfir_action0.clearBit<38>();
        l_mbeccfir_action1.setBit<38>();
        l_mbeccfir_mask_or.setBit<38>();

        // 39   Maintenance RCE             recoverable         mask (forever)
        // NOTE: PRD planning to use maint RCE thresholds instead.
        l_mbeccfir_action0.clearBit<39>();
        l_mbeccfir_action1.setBit<39>();
        l_mbeccfir_mask_or.setBit<39>();

        // 40   Maintenance SUE             recoverable         mask (forever)
        l_mbeccfir_action0.clearBit<40>();
        l_mbeccfir_action1.setBit<40>();
        l_mbeccfir_mask_or.setBit<40>();

        // 41   Maintenance UE              recoverable         mask (forever)
        // NOTE: FW wants to mask these and rely instead on detecting the
        // cmd complete attention, then checking these manually to see if
        // they cause the cmd to stop
        l_mbeccfir_action0.clearBit<41>();
        l_mbeccfir_action1.setBit<41>();
        l_mbeccfir_mask_or.setBit<41>();

        // 42   MPE during maintenance mark mode  recoverable   mask (forever)
        l_mbeccfir_action0.clearBit<42>();
        l_mbeccfir_action1.setBit<42>();
        l_mbeccfir_mask_or.setBit<42>();

        // 43   Prefetch Memory UE          recoverable         mask (until mainline traffic)
        l_mbeccfir_action0.clearBit<43>();
        l_mbeccfir_action1.setBit<43>();
        l_mbeccfir_mask_or.setBit<43>();

        // 44   Memory RCD parity error     recoverable         mask (forever)
        //      hw414700                    channel checkstop   mask (until mainline traffic)
        if (l_hw414700)
        {
            l_mbeccfir_action0.clearBit<44>();
            l_mbeccfir_action1.clearBit<44>();
            l_mbeccfir_mask_or.setBit<44>();
        }
        else
        {
            l_mbeccfir_action0.clearBit<44>();
            l_mbeccfir_action1.setBit<44>();
            l_mbeccfir_mask_or.setBit<44>();
        }

        // 45   Maint RCD parity error.     recoverable         mask (forever)
        l_mbeccfir_action0.clearBit<45>();
        l_mbeccfir_action1.setBit<45>();
        l_mbeccfir_mask_or.setBit<45>();

        // 46   Recoverable reg parity      recoverable         unmask
        l_mbeccfir_action0.clearBit<46>();
        l_mbeccfir_action1.setBit<46>();
        l_mbeccfir_mask_and.clearBit<46>();


        // 47   Unrecoverable reg parity    channel checkstop   unmask
        l_mbeccfir_action0.clearBit<47>();
        l_mbeccfir_action1.clearBit<47>();
        l_mbeccfir_mask_and.clearBit<47>();

        // 48   Maskable reg parity error   recoverable         unmask
        l_mbeccfir_action0.clearBit<48>();
        l_mbeccfir_action1.setBit<48>();
        l_mbeccfir_mask_and.clearBit<48>();

        // 49   ecc datapath parity error   channel checkstop   unmask
        l_mbeccfir_action0.clearBit<49>();
        l_mbeccfir_action1.clearBit<49>();
        l_mbeccfir_mask_and.clearBit<49>();

        // 50   internal scom error         recovereble         unmask
        l_mbeccfir_action0.clearBit<50>();
        l_mbeccfir_action1.setBit<50>();
        l_mbeccfir_mask_and.clearBit<50>();

        // 51   internal scom error clone   recovereble         unmask
        l_mbeccfir_action0.clearBit<51>();
        l_mbeccfir_action1.setBit<51>();
        l_mbeccfir_mask_and.clearBit<51>();

        // 52:63    Reserved    not implemented, so won't touch these

        // Write action0
        FAPI_TRY(fapi2::putScom(i_target,
                                l_mbeccfir_action0_address[l_mbaPosition],
                                l_mbeccfir_action0));

        // Write action1
        FAPI_TRY(fapi2::putScom(i_target,
                                l_mbeccfir_action1_address[l_mbaPosition],
                                l_mbeccfir_action1));


        // Write mask OR
        FAPI_TRY(fapi2::putScom(i_target,
                                l_mbeccfir_mask_or_address[l_mbaPosition],
                                l_mbeccfir_mask_or));

        // Write mask AND
        FAPI_TRY(fapi2::putScom(i_target,
                                l_mbeccfir_mask_and_address[l_mbaPosition],
                                l_mbeccfir_mask_and));


        //************************************************
        // DEBUG: read them all back to verify
        FAPI_TRY(fapi2::getScom(i_target,
                                l_mbeccfir_action0_address[l_mbaPosition],
                                l_mbeccfir_action0));

        FAPI_TRY(fapi2::getScom(i_target,
                                l_mbeccfir_action1_address[l_mbaPosition],
                                l_mbeccfir_action1));

        FAPI_TRY(fapi2::getScom(i_target,
                                l_mbeccfir_mask_address[l_mbaPosition],
                                l_mbeccfir_mask));

        //************************************************

    } // End for loop through functional MBAs on this Centaur

    FAPI_INF("EXIT mss_unmask_maint_errors()");
fapi_try_exit:
    return fapi2::current_err;
}

///
/// @brief Sets action regs and unmasks fetch errors prior to the start of mainline traffic.
/// @param[in] i_target Centaur target
/// @return FAPI2_RC_SUCCESS iff okay
/// @note To be called at the end of mss_draminit_mc.C.
///
fapi2::ReturnCode mss_unmask_fetch_errors(const fapi2::Target<fapi2::TARGET_TYPE_MEMBUF_CHIP>& i_target)
{
    FAPI_INF("ENTER mss_unmask_fetch_errors()");

    uint8_t l_dimm_type = 0;
    uint8_t l_cfg_wrdone_dly = 0;
    uint8_t l_cfg_rdtag_dly = 0;
    uint8_t l_max_cfg_rcd_protection_time = 0;

    fapi2::buffer<uint64_t> l_mba_dsm0;
    fapi2::buffer<uint64_t> l_mba_farb0;

    uint8_t l_hw414700 = 0;

    fapi2::Target<fapi2::TARGET_TYPE_DMI> l_attached_dmi_target = i_target.getParent<fapi2::TARGET_TYPE_DMI>();
    fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP> l_attached_proc_target =
        l_attached_dmi_target.getParent<fapi2::TARGET_TYPE_PROC_CHIP>();

    //*************************
    //*************************
    // SCAC_LFIR
    //*************************
    //*************************

    fapi2::buffer<uint64_t> l_scac_lfir_mask;
    fapi2::buffer<uint64_t> l_scac_lfir_mask_or;
    fapi2::buffer<uint64_t> l_scac_lfir_mask_and;
    fapi2::buffer<uint64_t> l_scac_lfir_action0;
    fapi2::buffer<uint64_t> l_scac_lfir_action1;
    fapi2::buffer<uint64_t> l_mbs_fir_mask;
    fapi2::buffer<uint64_t> l_mbs_fir_mask_and;
    uint8_t l_dd2_fir_bit_defn_changes = 0;
    std::vector<fapi2::Target<fapi2::TARGET_TYPE_L4>> l_L4_vector;
    bool l_L4_functional = false;
    uint8_t l_mbaPosition = 0;             // 0 = mba01, 1 = mba23
    uint32_t l_mbeccfir_mask_address[] =
    {
        // port0/1                            port2/3
        CEN_ECC01_MBECCFIR_MASK, CEN_ECC23_MBECCFIR_MASK
    };

    uint32_t l_mbeccfir_mask_and_address[] =
    {
        // port0/1                            port2/3
        CEN_ECC01_MBECCFIR_MASK_WO_AND, CEN_ECC23_MBECCFIR_MASK_WO_AND
    };

    fapi2::buffer<uint64_t> l_mbeccfir_mask;
    fapi2::buffer<uint64_t> l_mbeccfir_mask_and;
    fapi2::buffer<uint64_t> l_mbacalfir_mask;
    fapi2::buffer<uint64_t> l_mbacalfir_mask_and;
    std::vector<fapi2::Target<fapi2::TARGET_TYPE_MBA>> l_mbaChiplets;

    // Read mask
    FAPI_TRY(fapi2::getScom(i_target, CEN_SCAC_FIRMASK, l_scac_lfir_mask));



    //(Action0, Action1, Mask)
    //
    // (0,0,0) = checkstop
    // (0,1,0) = recoverable error
    // (1,0,0) = report unused
    // (1,1,0) = machine check
    // (x,x,1) = error is masked

    l_scac_lfir_action0.flush<0>();
    l_scac_lfir_action1.flush<0>();
    l_scac_lfir_mask_or.flush<0>();
    l_scac_lfir_mask_and.flush<1>();

    // 0    I2CMInvAddr                 recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<0>();
    l_scac_lfir_action1.setBit<0>();
    l_scac_lfir_mask_or.setBit<0>();

    // 1    I2CMInvWrite                recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<1>();
    l_scac_lfir_action1.setBit<1>();
    l_scac_lfir_mask_or.setBit<1>();

    // 2    I2CMInvRead                 recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<2>();
    l_scac_lfir_action1.setBit<2>();
    l_scac_lfir_mask_or.setBit<2>();

    // 3    I2CMApar                    recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<3>();
    l_scac_lfir_action1.setBit<3>();
    l_scac_lfir_mask_or.setBit<3>();

    // 4    I2CMPar                     recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<4>();
    l_scac_lfir_action1.setBit<4>();
    l_scac_lfir_mask_or.setBit<4>();

    // 5    I2CMLBPar                   recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<5>();
    l_scac_lfir_action1.setBit<5>();
    l_scac_lfir_mask_or.setBit<5>();

    // 6:9  Expansion                   recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<6, 4>();
    l_scac_lfir_action1.setBit<6, 4>();
    l_scac_lfir_mask_or.setBit<6, 4>();

    // 10   I2CMInvCmd                  recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<10>();
    l_scac_lfir_action1.setBit<10>();
    l_scac_lfir_mask_or.setBit<10>();

    // 11   I2CMPErr                    recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<11>();
    l_scac_lfir_action1.setBit<11>();
    l_scac_lfir_mask_or.setBit<11>();

    // 12   I2CMOverrun                 recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<12>();
    l_scac_lfir_action1.setBit<12>();
    l_scac_lfir_mask_or.setBit<12>();

    // 13   I2CMAccess                  recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<13>();
    l_scac_lfir_action1.setBit<13>();
    l_scac_lfir_mask_or.setBit<13>();

    // 14   I2CMArb                     recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<14>();
    l_scac_lfir_action1.setBit<14>();
    l_scac_lfir_mask_or.setBit<14>();

    // 15   I2CMNack                    recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<15>();
    l_scac_lfir_action1.setBit<15>();
    l_scac_lfir_mask_or.setBit<15>();

    // 16   I2CMStop                    recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<16>();
    l_scac_lfir_action1.setBit<16>();
    l_scac_lfir_mask_or.setBit<16>();

    // 17   LocalPib1                   recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<17>();
    l_scac_lfir_action1.setBit<17>();
    l_scac_lfir_mask_or.setBit<17>();

    // 18   LocalPib2                   recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<18>();
    l_scac_lfir_action1.setBit<18>();
    l_scac_lfir_mask_or.setBit<18>();

    // 19   LocalPib3                   recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<19>();
    l_scac_lfir_action1.setBit<19>();
    l_scac_lfir_mask_or.setBit<19>();

    // 20   LocalPib4                   recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<20>();
    l_scac_lfir_action1.setBit<20>();
    l_scac_lfir_mask_or.setBit<20>();

    // 21   LocalPib5                   recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<21>();
    l_scac_lfir_action1.setBit<21>();
    l_scac_lfir_mask_or.setBit<21>();

    // 22   LocalPib6                   recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<22>();
    l_scac_lfir_action1.setBit<22>();
    l_scac_lfir_mask_or.setBit<22>();

    // 23   LocalPib7                   recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<23>();
    l_scac_lfir_action1.setBit<23>();
    l_scac_lfir_mask_or.setBit<23>();

    // 24   StallError                  recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<24>();
    l_scac_lfir_action1.setBit<24>();
    l_scac_lfir_mask_or.setBit<24>();

    // 25   RegParErr                   channel checkstop   unmask
    l_scac_lfir_action0.clearBit<25>();
    l_scac_lfir_action1.clearBit<25>();
    l_scac_lfir_mask_and.clearBit<25>();

    // 26   RegParErrX                  channel checkstop   unmask
    l_scac_lfir_action0.clearBit<26>();
    l_scac_lfir_action1.clearBit<26>();
    l_scac_lfir_mask_and.clearBit<26>();

    // 27:31    Reserved                recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<27, 5>();
    l_scac_lfir_action1.setBit<27, 5>();
    l_scac_lfir_mask_or.setBit<27, 5>();

    // 32   SMErr                       recoverable         unmask
    l_scac_lfir_action0.clearBit<32>();
    l_scac_lfir_action1.setBit<32>();
    l_scac_lfir_mask_and.clearBit<32>();

    // 33   RegAccErr                   recoverable         unmask
    l_scac_lfir_action0.clearBit<33>();
    l_scac_lfir_action1.setBit<33>();
    l_scac_lfir_mask_and.clearBit<33>();

    // 34   ResetErr                    recoverable         masked (forever)
    l_scac_lfir_action0.clearBit<34>();
    l_scac_lfir_action1.setBit<34>();
    l_scac_lfir_mask_or.setBit<34>();

    // 35   internal_scom_error         recoverable         unmask
    l_scac_lfir_action0.clearBit<35>();
    l_scac_lfir_action1.setBit<35>();
    l_scac_lfir_mask_and.clearBit<35>();

    // 36   internal_scom_error_clone   recoverable         unmask
    l_scac_lfir_action0.clearBit<36>();
    l_scac_lfir_action1.setBit<36>();
    l_scac_lfir_mask_and.clearBit<36>();

    // 37:63    Reserved
    // Can we write to these bits?

    // Write action0
    FAPI_TRY(fapi2::putScom(i_target, CEN_SCAC_FIRACTION0_RO, l_scac_lfir_action0));

    // Write action1
    FAPI_TRY(fapi2::putScom(i_target, CEN_SCAC_FIRACTION1_RO, l_scac_lfir_action1));

    // Write mask OR
    FAPI_TRY(fapi2::putScom(i_target, CEN_SCAC_FIRMASK_WO_OR, l_scac_lfir_mask_or));

    // Write mask AND
    FAPI_TRY(fapi2::putScom(i_target, CEN_SCAC_FIRMASK_WO_AND, l_scac_lfir_mask_and));

    //************************************************
    // DEBUG: read them all back to verify
    FAPI_TRY(fapi2::getScom(i_target, CEN_SCAC_FIRACTION0_RO, l_scac_lfir_action0));
    FAPI_TRY(fapi2::getScom(i_target, CEN_SCAC_FIRACTION1_RO, l_scac_lfir_action1));
    FAPI_TRY(fapi2::getScom(i_target, CEN_SCAC_FIRMASK, l_scac_lfir_mask));

    //************************************************

    //*************************
    //*************************
    // MBS_FIR_REG
    //*************************
    //*************************

    // NOTE: In the IPL sequence, mss_unmask_inband_errors has already been
    // called, which has already set the MBS_FIR_REG action regs to their
    // runtime values, so no need to touch the action regs here.

    // NOTE: In the IPL sequence, mss_unmask_inband_errors,
    // has already been called, which has already unmasked the approproiate
    // MBS_FIR_REG errors following mss_unmask_inband_errors. So all we will do
    // here is unmask errors requiring mainline traffic which would be
    // considered valid after the mss_thermal_init procedure.

    // Get attribute for HW414700 workaround
    FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CHIP_EC_FEATURE_HW414700, l_attached_proc_target, l_hw414700),
             "Error getting ATTR_CHIP_EC_FEATURE_HW414700");

    FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CEN_CENTAUR_EC_FEATURE_DD2_FIR_BIT_DEFN_CHANGES, i_target,
                           l_dd2_fir_bit_defn_changes),
             "Error getting ATTR_CEN_CENTAUR_EC_FEATURE_DD2_FIR_BIT_DEFN_CHANGES");

    // Check if L4 is functional
    l_L4_vector = i_target.getChildren<fapi2::TARGET_TYPE_L4>();

    if (l_L4_vector.size() > 0)
    {
        l_L4_functional = true;
    }

    // Read mask
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBS_FIR_MASK_REG, l_mbs_fir_mask));


    l_mbs_fir_mask_and.flush<1>();

    // 2    invalid_address_error   channel checkstop   unmask
    l_mbs_fir_mask_and.clearBit<2>();

    // 3    external_timeout        MASKED         - Don't touch! per needing this masked off for Obus recovery

    // 4    internal_timeout        recoverable         unmask
    l_mbs_fir_mask_and.clearBit<4>();


    if (l_L4_functional)
    {
        // 9    cache_srw_ce            recoverable         unmask
        l_mbs_fir_mask_and.clearBit<9>();

        // 10    cache_srw_ue           recoverable         unmask
        l_mbs_fir_mask_and.clearBit<10>();

        // 12    cache_co_ce            recoverable         unmask
        l_mbs_fir_mask_and.clearBit<12>();

        // 13    cache_co_ue            recoverable         unmask
        l_mbs_fir_mask_and.clearBit<13>();

        // 15    dir_ce
        if (l_dd2_fir_bit_defn_changes)
        {
            // NOTE: SW248520: Known DD1 problem - higher temp causes
            // L4 Dir CEs. Want to ignore. Unmask for DD2 only

            //                          recoverable         unmask
            l_mbs_fir_mask_and.clearBit<15>();
        }

        // 16    dir_ue                 channel checkstop   unmask
        l_mbs_fir_mask_and.clearBit<16>();

        // 18    dir_all_members_deleted channel checkstop  unmask
        l_mbs_fir_mask_and.clearBit<18>();

        // 19    lru_error               recoverable        unmask
        l_mbs_fir_mask_and.clearBit<19>();

        // 20    eDRAM error             channel checkstop  unmask
        l_mbs_fir_mask_and.clearBit<20>();
    }

    // 26    srb_buffer_ce           recoverable        unmask
    l_mbs_fir_mask_and.clearBit<26>();

    // 27    srb_buffer_ue           recoverable        unmask
    l_mbs_fir_mask_and.clearBit<27>();

    if (l_dd2_fir_bit_defn_changes && l_L4_functional)
    {
        // 30    proximal_ce_ue      channel checkstop  unmask
        l_mbs_fir_mask_and.clearBit<30>();
    }


    // Write mask AND
    FAPI_TRY(fapi2::putScom(i_target, CEN_MBS_FIR_MASK_REG_WO_AND, l_mbs_fir_mask_and));


    //************************************************
    // DEBUG: read them all back to verify
    FAPI_TRY(fapi2::getScom(i_target, CEN_MBS_FIR_MASK_REG, l_mbs_fir_mask));

    //************************************************


    // Get associated functional MBAs on this centaur
    l_mbaChiplets = i_target.getChildren<fapi2::TARGET_TYPE_MBA>();

    // Loop through functional MBAs on this Centaur
    for (uint32_t i = 0; i < l_mbaChiplets.size(); ++i)
    {

        // Get MBA position: 0 = mba01, 1 = mba23
        FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CHIP_UNIT_POS, l_mbaChiplets[i], l_mbaPosition),
                 "Error getting MBA position");

        // Get DIMM type
        FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CEN_EFF_DIMM_TYPE, l_mbaChiplets[i], l_dimm_type),
                 "Error getting ATTR_CEN_EFF_DIMM_TYPE");

        // If RDIMM or LRDIMM, load max_cfg_rcd_protection_time and enable RCD recovery
        if ((l_dimm_type == fapi2::ENUM_ATTR_CEN_EFF_DIMM_TYPE_RDIMM)
            || (l_dimm_type == fapi2::ENUM_ATTR_CEN_EFF_DIMM_TYPE_LRDIMM))
        {

            FAPI_TRY(fapi2::getScom(l_mbaChiplets[i], CEN_MBA_MBA_DSM0Q, l_mba_dsm0));

            // Get 24:29 cfg_wrdone_dly
            l_mba_dsm0.extract < 24, 6, 8 - 6 > (l_cfg_wrdone_dly);

            // Get 36:41 cfg_rdtag_dly
            l_mba_dsm0.extract < 36, 6, 8 - 6 > (l_cfg_rdtag_dly);

            // Pick lower of the two: cfg_wrdone_dly and cfg_rdtag_dly, and use that for l_max_cfg_rcd_protection_time
            if (l_cfg_wrdone_dly <= l_cfg_rdtag_dly)
            {
                l_max_cfg_rcd_protection_time = l_cfg_wrdone_dly;
            }
            else
            {
                l_max_cfg_rcd_protection_time = l_cfg_rdtag_dly;
            }

            // Read FARB0
            FAPI_TRY(fapi2::getScom(l_mbaChiplets[i], CEN_MBA_MBA_FARB0Q, l_mba_farb0));

            // Load l_max_cfg_rcd_protection_time
            FAPI_TRY(l_mba_farb0.insert( l_max_cfg_rcd_protection_time, 48, 6, 8 - 6 ));

            // Clear bit 54, cfg_disable_rcd_recovery, to enable RCD recovery
            l_mba_farb0.clearBit<54>();

            // Write FARB0
            FAPI_TRY(fapi2::putScom(l_mbaChiplets[i], CEN_MBA_MBA_FARB0Q, l_mba_farb0));
        }


        //*************************
        //*************************
        // MBASPA
        //*************************
        //*************************
        // NOTE: FW wants to mask these and rely instead on detecting the
        // cmd complete attention, then checking these manually to see if
        // they cause the cmd to stop

        //*************************
        //*************************
        // MBECCFIR
        //*************************
        //*************************

        // Read mask
        FAPI_TRY(fapi2::getScom(i_target,
                                l_mbeccfir_mask_address[l_mbaPosition],
                                l_mbeccfir_mask));

        // NOTE: In the IPL sequence, mss_unmask_maint_errors has already been
        // called, which has already set the MBECCFIR action regs to their runtime
        // values, so no need to touch the action regs here.

        // NOTE: In the IPL sequence, mss_unmask_maint_errors,
        // has already been called, which has already unmasked the approproiate
        // MBECCFIR errors following mss_unmask_maint_errors. So all we will do
        // here is unmask errors requiring mainline traffic which would be
        // considered valid after the mss_thermal_init procedure.

        l_mbeccfir_mask_and.flush<1>();

        // 0:7  Memory MPE Rank 0:7         recoverable         unmask
        l_mbeccfir_mask_and.clearBit<0, 8>();

        // 16   Memory NCE                  recoverable         unmask
        l_mbeccfir_mask_and.clearBit<16>();

        // 17   Memory RCE                  recoverable         unmask
        l_mbeccfir_mask_and.clearBit<17>();

        // 19   Memory UE                   recoverable         unmask
        l_mbeccfir_mask_and.clearBit<19>();

#if 0 // Should this be removed - AAM ?
        // NOTE: FW wants to mask these and rely instead on detecting the
        // cmd complete attention, then checking these manually to see if
        // they cause the cmd to stop

        // 20:27    Maint MPE Rank 0:7      recoverable         unmask
        l_mbeccfir_mask_and.clearBit<20, 8>();

        // 41   Maintenance UE              recoverable         unmask
        l_mbeccfir_mask_and.clearBit<41>();
#endif

        // 43   Prefetch Memory UE          recoverable         unmask
        l_mbeccfir_mask_and.clearBit<43>();

        // 44   Memory RCD Parity Error     channel checkstop   unmask (hw414700)
        if (l_hw414700)
        {
            l_mbeccfir_mask_and.clearBit<44>();
        }

        // Write mask AND
        FAPI_TRY(fapi2::putScom(i_target,
                                l_mbeccfir_mask_and_address[l_mbaPosition],
                                l_mbeccfir_mask_and));

        //************************************************
        // DEBUG: read them all back to verify
        FAPI_TRY(fapi2::getScom(i_target,
                                l_mbeccfir_mask_address[l_mbaPosition],
                                l_mbeccfir_mask));

        //************************************************
    }

    //*************************
    //*************************
    // MBACALFIR
    //*************************
    //*************************


    // NOTE: In the IPL sequence, mss_unmask_draminit_errors has already been
    // called, which has already set the MBACALFIR action regs to their runtime
    // values, so no need to touch the action regs here.

    // NOTE: In the IPL sequence, various bits have already been unmasked
    // after the approproiate procedures. So all we will do here is unmask
    // errors requiring mainline traffic which would be considered valid after
    // the mss_thermal_init procedure.

    // Loop through functional MBAs on this Centaur
    for (uint32_t i = 0; i < l_mbaChiplets.size(); ++i)
    {

        // Read mask
        FAPI_TRY(fapi2::getScom(l_mbaChiplets[i],
                                CEN_MBA_MBACALFIR_MASK,
                                l_mbacalfir_mask));


        l_mbacalfir_mask_and.flush<1>();

        // 9    mba_wrd ue                  recoverable         unmask
        l_mbacalfir_mask_and.clearBit<9>();

        // 10   mba_wrd ce                  recoverable         unmask
        l_mbacalfir_mask_and.clearBit<10>();

        // 14   wrq_data_ce                 recoverable         unmask
        l_mbacalfir_mask_and.clearBit<14>();

        // 15   wrq_data_ue                 recoverable         unmask
        l_mbacalfir_mask_and.clearBit<15>();

        // Write mask AND
        FAPI_TRY(fapi2::putScom(l_mbaChiplets[i],
                                CEN_MBA_MBACALFIR_MASK_WO_AND,
                                l_mbacalfir_mask_and));

        //************************************************
        // DEBUG: read them all back to verify
        FAPI_TRY(fapi2::getScom(l_mbaChiplets[i],
                                CEN_MBA_MBACALFIR_MASK,
                                l_mbacalfir_mask));

        //************************************************
    }

fapi_try_exit:
    FAPI_INF("EXIT mss_unmask_fetch_errors()");
    return fapi2::current_err;
}
OpenPOWER on IntegriCloud