diff options
| author | Caleb Palmer <cnpalmer@us.ibm.com> | 2017-10-03 16:56:01 -0500 |
|---|---|---|
| committer | Zane C. Shelley <zshelle@us.ibm.com> | 2017-10-09 12:06:52 -0400 |
| commit | d2822317832d3caee9de11ba900d01777b25f2ce (patch) | |
| tree | bcec7a6fb9413c33cf5b9dc3d0af9c91c11042cc /src | |
| parent | 37d98e479d900300acccf9dec1453dce7a2cdc5c (diff) | |
| download | talos-hostboot-d2822317832d3caee9de11ba900d01777b25f2ce.tar.gz talos-hostboot-d2822317832d3caee9de11ba900d01777b25f2ce.zip | |
PRD: reenable get/setBadDqBitmap hwp calls
Change-Id: I7a22679da0744201f28b692ff663e9876cb11702
RTC: 164707
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/47107
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/48075
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/usr/diag/prdf/common/plat/prdfPlatServices_common.C | 27 |
1 files changed, 16 insertions, 11 deletions
diff --git a/src/usr/diag/prdf/common/plat/prdfPlatServices_common.C b/src/usr/diag/prdf/common/plat/prdfPlatServices_common.C index 8a7cdf649..1fa0e43ff 100644 --- a/src/usr/diag/prdf/common/plat/prdfPlatServices_common.C +++ b/src/usr/diag/prdf/common/plat/prdfPlatServices_common.C @@ -43,9 +43,8 @@ //#include <prdfCenDqBitmap.H> TODO RTC 157888 //#include <prdfCenMarkstore.H> TODO RTC 157888 -//#include <dimmBadDqBitmapFuncs.H> // for dimm[S|G]etBadDqBitmap() TODO RTC 164707 - #ifdef __HOSTBOOT_MODULE +#include <dimmBadDqBitmapFuncs.H> #include <p9_io_xbus_read_erepair.H> #include <p9_io_xbus_pdwn_lanes.H> #include <p9_io_xbus_clear_firs.H> @@ -341,6 +340,8 @@ int32_t getBadDqBitmap( TargetHandle_t i_trgt, const MemRank & i_rank, int32_t o_rc = SUCCESS; + #ifdef __HOSTBOOT_MODULE + // Don't proceed unless the DIMM exists PRDF_ASSERT( nullptr != getConnectedChild(i_trgt, TYPE_DIMM, i_rank.getDimmSlct()) ); @@ -356,10 +357,9 @@ int32_t getBadDqBitmap( TargetHandle_t i_trgt, const MemRank & i_rank, fapi2::Target<l_trgtType> l_fapiTrgt( i_trgt ); - // TODO RTC 164707 - //FAPI_INVOKE_HWP( errl, dimmGetBadDqBitmap, l_fapiTrgt, - // i_rank.getDimmSlct(), i_rank.getRankSlct(), - // data[ps], ps ); + FAPI_INVOKE_HWP( errl, dimmGetBadDqBitmap, l_fapiTrgt, + i_rank.getDimmSlct(), i_rank.getRankSlct(), + data[ps], ps ); if ( nullptr != errl ) { @@ -376,6 +376,8 @@ int32_t getBadDqBitmap( TargetHandle_t i_trgt, const MemRank & i_rank, o_bitmap = MemDqBitmap<T>( i_trgt, i_rank, data ); } + #endif // __HOSTBOOT_MODULE + return o_rc; #undef PRDF_FUNC @@ -401,13 +403,15 @@ int32_t setBadDqBitmap( TargetHandle_t i_trgt, const MemRank & i_rank, int32_t o_rc = SUCCESS; + #ifdef __HOSTBOOT_MODULE + // Don't proceed unless the DIMM exists PRDF_ASSERT( nullptr != getConnectedChild(i_trgt, TYPE_DIMM, i_rank.getDimmSlct()) ); if ( !areDramRepairsDisabled() ) { - //const uint8_t (&data)[T][DQ_BITMAP::BITMAP_SIZE] = i_bitmap.getData(); + const uint8_t (&data)[T][DQ_BITMAP::BITMAP_SIZE] = i_bitmap.getData(); for ( int32_t ps = 0; ps < T; ps++ ) { @@ -419,10 +423,9 @@ int32_t setBadDqBitmap( TargetHandle_t i_trgt, const MemRank & i_rank, fapi2::Target<l_trgtType> l_fapiTrgt( i_trgt ); - // TODO RTC 164707 - //FAPI_INVOKE_HWP( errl, dimmSetBadDqBitmap, l_fapiTrgt, - // i_rank.getDimmSlct(), i_rank.getRankSlct(), - // data[ps], ps ); + FAPI_INVOKE_HWP( errl, dimmSetBadDqBitmap, l_fapiTrgt, + i_rank.getDimmSlct(), i_rank.getRankSlct(), + data[ps], ps ); if ( nullptr != errl ) { @@ -435,6 +438,8 @@ int32_t setBadDqBitmap( TargetHandle_t i_trgt, const MemRank & i_rank, } } + #endif // __HOSTBOOT_MODULE + return o_rc; #undef PRDF_FUNC |
