diff options
| author | Andres Lugo-Reyes <aalugore@us.ibm.com> | 2016-07-29 10:16:03 -0500 |
|---|---|---|
| committer | Christian R. Geddes <crgeddes@us.ibm.com> | 2016-08-30 11:45:18 -0400 |
| commit | b8b50c0fd1e1d61e78e29f03fb4fad1a22c36155 (patch) | |
| tree | 9e9d294a4f08fc32d4625f89d8799d77112c5360 /src | |
| parent | 40b68e6b9dd2234498c0dfe636f0bb54726ce644 (diff) | |
| download | talos-hostboot-b8b50c0fd1e1d61e78e29f03fb4fad1a22c36155.tar.gz talos-hostboot-b8b50c0fd1e1d61e78e29f03fb4fad1a22c36155.zip | |
Modify #V accessor to fail if multiple buckets report same nest
Change-Id: I597bee1667b2f2259ad5decdf57ef846d2a9412b
RTC:157341
Depends-on:Ideeff644470d1c13ec3a55b9d0439a4dc0150f0d
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/27637
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Dev-Ready: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/27638
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Reviewed-by: Andres A. Lugo-Reyes <aalugore@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/pm/p9_pm_get_poundv_bucket_attr.C | 49 |
1 files changed, 20 insertions, 29 deletions
diff --git a/src/import/chips/p9/procedures/hwp/pm/p9_pm_get_poundv_bucket_attr.C b/src/import/chips/p9/procedures/hwp/pm/p9_pm_get_poundv_bucket_attr.C index 380f59ace..57bb161bd 100644 --- a/src/import/chips/p9/procedures/hwp/pm/p9_pm_get_poundv_bucket_attr.C +++ b/src/import/chips/p9/procedures/hwp/pm/p9_pm_get_poundv_bucket_attr.C @@ -188,46 +188,37 @@ fapi2::ReturnCode p9_pm_get_poundv_bucket_attr( { l_numMatches++; - /* - * TODO RTC: 157341 - * Modify function to fail if multiple buckets have same nest - */ if(l_numMatches > 1) { FAPI_ERR("p9_pm_get_poundv_bucket_attr::" - " Multiple buckets (%d) reporting the same nest frequency", - l_numMatches); - } + " Multiple buckets (%d) reporting the same nest frequency" + " Bucket Nest = %d Bucket ID = %d", + l_numMatches, + l_buckets[i].pbFreq, + (i + 1)); - /* + } else { l_currentBucket = &l_buckets[i]; } - */ - l_currentBucket = &l_buckets[i]; } } - /* - * TODO RTC: 157341 - * Modify function to fail if multiple buckets have same nest - if(l_numMatches == 1) - { - l_bucketId = l_currentBucket->bucketId; - } - else - { - - FAPI_ERR("p9_pm_get_poundv_bucket_attr::Invalid number of matching nest freqs found. Matches found = %d", - l_numMatches ); - FAPI_ASSERT(0, - fapi2::INVALID_MATCHING_FREQ_NUMBER(). - set_MATCHES_FOUND(l_numMatches), - "Matches found is NOT 1" ); - } - */ - l_bucketId = l_currentBucket->bucketId; + if(l_numMatches == 1) + { + l_bucketId = l_currentBucket->bucketId; + } + else + { + + FAPI_ERR("p9_pm_get_poundv_bucket_attr::Invalid number of matching nest freqs found. Matches found = %d", + l_numMatches ); + FAPI_ASSERT(false, + fapi2::INVALID_MATCHING_FREQ_NUMBER(). + set_MATCHES_FOUND(l_numMatches), + "Matches found is NOT 1" ); + } } else { |
