diff options
author | Thi Tran <thi@us.ibm.com> | 2016-03-09 10:36:29 -0600 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2016-05-18 18:07:06 -0400 |
commit | 9fef41ba6c6dd189290d2eeb7c4572f16046a909 (patch) | |
tree | b785f6d14c8e17b995f94806f810ca3e6cbf475c /src | |
parent | 9d7257c5f3932d0a561b6884e7c157d714b7964d (diff) | |
download | talos-hostboot-9fef41ba6c6dd189290d2eeb7c4572f16046a909.tar.gz talos-hostboot-9fef41ba6c6dd189290d2eeb7c4572f16046a909.zip |
Remove chiplet null check in p9_build_smp_fbc_nohp.C
Change-Id: I76e2c67b9bf5a04562e7adbcc7f7ba408baec888
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/21856
Tested-by: Jenkins Server
Reviewed-by: Joseph J. McGill <jmcgill@us.ibm.com>
Reviewed-by: Matt K. Light <mklight@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/24709
Tested-by: FSP CI Jenkins
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src')
-rw-r--r-- | src/import/chips/p9/procedures/hwp/nest/p9_build_smp_fbc_ab.C | 47 |
1 files changed, 25 insertions, 22 deletions
diff --git a/src/import/chips/p9/procedures/hwp/nest/p9_build_smp_fbc_ab.C b/src/import/chips/p9/procedures/hwp/nest/p9_build_smp_fbc_ab.C index b51612afb..0214133a0 100644 --- a/src/import/chips/p9/procedures/hwp/nest/p9_build_smp_fbc_ab.C +++ b/src/import/chips/p9/procedures/hwp/nest/p9_build_smp_fbc_ab.C @@ -78,28 +78,31 @@ fapi2::ReturnCode p9_build_smp_query_link_state( } // TODO: RTC 147511 - Need to set enabled/disabled based on ATTR_PG attributes. - if (i_dest_target.get() == NULL) - { - FAPI_DBG("No target link"); - o_link_is_enabled = false; - o_dest_target_node_id = FBC_NODE_ID_0; - o_dest_target_chip_id = FBC_CHIP_ID_0; - } - else - { - o_link_is_enabled = true; - - // Extract chip/node ID from destination chip - FAPI_TRY(p9_fab_smp_get_node_id_attr(i_dest_target, - o_dest_target_node_id), - "p9_fab_smp_get_node_id_attr() returns an error, l_rc 0x%.8X", - (uint64_t)fapi2::current_err); - - FAPI_TRY(p9_fab_smp_get_chip_id_attr(i_dest_target, - o_dest_target_chip_id), - "p9_fab_smp_get_chip_id_attr() returns an error, l_rc 0x%.8X", - (uint64_t)fapi2::current_err); - } +//TODO: Can not perform NULL check on the target. +// Temporarily comment out so Cronus can compile successfully. +// Need permanent fix. +// if (i_dest_target.get() == NULL) +// { +// FAPI_DBG("No target link"); +// o_link_is_enabled = false; +// o_dest_target_node_id = FBC_NODE_ID_0; +// o_dest_target_chip_id = FBC_CHIP_ID_0; +// } +// else +// { + o_link_is_enabled = true; + + // Extract chip/node ID from destination chip + FAPI_TRY(p9_fab_smp_get_node_id_attr(i_dest_target, + o_dest_target_node_id), + "p9_fab_smp_get_node_id_attr() returns an error, l_rc 0x%.8X", + (uint64_t)fapi2::current_err); + + FAPI_TRY(p9_fab_smp_get_chip_id_attr(i_dest_target, + o_dest_target_chip_id), + "p9_fab_smp_get_chip_id_attr() returns an error, l_rc 0x%.8X", + (uint64_t)fapi2::current_err); +// } fapi_try_exit: FAPI_DBG("End"); |