Decode HWP errors in error log FFDC data properly

HWP errors are detailed in error XML files. The fapiParseAttributeInfo.pl
script parses these XML files and creates an enumeration of rc-values. When a
HWP generates an error, the corresponding rc-value is set in the
fapi::ReturnCode. When Hostboot sees a ReturnCode containing a HWP error, it
creates an error log and adds the rc-value as user-detail-data. The
fapiPlatCreateHwpRcDecoder.pl script generates a user-detail-data parser that
outputs the error description from the error XML files. All well and good.
In the old code, the rc_value enumeration used to be 0, 1, 2, etc. But this
was changed to be a hash-code (for Cronus - so that a particular rc-value
sticks with a particular error across builds), but I forgot to change the
fapiPlatCreateHwpRcDecoder.pl script to use the same hash code algorithm as
fapiParseAttributeInfo.pl, it still thinks that the enumerators are 0, 1, 2.
Therefore, when user-detail-data parsing eventually works, HWP errors will
not be decoded. This fixes the problem

Change-Id: I700973a8dfa8dad43f3b1f66ace7f3e9a010ec68
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/1090
Tested-by: Jenkins Server
Reviewed-by: Van H. Lee <vanlee@us.ibm.com>
Reviewed-by: CAMVAN T. NGUYEN <ctnguyen@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>

1 files changed, 8 insertions, 3 deletions

diff --git a/src/usr/hwpf/plat/fapiPlatCreateHwpRcDecoder.pl b/src/usr/hwpf/plat/fapiPlatCreateHwpRcDecoder.pl
index 80a63c8ca..c5b3b7e51 100755
--- a/src/usr/hwpf/plat/fapiPlatCreateHwpRcDecoder.pl
+++ b/src/usr/hwpf/plat/fapiPlatCreateHwpRcDecoder.pl
@@ -46,6 +46,7 @@ if ($numArgs < 2)
 #------------------------------------------------------------------------------
 # Specify perl modules to use
 #------------------------------------------------------------------------------
+use Digest::MD5 qw(md5_hex);
 use XML::Simple;
 my $xml = new XML::Simple (KeyAttr=>[]);
 
@@ -78,7 +79,6 @@ print TGFILE "    {\n";
 #------------------------------------------------------------------------------
 # For each XML file
 #------------------------------------------------------------------------------
-my $errId = 1;
 foreach my $argnum (1 .. $#ARGV)
 {
     #--------------------------------------------------------------------------
@@ -122,11 +122,16 @@ foreach my $argnum (1 .. $#ARGV)
 
         #----------------------------------------------------------------------
         # Print the RC decode
+        # Note that this uses the same code to calculate the attribute
+        # enumerator as fapiParseErrorInfo.pl. This code must be kept in sync
+        # with fapiParseErrorInfo.pl.
         #----------------------------------------------------------------------
-        print TGFILE "    case $errId:\n";
+        my $attrHash128Bit = md5_hex($err->{rc});
+        my $attrHash24Bit = substr($attrHash128Bit, 0, 6);
+
+        print TGFILE "    case 0x$attrHash24Bit:\n";
         print TGFILE "        return \"$desc\";\n";
         print TGFILE "        break;\n";
-        $errId++;
     }
 }