diff options
author | Dan Crowell <dcrowell@us.ibm.com> | 2017-08-01 12:25:08 -0500 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-08-04 00:02:47 -0400 |
commit | 7302a891f6709ebdd7f5a65d29417f6b372e6e69 (patch) | |
tree | a6a73e6587471ff4fdc9a7cb39e37b14e5bc3ff0 /src | |
parent | 0a92b575a0a9c11f495ac27987923d984c5fc70c (diff) | |
download | talos-hostboot-7302a891f6709ebdd7f5a65d29417f6b372e6e69.tar.gz talos-hostboot-7302a891f6709ebdd7f5a65d29417f6b372e6e69.zip |
Disable SBE start recovery code
The changes that just went in to enable recovery from non-fatal
SBE issues have had an unintended consequence of making live
debug of SBE failures much more difficult. This change will
temporarily disable the code path until we put in a real
solution that works for live and automated scenarios.
Change-Id: I17b06ec8aaa8f593af2671bccb55554380a28ea8
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/44026
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Reviewed-by: Elizabeth K. Liner <eliner@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src')
-rw-r--r-- | src/usr/isteps/istep08/call_proc_check_slave_sbe_seeprom_complete.C | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/src/usr/isteps/istep08/call_proc_check_slave_sbe_seeprom_complete.C b/src/usr/isteps/istep08/call_proc_check_slave_sbe_seeprom_complete.C index 6174ddc79..2221e41a2 100644 --- a/src/usr/isteps/istep08/call_proc_check_slave_sbe_seeprom_complete.C +++ b/src/usr/isteps/istep08/call_proc_check_slave_sbe_seeprom_complete.C @@ -162,6 +162,18 @@ void* call_proc_check_slave_sbe_seeprom_complete( void *io_pArgs ) // we can still at least boot with master proc errlCommit(l_errl,ISTEP_COMP_ID); + //@fixme - RTC:177921 + // Do not call p9_extract_sbe_rc because it corrupts + // live debug of fails. Need to make some other + // changes before turning this back on. +#if 1 // get rid of this + // Create IStep error log and cross reference to error + l_stepError.addErrorDetails( l_errl ); + + // Commit error log + errlCommit( l_errl, HWPF_COMP_ID ); +#else + // Setup for the HWP P9_EXTRACT_SBE_RC::RETURN_ACTION l_rcAction = P9_EXTRACT_SBE_RC::REIPL_UPD_SEEPROM; @@ -218,6 +230,7 @@ void* call_proc_check_slave_sbe_seeprom_complete( void *io_pArgs ) proc_extract_sbe_handler( l_cpu_target, l_prevError, l_rcAction); } +#endif //@fixme - RTC:177921 } else if (l_errl) |