diff options
| author | Dan Crowell <dcrowell@us.ibm.com> | 2016-11-17 15:57:19 -0600 |
|---|---|---|
| committer | Christian R. Geddes <crgeddes@us.ibm.com> | 2017-06-22 00:34:27 -0400 |
| commit | 68ff2b9ea18728f467d8945023e62b7b4f645087 (patch) | |
| tree | 0f3413b9d6d379972f191f15166c76f07e07ac40 /src | |
| parent | 3db49d83c38aec08d67bc56d8b5216e14bd23693 (diff) | |
| download | talos-hostboot-68ff2b9ea18728f467d8945023e62b7b4f645087.tar.gz talos-hostboot-68ff2b9ea18728f467d8945023e62b7b4f645087.zip | |
Improve detection and description for MEMVPD_POS issues
Updated attribute description based on changes to requirements
Added explicit check for invalid data to improve debug
Change-Id: I06518a3c7311c1a3ccb4241c9c155e78a067b625
Original-Change-Id: Ie22287166855be1e0d99a52cc4a3ad89d354acfa
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/32793
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Brian R. Silver <bsilver@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/42150
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/import/chips/p9/procedures/xml/attribute_info/freq_attributes.xml | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/import/chips/p9/procedures/xml/attribute_info/freq_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/freq_attributes.xml index 304548f71..4d6ad1229 100644 --- a/src/import/chips/p9/procedures/xml/attribute_info/freq_attributes.xml +++ b/src/import/chips/p9/procedures/xml/attribute_info/freq_attributes.xml @@ -79,10 +79,12 @@ <targetType>TARGET_TYPE_MCS</targetType> <description> The position of the MCS target's VPD selector data, relative to the EEPROM - that contains its data. For systems with a single EEPROM for all chips, - this should be equivalent to ATTR_FAPI_POS (the logical MCA position). + that contains its data. The VPD defition supports up to 16 values per + EEPROM. For systems with an EEPROM per chip, this value should be equivalent to ATTR_CHIP_UNIT_POS. + For systems with a single EEPROM for all chips, the value should follow + the physical position in such a way to fit within the 16 available slots. </description> <valueType>uint8</valueType> <platInit/> |
