diff options
| author | Caleb Palmer <cnpalmer@us.ibm.com> | 2018-07-25 13:10:53 -0500 |
|---|---|---|
| committer | Zane C. Shelley <zshelle@us.ibm.com> | 2018-07-26 14:24:35 -0500 |
| commit | 3527992a75f5f385ea04a66d3757c88c8d2efa68 (patch) | |
| tree | 1ec7fa2e2d9fb90dcdd0bfb1b3ad46deebcec3e9 /src | |
| parent | 3203b0f520a21c1ffb75be5e39a6efbdfc2f2aa1 (diff) | |
| download | talos-hostboot-3527992a75f5f385ea04a66d3757c88c8d2efa68.tar.gz talos-hostboot-3527992a75f5f385ea04a66d3757c88c8d2efa68.zip | |
Row Repair don't translate invalid repairs
Change-Id: Iff219b44f15cd3d86a647b706496291a6916b49f
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/63302
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/usr/fapi2/attribute_service.C | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/usr/fapi2/attribute_service.C b/src/usr/fapi2/attribute_service.C index 7ae603acf..9908e3abd 100644 --- a/src/usr/fapi2/attribute_service.C +++ b/src/usr/fapi2/attribute_service.C @@ -1871,6 +1871,13 @@ ReturnCode __rowRepairTranslateDramPos( uint8_t l_dramPos = (l_dramPosAndSrank >> 3) & 0x1f; uint8_t l_srank = l_dramPosAndSrank & 0x07; + // The last bit of the row repair stores the validity bit + bool l_valid = io_translatedData[rank][mss::ROW_REPAIR_BYTE_COUNT-1] + & 0x01; + + // If the row repair isn't valid, no need to translate anything + if ( !l_valid ) continue; + uint8_t l_dq = 0; l_rc = __dramToDq( i_fapiDimm, l_dramPos, l_dq ); if ( l_rc ) |
