diff options
| author | Mike Baiocchi <mbaiocch@us.ibm.com> | 2018-07-17 15:19:43 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-07-18 17:10:59 -0400 |
| commit | 2d79288ff609c6ab74f0c99a362e2180d60a7727 (patch) | |
| tree | 45a463da1f8dce22897e483aa90fc3d993ce8005 /src | |
| parent | 27c01047205d6c64b89f1df0dc5952a202bee792 (diff) | |
| download | talos-hostboot-2d79288ff609c6ab74f0c99a362e2180d60a7727.tar.gz talos-hostboot-2d79288ff609c6ab74f0c99a362e2180d60a7727.zip | |
ABUS Node Communication is operational, so commit all errors
The ABUS Node Communications procedure is operational and its error
handling works. So this commit updates the code such that any errors
during this procedure are now committed so that they can be properly
handled.
Change-Id: I0c97b74bca83a3bc001426aa01beb0c81cd7a717
RTC:184518
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/62753
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/usr/isteps/istep18/establish_system_smp.C | 7 | ||||
| -rw-r--r-- | src/usr/secureboot/node_comm/node_comm_exchange.C | 2 |
2 files changed, 4 insertions, 5 deletions
diff --git a/src/usr/isteps/istep18/establish_system_smp.C b/src/usr/isteps/istep18/establish_system_smp.C index d9853686d..2a59046d1 100644 --- a/src/usr/isteps/istep18/establish_system_smp.C +++ b/src/usr/isteps/istep18/establish_system_smp.C @@ -668,14 +668,13 @@ void *host_sys_fab_iovalid_processing(void* io_ptr ) errlHndl_t err = SECUREBOOT::NODECOMM::nodeCommAbusExchange(); if (err) { - // @TODO RTC 184518 Determine how to handle error log, but - // delete error log for now + // Commit error here and the FSP will handle it TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,ERR_MRK "host_sys_fab_iovalid_processing: nodeCommAbusExchange() " "returned err: plid=0x%X. Deleting err and continuing", err->plid()); - delete err; - err = nullptr; + err->collectTrace("ISTEPS_TRACE"); + errlCommit(err, SECURE_COMP_ID); } // Lock the secure ABUS Link Mailboxes now diff --git a/src/usr/secureboot/node_comm/node_comm_exchange.C b/src/usr/secureboot/node_comm/node_comm_exchange.C index 882d4f9f3..78521b0e4 100644 --- a/src/usr/secureboot/node_comm/node_comm_exchange.C +++ b/src/usr/secureboot/node_comm/node_comm_exchange.C @@ -885,7 +885,7 @@ errlHndl_t nodeCommAbusExchange(void) } else { - TRACFCOMP(g_trac_nc, ERR_MRK"nodeCommAbusExchange: " + TRACFCOMP(g_trac_nc, INFO_MRK"nodeCommAbusExchange: " "getObusTrainedLinks: link0=%d, link1=%d", link0_trained, link1_trained); |
