diff options
author | Vaibhav Jain <vaibhav@linux.vnet.ibm.com> | 2017-11-06 17:42:15 +0530 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-11-15 23:10:26 -0500 |
commit | 24d0d344bb8d0a9ce88e138301f2073b65cc3ca6 (patch) | |
tree | 75fd708141501b7b90f3ff50848572e9938fbc7f /src | |
parent | dacd80a9811f5865e53b29e1e0c2d0dddd1e9719 (diff) | |
download | talos-hostboot-24d0d344bb8d0a9ce88e138301f2073b65cc3ca6.tar.gz talos-hostboot-24d0d344bb8d0a9ce88e138301f2073b65cc3ca6.zip |
Modify eSEL script to not ignore cases for command line options
By default Perl's Getopt::Long will ignore case for option names. This
causes conflict between for '-P' and '-p' options that are provide BMC
password and decode option respectively. Below is an example of failed
run with command having both '-P' and '-p' used:
$./eSEL.pl -t <ip-addr> -p get_and_decode_ami -U ADMIN -P ADMIN
***ERROR: Incorrect option provided.
Specify an option with -p <option>.
To fix this the Getopt::Long import is configured to not ignore the
case of option names by using the 'no_ignore_case' module config
option at import time. With the fix the command above works as
expected:
$./eSEL.pl -t <ip-addr> -p get_and_decode_ami -U ADMIN -P ADMIN
Found 69 eSELs with PEL data
Resolves #122
Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
Change-Id: I6996d3d26d1449c758c50cbbf3720f7351a14edb
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/49543
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src')
-rwxr-xr-x | src/build/debug/eSEL.pl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/build/debug/eSEL.pl b/src/build/debug/eSEL.pl index 9cfe640f5..ec4e05c55 100755 --- a/src/build/debug/eSEL.pl +++ b/src/build/debug/eSEL.pl @@ -27,7 +27,7 @@ use strict; use Cwd; use POSIX; use Switch; -use Getopt::Long; +use Getopt::Long qw(:config no_ignore_case); use File::Basename; use Data::Dumper; use File::Copy qw(copy); |