diff options
| author | Patrick Williams <iawillia@us.ibm.com> | 2013-10-10 17:27:43 -0500 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2013-10-10 17:46:58 -0500 |
| commit | 1a6ffb4281f186e1b6d08aff1163f55770e7a810 (patch) | |
| tree | 8a6a32a5c993b7d2b39f42eaf38b21094e33226d /src | |
| parent | 75c505e0c95e8412d007801bfe8a0dd192039df3 (diff) | |
| download | talos-hostboot-1a6ffb4281f186e1b6d08aff1163f55770e7a810.tar.gz talos-hostboot-1a6ffb4281f186e1b6d08aff1163f55770e7a810.zip | |
Resolve race condition in errl shutdown.
The errorlog manager is responding to the shutdown message prior to
fully doing its own shutdown. This is bad because it hasn't
actually push the error log content to PNOR yet and the system
could shutdown before this is complete. For some reason, this is
also causing pervasive failures in Jenkins (due to manipulating
the shutdown-callback list while other code is using it).
Change-Id: I25377b1bfbd4503b10a18444fb67eca3912e3d11
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/6627
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/usr/errl/errlmanager.C | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/usr/errl/errlmanager.C b/src/usr/errl/errlmanager.C index 14041b178..ed3a97452 100644 --- a/src/usr/errl/errlmanager.C +++ b/src/usr/errl/errlmanager.C @@ -310,11 +310,12 @@ void ErrlManager::errlogMsgHndlr ( void ) case ERRLOG_SHUTDOWN: TRACFCOMP( g_trac_errl, INFO_MRK "Shutdown event received" ); - // respond before shutting down our queue etc.. - msg_respond ( iv_msgQ, theMsg ); //Start shutdown process for error log errlogShutdown(); + // Respond that we are done shutting down. + msg_respond ( iv_msgQ, theMsg ); + TRACFCOMP( g_trac_errl, INFO_MRK "Shutdown event processed" ); break; |
