diff options
| author | Mike Jones <mjjones@us.ibm.com> | 2013-03-21 14:45:49 -0500 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2013-03-29 13:35:38 -0500 |
| commit | 192f986571b47f2f3d34556eebd089d9ad55b456 (patch) | |
| tree | 6d2172b2eb9c2045c75df3398094f2e2a5502799 /src | |
| parent | 52e4575636381d80ccf47053b8070c64f08af0e3 (diff) | |
| download | talos-hostboot-192f986571b47f2f3d34556eebd089d9ad55b456.tar.gz talos-hostboot-192f986571b47f2f3d34556eebd089d9ad55b456.zip | |
Add fapi namespace to Chip EC Feature macro
HW Procedure code that queries a Chip EC Feature attribute (to find
out if a chip has a particular feature/bug which is determined by
EC level) will not compile unless the HWP is either within or is
using the fapi namespace. This is because the FAPI generated macros
do not prefix the AttributeID with 'fapi::', the fix is trivial.
Change-Id: Ie65a842d45a9c5387ad3f4d380d9af3507ad817c
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/3681
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Tested-by: Jenkins Server
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src')
| -rwxr-xr-x | src/usr/hwpf/fapi/fapiParseAttributeInfo.pl | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/usr/hwpf/fapi/fapiParseAttributeInfo.pl b/src/usr/hwpf/fapi/fapiParseAttributeInfo.pl index bff32a105..deb2fa174 100755 --- a/src/usr/hwpf/fapi/fapiParseAttributeInfo.pl +++ b/src/usr/hwpf/fapi/fapiParseAttributeInfo.pl @@ -6,7 +6,7 @@ # # IBM CONFIDENTIAL # -# COPYRIGHT International Business Machines Corp. 2011,2012 +# COPYRIGHT International Business Machines Corp. 2011,2013 # # p1 # @@ -64,6 +64,7 @@ # mjjones 09/28/12 Minor change to add FFDC on error # mjjones 11/05/12 Generate fapiAttributeIds.txt # Generate fapiAttributeEnums.txt +# mjjones 03/21/13 Add fapi namespace to Chip EC Feature macro # # End Change Log ****************************************************** @@ -489,7 +490,7 @@ foreach my $argnum (1 .. $#ARGV) # compile failure if a set is attempted #------------------------------------------------------------------ print AIFILE "#define $attr->{id}_GETMACRO(ID, PTARGET, VAL) "; - print AIFILE "fapi::fapiQueryChipEcFeature(ID, PTARGET, VAL)\n"; + print AIFILE "fapi::fapiQueryChipEcFeature(fapi::ID, PTARGET, VAL)\n"; print AIFILE "#define $attr->{id}_SETMACRO(ID, PTARGET, VAL) "; print AIFILE "CHIP_EC_FEATURE_ATTRIBUTE_NOT_WRITABLE\n"; } |
