Make plat init attributes non-writable

Change-Id: I382948a4083293e4ecc42a9759559a060444f5f0
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/34997
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Reviewed-by: SRINIVAS V. POLISETTY <srinivan@in.ibm.com>
Reviewed-by: Matt K. Light <mklight@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35044
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>

5 files changed, 71 insertions, 103 deletions

diff --git a/src/import/chips/p9/procedures/xml/attribute_info/nest_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/nest_attributes.xml
index a67e37b94..4d5483b8a 100644
--- a/src/import/chips/p9/procedures/xml/attribute_info/nest_attributes.xml
+++ b/src/import/chips/p9/procedures/xml/attribute_info/nest_attributes.xml
@@ -193,7 +193,6 @@
     SLOW = 0x01
   </enum>
   <platInit/>
-  <writeable/>
  </attribute>
 <!-- ********************************************************************** -->
 <attribute>
@@ -291,7 +290,6 @@
     CHIP_IS_GROUP = 0x02
   </enum>
   <platInit/>
-  <writeable/>
 </attribute>
 <!-- ********************************************************************** -->
 <attribute>
@@ -421,10 +419,6 @@
   </description>
   <valueType>uint8</valueType>
   <platInit/>
-  <!-- TODO: Story 155081
-       Not supposed to be writeable, PPE needs to resolve this issue in
-       p9_sbe_attr_setup.C -->
-  <writeable/>
 </attribute>
 <!-- ********************************************************************** -->
 <attribute>
@@ -438,10 +432,6 @@
   </description>
   <valueType>uint8</valueType>
   <platInit/>
-  <!-- TODO: Story 155081
-       Not supposed to be writeable, PPE needs to resolve this issue in
-       p9_sbe_attr_setup.C -->
-  <writeable/>
 </attribute>
 <!-- ********************************************************************** -->
 <attribute>
@@ -454,10 +444,6 @@
   </description>
   <valueType>uint8</valueType>
   <platInit/>
-  <!-- TODO: Story 155081
-       Not supposed to be writeable, PPE needs to resolve this issue in
-       p9_sbe_attr_setup.C -->
-  <writeable/>
 </attribute>
 <!-- ********************************************************************** -->
 <attribute>
@@ -781,11 +767,8 @@
   <valueType>uint8</valueType>
   <enum>HB_IPL = 0x1,HB_RUNTIME = 0x2,CACHE_CONTAINED = 0x4,CHIP_CONTAINED = 0x8,NONHB_IPL = 0x10</enum>
   <persistRuntime/>
-  <platInit/>
-  <!-- TODO: Story 155081
-       Not supposed to be writeable, PPE needs to resolve this issue in
-       p9_sbe_attr_setup.C -->
   <writeable/>
+  <platInit/>
 </attribute>
 <!-- ********************************************************************** -->
 <attribute>
@@ -800,10 +783,6 @@
     TRUE = 0x1
   </enum>
   <platInit/>
-  <!-- TODO: Story 155081
-       Not supposed to be writeable, PPE needs to resolve this issue in
-       sberegaccess.C -->
-  <writeable/>
   <initToZero/>
 </attribute>
 <!-- ********************************************************************** -->
diff --git a/src/import/chips/p9/procedures/xml/attribute_info/pervasive_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/pervasive_attributes.xml
index d0444806d..e543d94bc 100755
--- a/src/import/chips/p9/procedures/xml/attribute_info/pervasive_attributes.xml
+++ b/src/import/chips/p9/procedures/xml/attribute_info/pervasive_attributes.xml
@@ -34,10 +34,6 @@
   <description>setup clock mux settings</description>
   <valueType>uint32</valueType>
   <platInit/>
-  <!-- TODO: Story 155081
-       Not supposed to be writeable, PPE needs to resolve this issue in
-       p9_sbe_attr_setup.C -->
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -55,7 +51,6 @@
   <valueType>uint16</valueType>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -65,7 +60,6 @@
   <valueType>uint8</valueType>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -75,7 +69,6 @@
   <valueType>uint32</valueType>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -106,7 +99,6 @@
   <enum>FSP_LESS = 0x0,FSP = 0x1</enum>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -137,7 +129,6 @@
   <valueType>uint8</valueType>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -147,7 +138,6 @@
   <valueType>uint8</valueType>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -157,7 +147,6 @@
   <valueType>uint8</valueType>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -167,7 +156,6 @@
   <valueType>uint8</valueType>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -177,7 +165,6 @@
   <valueType>uint8</valueType>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -196,7 +183,6 @@
   <valueType>uint16</valueType>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -208,7 +194,6 @@
   <enum>FALSE = 0x0,TRUE = 0x1</enum>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -220,7 +205,6 @@
   <enum>FALSE = 0x0,TRUE = 0x1</enum>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -239,7 +223,6 @@
   <valueType>uint32</valueType>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -384,7 +367,6 @@
   <enum>FALSE = 0x0,TRUE = 0x1</enum>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -464,7 +446,6 @@
   <valueType>uint8</valueType>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -474,7 +455,6 @@
   </description>
   <valueType>uint8</valueType>
   <persistRuntime/>
-  <platInit/>
   <writeable/>
 </attribute>
 
@@ -486,7 +466,6 @@
   </description>
   <valueType>uint8</valueType>
   <persistRuntime/>
-  <platInit/>
   <writeable/>
 </attribute>
 
@@ -496,7 +475,6 @@
   <description>Holds the state of Security Access Bit (SAB)</description>
   <valueType>uint8</valueType>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -512,7 +490,6 @@
   </description>
   <valueType>uint8</valueType>
   <platInit/>
-  <writeable/>
   <initToZero/>
 </attribute>
 
@@ -525,9 +502,6 @@
   <initToZero/>
 </attribute>
 
-<!-- TODO: Story 155081
-     Not supposed to be writeable, PPE needs to resolve this issue in
-     p9_sbe_attr_setup.C -->
 <attribute>
     <id>ATTR_OBUS_RATIO_VALUE</id>
     <targetType>TARGET_TYPE_PROC_CHIP</targetType>
@@ -538,7 +512,6 @@
     <valueType>uint8</valueType>
     <persistRuntime/>
     <platInit/>
-    <writeable/>
 </attribute>
 
 <attribute>
@@ -547,7 +520,6 @@
     <description>Pibmem repair attribute 0</description>
     <valueType>uint64</valueType>
     <persistRuntime/>
-    <platInit/>
     <writeable/>
 </attribute>
 
@@ -557,7 +529,6 @@
      <description>Pibmem repair attribute 1</description>
      <valueType>uint64</valueType>
      <persistRuntime/>
-     <platInit/>
      <writeable/>
 </attribute>
 
@@ -567,7 +538,6 @@
      <description>Pibmem repair attribute 2</description>
      <valueType>uint64</valueType>
      <persistRuntime/>
-     <platInit/>
      <writeable/>
 </attribute>
 
@@ -585,10 +555,6 @@
     <description>To skip the locking sequence and check for lock of CP filter PLL</description>
     <valueType>uint8</valueType>
     <platInit/>
-    <!-- TODO: Story 155081
-         Not supposed to be writeable, PPE needs to resolve this issue in
-         p9_sbe_attr_setup.C -->
-    <writeable/>
 </attribute>
 
 <attribute>
@@ -597,10 +563,6 @@
     <description>To skip the locking sequence and check for lock of SS filter PLL</description>
     <valueType>uint8</valueType>
     <platInit/>
-    <!-- TODO: Story 155081
-         Not supposed to be writeable, PPE needs to resolve this issue in
-         p9_sbe_attr_setup.C -->
-    <writeable/>
 </attribute>
 
 <attribute>
@@ -609,10 +571,6 @@
     <description>To skip the locking sequence and check for lock of IO filter PLL</description>
     <valueType>uint8</valueType>
     <platInit/>
-    <!-- TODO: Story 155081
-         Not supposed to be writeable, PPE needs to resolve this issue in
-         p9_sbe_attr_setup.C -->
-    <writeable/>
 </attribute>
 
 <attribute>
@@ -621,10 +579,6 @@
     <description>Skip locking sequence and check for lock of DPLL</description>
     <valueType>uint8</valueType>
     <platInit/>
-    <!-- TODO: Story 155081
-         Not supposed to be writeable, PPE needs to resolve this issue in
-         p9_sbe_attr_setup.C -->
-    <writeable/>
 </attribute>
 
 <attribute>
@@ -633,10 +587,6 @@
     <description>Skip the locking sequence and check for lock of NEST/MEM/XBUS/OBUS/PCI PLLs</description>
     <valueType>uint8</valueType>
     <platInit/>
-    <!-- TODO: Story 155081
-         Not supposed to be writeable, PPE needs to resolve this issue in
-         p9_sbe_attr_setup.C -->
-    <writeable/>
 </attribute>
 
 <attribute>
@@ -675,7 +625,6 @@
   <description>System Configurtion information - 1 indicates a chip present</description>
   <valueType>uint64</valueType>
   <platInit/>
-  <writeable/>
 </attribute>
 
 <attribute>
@@ -784,7 +733,6 @@
   <valueType>uint8</valueType>
   <persistRuntime/>
   <platInit/>
-  <writeable/>
 </attribute>
 
 </attributes>
diff --git a/src/include/usr/fapi2/attribute_service.H b/src/include/usr/fapi2/attribute_service.H
index f21020610..110e0b4c8 100644
--- a/src/include/usr/fapi2/attribute_service.H
+++ b/src/include/usr/fapi2/attribute_service.H
@@ -407,9 +407,5 @@ fapiToTargeting::ID, sizeof(VAL), &(VAL))
     AttrOverrideSync::getAttrOverrideFunc(ID, TARGET, &VAL)\
     ? fapi2::ReturnCode() : \
     fapi2::platAttrSvc::platGetSecurityMode(VAL)
-#define ATTR_SECURITY_MODE_SETMACRO(ID, TARGET, VAL) \
-    AttrOverrideSync::getAttrOverrideFunc(ID, TARGET, &VAL)\
-    ? fapi2::ReturnCode() : \
-    fapi2::platAttrSvc::platSetSecurityMode()
 
 #endif // ATTRIBUTESERVICE_H_
diff --git a/src/usr/targeting/common/xmltohb/attribute_types.xml b/src/usr/targeting/common/xmltohb/attribute_types.xml
index 31098656f..fd2ff7946 100755
--- a/src/usr/targeting/common/xmltohb/attribute_types.xml
+++ b/src/usr/targeting/common/xmltohb/attribute_types.xml
@@ -75,25 +75,6 @@
     </simpleType>
   </attribute>
 
-<attribute>
-    <id>SYSTEM_IPL_PHASE</id>
-    <description>Define context for current phase of system IPL.
-      Provided by the platform.
-      HB_IPL = 0x1,HB_RUNTIME = 0x2,CACHE_CONTAINED = 0x4</description>
-  <simpleType>
-    <uint8_t>
-      <default>0x01</default>
-    </uint8_t>
-  </simpleType>
-  <hwpfToHbAttrMap>
-    <id>ATTR_SYSTEM_IPL_PHASE</id>
-    <macro>DIRECT</macro>
-  </hwpfToHbAttrMap>
-  <persistency>non-volatile</persistency>
-  <readable/>
-  <writeable/>
-</attribute>
-
 
   <attribute>
     <description>Dummy attribute with read/write permissions</description>
@@ -582,7 +563,6 @@
         <default>0</default>
       </uint8_t>
     </simpleType>
-    <no_export/>
   </attribute>
 
   <attribute>
@@ -7004,6 +6984,38 @@ Selects which voltage level to place the Core and ECO domain PFETs upon Winkle e
 </attribute>
 
 <attribute>
+    <id>A_EREPAIR_THRESHOLD_FIELD</id>
+    <description>
+      This attribute represents the eRepair threshold value of A-Bus used
+      in the field.
+      creator: platform (generated based on MRW data)
+      See defintion in erepair_thresholds.xml for more information.
+    </description>
+    <simpleType>
+      <uint8_t>
+      </uint8_t>
+    </simpleType>
+    <persistency>non-volatile</persistency>
+    <readable/>
+</attribute>
+
+<attribute>
+    <id>A_EREPAIR_THRESHOLD_MNFG</id>
+    <description>
+      This attribute represents the eRepair threshold value of A-Bus used
+      by Manufacturing.
+      creator: platform (generated based on MRW data)
+      See defintion in erepair_thresholds.xml for more information.
+    </description>
+    <simpleType>
+      <uint8_t>
+      </uint8_t>
+    </simpleType>
+    <persistency>non-volatile</persistency>
+    <readable/>
+</attribute>
+
+<attribute>
     <id>MSS_MBA_ADDR_INTERLEAVE_BIT</id>
     <description>sets the Centaur address bits used to interleave addresses between MBA01 and MBA23. valid values are 23 through 32.</description>
     <simpleType>
diff --git a/src/usr/targeting/common/xmltohb/hb_customized_attrs.xml b/src/usr/targeting/common/xmltohb/hb_customized_attrs.xml
index 10df84541..830512147 100644
--- a/src/usr/targeting/common/xmltohb/hb_customized_attrs.xml
+++ b/src/usr/targeting/common/xmltohb/hb_customized_attrs.xml
@@ -55,7 +55,7 @@
      <!-- =====================================================================
      Start of customizations
      ================================================================= -->
- <attribute>
+     <attribute>
           <id>ATTR_DUMMY_SCRATCH_PLAT_INIT_UINT8</id>
           <default>5</default>
      </attribute>
@@ -297,6 +297,7 @@
     <attribute>
           <id>ATTR_NEST_PLL_BUCKET</id>
           <default>0x05</default>
+          <writeable/>
      </attribute>
 
     <attribute>
@@ -316,7 +317,7 @@
 
     <attribute>
           <id>ATTR_SYSTEM_IPL_PHASE</id>
-          <default>0x01</default>
+          <default>HB_IPL</default>
      </attribute>
 
     <attribute>
@@ -528,6 +529,12 @@
      </attribute>
 
     <attribute>
+          <id>ATTR_SYSTEM_RESCLK_DISABLE</id>
+          <default>0x00</default>
+          <writeable/>
+    </attribute>
+
+    <attribute>
           <id>ATTR_BACKUP_SEEPROM_SELECT</id>
           <writeable/>
     </attribute>
@@ -545,11 +552,13 @@
 
     <attribute>
           <id>ATTR_PROC_EFF_FABRIC_GROUP_ID</id>
+          <writeable/>
           <no_export/>
     </attribute>
 
     <attribute>
           <id>ATTR_PROC_EFF_FABRIC_CHIP_ID</id>
+          <writeable/>
           <no_export/>
     </attribute>
 
@@ -564,6 +573,11 @@
     </attribute>
 
     <attribute>
+          <id>ATTR_DMI_REFCLOCK_SWIZZLE</id>
+          <no_export/>
+    </attribute>
+
+    <attribute>
           <id>ATTR_MRW_MEM_SENSOR_CACHE_ADDR_MAP</id>
           <no_export/>
     </attribute>
@@ -584,10 +598,29 @@
     </attribute>
 
     <attribute>
-          <id>ATTR_EI_BUS_TX_MSBSWAP</id>
-          <global/>
+          <id>ATTR_PROC_SBE_MASTER_CHIP</id>
+          <writeable/>
+    </attribute>
+
+    <attribute>
+          <id>ATTR_RISK_LEVEL</id>
+          <writeable/>
+    </attribute>
+
+    <attribute>
+          <id>ATTR_BOOT_FLAGS</id>
+          <writeable/>
     </attribute>
 
+    <attribute>
+          <id>ATTR_EC_GARD</id>
+          <writeable/>
+    </attribute>
+
+    <attribute>
+          <id>ATTR_EQ_GARD</id>
+          <writeable/>
+    </attribute>
     <attribute><id>ATTR_CEN_MSS_ALLOW_SINGLE_PORT</id><default>FALSE</default></attribute>
     <attribute><id>ATTR_CEN_VPD_DIMM_RCD_OUTPUT_TIMING</id><default>0x01,0x00,0x01,0x00</default></attribute>
 
@@ -608,7 +641,7 @@
     <attribute><id>ATTR_CEN_MRW_CDIMM_SPARE_I2C_TEMP_SENSOR_ENABLE</id><default>0x01</default></attribute>
     <attribute><id>ATTR_CEN_MRW_SAFEMODE_MEM_THROTTLE_NUMERATOR_PER_MBA</id><default>0x00000060</default></attribute>
     <attribute><id>ATTR_CEN_MRW_SAFEMODE_MEM_THROTTLE_NUMERATOR_PER_CHIP</id><default>0x00000020</default></attribute>
- 
+
     <attribute><id>ATTR_CEN_VPD_DRV_IMP_DQ_DQS</id><default>OHM34_FFE0,OHM34_FFE0</default></attribute>
     <attribute><id>ATTR_CEN_VPD_SLEW_RATE_DQ_DQS</id><default>0x03,0x03</default></attribute>
     <attribute><id>ATTR_CEN_EFF_CEN_DRV_IMP_DQ_DQS</id><default>OHM34_FFE0,OHM34_FFE0</default></attribute>