diff options
| author | Nick Bofferding <bofferdn@us.ibm.com> | 2019-04-23 08:46:10 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-04-25 12:41:05 -0500 |
| commit | 0f03814d62a6693df5b0c3118662e00a5b79b24a (patch) | |
| tree | 05b3fab2b80acc2a1d34a515db9bd262b2f9f819 /src | |
| parent | 508ddc960ec66dd9d6b312eb699589f3431dad1d (diff) | |
| download | talos-hostboot-0f03814d62a6693df5b0c3118662e00a5b79b24a.tar.gz talos-hostboot-0f03814d62a6693df5b0c3118662e00a5b79b24a.zip | |
Only display ERRL user details callouts/strings when dumping error to console
This commit fixes a bug wherein, when Hostboot dumped an error log to the
console that contained user details with the same subsection ID as an ERRL
string but for a different component ID, the information, which was often in
binary format, would appear garbled, and would additionally terminate the BMC's
SOL session due to invalid characters. The change narrows the scope of what
gets emitted to just ERRL component strings/callouts.
Change-Id: Ifbe83448a56955d44f0e775e123ffb95a6330b8a
CQ: SW463437
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76381
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/usr/errldisplay/errldisplay.C | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/usr/errldisplay/errldisplay.C b/src/usr/errldisplay/errldisplay.C index b8c26614e..b6ae46fc4 100644 --- a/src/usr/errldisplay/errldisplay.C +++ b/src/usr/errldisplay/errldisplay.C @@ -709,7 +709,7 @@ void ErrLogDisplay::msgDisplay (const errlHndl_t &i_err, displayHwpf( user_data->iv_pData, user_data->iv_Size, user_data->iv_header.iv_sst); } - else + else if(user_data->iv_header.iv_compId == ERRL_COMP_ID) { switch ( user_data->iv_header.iv_sst ) { |
