diff options
author | Matt Derksen <mderkse1@us.ibm.com> | 2017-06-30 09:11:34 -0500 |
---|---|---|
committer | Nicholas E. Bofferding <bofferdn@us.ibm.com> | 2017-07-07 15:32:11 -0400 |
commit | e725dc10bc6113e3ea09f862dad184b85c0c3ca0 (patch) | |
tree | c80eb740664e45859c8a0e206931dad51705f2d3 /src/usr | |
parent | 814c42018faf5626960becf1e089f42127c6bd2d (diff) | |
download | talos-hostboot-e725dc10bc6113e3ea09f862dad184b85c0c3ca0.tar.gz talos-hostboot-e725dc10bc6113e3ea09f862dad184b85c0c3ca0.zip |
Undo hbrt errl into pnor workaround
Change-Id: I0c00eb1a400410a72cabb89d57d80e70d0ab3ebe
RTC: 131067
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/42657
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Diffstat (limited to 'src/usr')
-rw-r--r-- | src/usr/errl/runtime/rt_errlmanager.C | 34 |
1 files changed, 2 insertions, 32 deletions
diff --git a/src/usr/errl/runtime/rt_errlmanager.C b/src/usr/errl/runtime/rt_errlmanager.C index 14b61622e..f690fded5 100644 --- a/src/usr/errl/runtime/rt_errlmanager.C +++ b/src/usr/errl/runtime/rt_errlmanager.C @@ -109,14 +109,6 @@ ErrlManager::ErrlManager() : TRACFCOMP( g_trac_errl, ERR_MRK"HOSTSVC_PLID not available" ); } -#if 1 -// TODO: RTC 131067 -// for now do this. but the real code should be the #else below. -#ifdef CONFIG_BMC_IPMI - // setup so that we can write the error log to PNOR - setupPnorInfo(); -#endif -#else // check if there's an FSP. if not, then we write to PNOR TARGETING::SpFunctions spfn; if (!(sys && @@ -131,7 +123,7 @@ ErrlManager::ErrlManager() : { iv_isSpBaseServices = true; } -#endif + TRACFCOMP( g_trac_errl, EXIT_MRK "ErrlManager::ErrlManager constructor." ); } @@ -141,22 +133,12 @@ ErrlManager::ErrlManager() : ErrlManager::~ErrlManager() { TRACFCOMP( g_trac_errl, INFO_MRK"ErrlManager::ErrlManager destructor" ); -#if 1 -// TODO: RTC 131067 -// for now do this. but the real code should be the #else below. -#ifdef CONFIG_BMC_IPMI - // if we saved to PNOR, we need to flush - TRACFCOMP( g_trac_errl, INFO_MRK"flushing pnor" ); - PNOR::flush(PNOR::HB_ERRLOGS); -#endif -#else if (!iv_isSpBaseServices) { // if we saved to PNOR, we need to flush TRACFCOMP( g_trac_errl, INFO_MRK"no baseServices, flushing pnor" ); PNOR::flush(PNOR::HB_ERRLOGS); } -#endif } /////////////////////////////////////////////////////////////////////////////// @@ -166,18 +148,6 @@ void ErrlManager::sendMboxMsg ( errlHndl_t& io_err ) { do { -#if 1 -// TODO: RTC 131067 -// for now do this. but the real code should be the #else below. -#ifdef CONFIG_BMC_IPMI - bool l_savedToPnor = saveErrLogToPnor(io_err); - if (!l_savedToPnor) - { - TRACFCOMP( g_trac_errl, ENTER_MRK"saveErrLogToPnor didn't save 0x%X", - io_err->eid()); - } -#endif -#else if (!iv_isSpBaseServices) { // save to PNOR @@ -189,7 +159,7 @@ void ErrlManager::sendMboxMsg ( errlHndl_t& io_err ) io_err->eid()); } } -#endif + #ifdef CONFIG_BMC_IPMI TRACFCOMP(g_trac_errl,INFO_MRK"Send msg to BMC for errlogId [0x%08x]", |