diff options
author | Bill Hoffa <wghoffa@us.ibm.com> | 2016-10-17 10:36:08 -0500 |
---|---|---|
committer | Matthew A. Ploetz <maploetz@us.ibm.com> | 2016-10-17 13:30:06 -0400 |
commit | 8175fb0211fd0a30984e29c496e14c785fb4c1e2 (patch) | |
tree | b8fc2734bb8eaf7159d8988475934a4bdb9fd494 /src/usr | |
parent | 17a4c82c2323816bc7865a6963a795e39ce64ad9 (diff) | |
download | talos-hostboot-8175fb0211fd0a30984e29c496e14c785fb4c1e2.tar.gz talos-hostboot-8175fb0211fd0a30984e29c496e14c785fb4c1e2.zip |
Remove HWP call to p9_extract_sbe_rc
The SBE Team says this should only be called during a special
attention scenario and not during the normal IPL flow.
Change-Id: I452990e20dce11935519cf35548d973a2c31fde1
CQ: SW369123
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/31336
Reviewed-by: Elizabeth K. Liner <eliner@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matthew A. Ploetz <maploetz@us.ibm.com>
Diffstat (limited to 'src/usr')
-rw-r--r-- | src/usr/isteps/istep08/call_proc_check_slave_sbe_seeprom_complete.C | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/src/usr/isteps/istep08/call_proc_check_slave_sbe_seeprom_complete.C b/src/usr/isteps/istep08/call_proc_check_slave_sbe_seeprom_complete.C index efac0b2a4..2af371d9f 100644 --- a/src/usr/isteps/istep08/call_proc_check_slave_sbe_seeprom_complete.C +++ b/src/usr/isteps/istep08/call_proc_check_slave_sbe_seeprom_complete.C @@ -217,11 +217,15 @@ void* call_proc_check_slave_sbe_seeprom_complete( void *io_pArgs ) else if(l_cpu_target->getAttr<ATTR_HWAS_STATE>().functional) { TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace, - "SUCCESS : proc_check_slave_sbe_seeprom_complete", - "completed ok for proc 0x%.8X", + "SUCCESS : proc_check_slave_sbe_seeprom_complete" + " completed ok for proc 0x%.8X", TARGETING::get_huid(l_cpu_target)); } +/* @TODO-RTC:100963 This should only be called when the SBE has completely + crashed. There is a path in OpenPower where HB may get an + attention and need to call it. For now, though, just associate + with this story for tracking. // Not a way to pass in -soft_err, assuming that is default behavior TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace, @@ -238,7 +242,7 @@ void* call_proc_check_slave_sbe_seeprom_complete( void *io_pArgs ) if (l_errl) { TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace, - "ERROR : proc_check_slave_sbe_seeprom_complete", + "ERROR : proc_check_slave_sbe_seeprom_complete " "failed, p9_extract_sbe_rc HWP returning errorlog PLID=0x%x", l_errl->plid()); @@ -251,6 +255,7 @@ void* call_proc_check_slave_sbe_seeprom_complete( void *io_pArgs ) // Commit error log errlCommit( l_errl, HWPF_COMP_ID ); } +**/ } // end of going through all processors @@ -296,7 +301,7 @@ void* call_proc_check_slave_sbe_seeprom_complete( void *io_pArgs ) else // Not functional, proc deconfigured, don't report error { TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace, - "ERROR : p9_getecid", + "ERROR : p9_getecid" " failed, proc target deconfigured" ); delete l_errl; l_errl = NULL; @@ -305,7 +310,7 @@ void* call_proc_check_slave_sbe_seeprom_complete( void *io_pArgs ) else { TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace, - "SUCCESS : proc_getecid", + "SUCCESS : proc_getecid" " completed ok"); } |