diff options
| author | Caleb Palmer <cnpalmer@us.ibm.com> | 2018-10-12 15:41:57 -0500 |
|---|---|---|
| committer | Zane C. Shelley <zshelle@us.ibm.com> | 2018-10-16 14:52:29 -0500 |
| commit | 6dc98524f3673a1c49bffcc738a7a7c09af7c989 (patch) | |
| tree | 3efa471dc8ab80770ab3c161a9262712e6e966a8 /src/usr | |
| parent | 3e677e6cdf31494f05d6c23828c80d92ba5b2280 (diff) | |
| download | talos-hostboot-6dc98524f3673a1c49bffcc738a7a7c09af7c989.tar.gz talos-hostboot-6dc98524f3673a1c49bffcc738a7a7c09af7c989.zip | |
Reconfig loop only when setting bad bits not clearing
Change-Id: Ieb487b6587ff957d371c8049208f1368ab5d6c24
CQ: SW448578
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67447
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Diffstat (limited to 'src/usr')
| -rw-r--r-- | src/usr/fapi2/attribute_service.C | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/src/usr/fapi2/attribute_service.C b/src/usr/fapi2/attribute_service.C index b43f151aa..f729bab87 100644 --- a/src/usr/fapi2/attribute_service.C +++ b/src/usr/fapi2/attribute_service.C @@ -1604,11 +1604,19 @@ ReturnCode fapiAttrSetBadDqBitmap( // Loop through all DQs for (uint8_t j = 0; j < mss::BAD_DQ_BYTE_COUNT; j++) { - if ( l_tmpData[i][j] != l_prev_data[i][j] ) + // Loop through all bits + for ( uint8_t k = 0; k < mss::BITS_PER_BYTE; k++ ) { - badDqSet = true; - break; + uint8_t prevBit = (l_prev_data[i][j] >> k) & 0x01; + uint8_t newBit = (l_tmpData[i][j] >> k) & 0x01; + // Check for differences, and the bit was set, not cleared + if ( (prevBit != newBit) && (newBit != 0) ) + { + badDqSet = true; + break; + } } + if ( badDqSet ) break; } if ( badDqSet ) break; } |
