summaryrefslogtreecommitdiffstats
path: root/src/usr
diff options
context:
space:
mode:
authorBilicon Patil <bilpatil@in.ibm.com>2013-07-08 02:56:11 -0500
committerA. Patrick Williams III <iawillia@us.ibm.com>2013-07-10 16:39:16 -0500
commit5a96508c99aa023368eeb1e3592fc6bf9d198ccc (patch)
treeab4fff2f293f6338b52720c672ccdf205477e101 /src/usr
parentf113643ef80b77ffeacf7203d9e30960e7889601 (diff)
downloadtalos-hostboot-5a96508c99aa023368eeb1e3592fc6bf9d198ccc.tar.gz
talos-hostboot-5a96508c99aa023368eeb1e3592fc6bf9d198ccc.zip
Fix incorrect bus type check when parsing VPD.
When parsing lane repair data for XBus and ABus, the bus type check was not made for the specific instance of ABus or XBus type. Change-Id: I07084fe49a80f586ed5e0a319af01708a8948414 RTC:77423 Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/5323 Tested-by: Jenkins Server Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr')
-rw-r--r--src/usr/hwpf/hwp/bus_training/erepairGetFailedLanesHwp.C8
-rw-r--r--src/usr/hwpf/hwp/bus_training/erepairGetMnfgFailedLanesHwp.C8
2 files changed, 14 insertions, 2 deletions
diff --git a/src/usr/hwpf/hwp/bus_training/erepairGetFailedLanesHwp.C b/src/usr/hwpf/hwp/bus_training/erepairGetFailedLanesHwp.C
index 19fb3a66b..3d1f03e17 100644
--- a/src/usr/hwpf/hwp/bus_training/erepairGetFailedLanesHwp.C
+++ b/src/usr/hwpf/hwp/bus_training/erepairGetFailedLanesHwp.C
@@ -348,12 +348,18 @@ fapi::ReturnCode determineRepairLanes(const fapi::Target &i_tgtHandle,
// Note: This is currently not required.
// Check if we have the matching the Fabric Bus types
- if((l_fabricBus->type != EREPAIR::PROCESSOR_EI4) &&
+ if((l_tgtType == fapi::TARGET_TYPE_ABUS_ENDPOINT) &&
(l_fabricBus->type != EREPAIR::PROCESSOR_EDI))
{
continue;
}
+ if((l_tgtType == fapi::TARGET_TYPE_XBUS_ENDPOINT) &&
+ (l_fabricBus->type != EREPAIR::PROCESSOR_EI4))
+ {
+ continue;
+ }
+
// Check if we have the matching fabric bus interface
l_rc = FAPI_ATTR_GET(ATTR_CHIP_UNIT_POS,&i_tgtHandle,l_busNum);
if(l_rc)
diff --git a/src/usr/hwpf/hwp/bus_training/erepairGetMnfgFailedLanesHwp.C b/src/usr/hwpf/hwp/bus_training/erepairGetMnfgFailedLanesHwp.C
index 375fbfb8d..aeaa23a7f 100644
--- a/src/usr/hwpf/hwp/bus_training/erepairGetMnfgFailedLanesHwp.C
+++ b/src/usr/hwpf/hwp/bus_training/erepairGetMnfgFailedLanesHwp.C
@@ -352,12 +352,18 @@ fapi::ReturnCode determineMnfgRepairLanes(const fapi::Target &i_tgtHandle,
// Note: This is currently not required.
// Check if we have the matching the Fabric Bus types
- if((l_fabricBus->type != EREPAIR::PROCESSOR_EI4) &&
+ if((l_tgtType == fapi::TARGET_TYPE_ABUS_ENDPOINT) &&
(l_fabricBus->type != EREPAIR::PROCESSOR_EDI))
{
continue;
}
+ if((l_tgtType == fapi::TARGET_TYPE_XBUS_ENDPOINT) &&
+ (l_fabricBus->type != EREPAIR::PROCESSOR_EI4))
+ {
+ continue;
+ }
+
// Check if we have the matching fabric bus interface
l_rc = FAPI_ATTR_GET(ATTR_CHIP_UNIT_POS,&i_tgtHandle,l_busNum);
if(l_rc)
OpenPOWER on IntegriCloud