Performance and size optimizations - inline simple methods

Move the code for some of the 'simple' methods (ie, {}, or simple
methods that just set a value or return a value) from the .C file
into the .H file, so that they're inlined. Saves in both size and
performance. Didn't measure performance gains (not sure I can in a
simulated environment..) but generated .list files look much better.
Size - hbicore_extended.bin dropped from 1442928 to 1426544 (16K, 1%)

Change-Id: I6915cba77520b4a28237c557760ababcca781804
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/1464
Tested-by: Jenkins Server
Reviewed-by: MIKE J. JONES <mjjones@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>

5 files changed, 111 insertions, 252 deletions

diff --git a/src/usr/ecmddatabuffer/ecmdDataBufferBase.C b/src/usr/ecmddatabuffer/ecmdDataBufferBase.C
index 0ab6c2920..7ef29de82 100644
--- a/src/usr/ecmddatabuffer/ecmdDataBufferBase.C
+++ b/src/usr/ecmddatabuffer/ecmdDataBufferBase.C
@@ -1,25 +1,25 @@
-//  IBM_PROLOG_BEGIN_TAG
-//  This is an automatically generated prolog.
-//
-//  $Source: src/usr/ecmddatabuffer/ecmdDataBufferBase.C $
-//
-//  IBM CONFIDENTIAL
-//
-//  COPYRIGHT International Business Machines Corp. 2011
-//
-//  p1
-//
-//  Object Code Only (OCO) source materials
-//  Licensed Internal Code Source Materials
-//  IBM HostBoot Licensed Internal Code
-//
-//  The source code for this program is not published or other-
-//  wise divested of its trade secrets, irrespective of what has
-//  been deposited with the U.S. Copyright Office.
-//
-//  Origin: 30
-//
-//  IBM_PROLOG_END
+/* IBM_PROLOG_BEGIN_TAG                                                   */
+/* This is an automatically generated prolog.                             */
+/*                                                                        */
+/* $Source: src/usr/ecmddatabuffer/ecmdDataBufferBase.C $                 */
+/*                                                                        */
+/* IBM CONFIDENTIAL                                                       */
+/*                                                                        */
+/* COPYRIGHT International Business Machines Corp. 2011,2012              */
+/*                                                                        */
+/* p1                                                                     */
+/*                                                                        */
+/* Object Code Only (OCO) source materials                                */
+/* Licensed Internal Code Source Materials                                */
+/* IBM HostBoot Licensed Internal Code                                    */
+/*                                                                        */
+/* The source code for this program is not published or otherwise         */
+/* divested of its trade secrets, irrespective of what has been           */
+/* deposited with the U.S. Copyright Office.                              */
+/*                                                                        */
+/* Origin: 30                                                             */
+/*                                                                        */
+/* IBM_PROLOG_END_TAG                                                     */
 // IMPORTED FROM eCMD on 11/10/2011
 
 // Copyright ***********************************************************
diff --git a/src/usr/errl/errlentry.C b/src/usr/errl/errlentry.C
index 992f0a0c1..76d4a99de 100644
--- a/src/usr/errl/errlentry.C
+++ b/src/usr/errl/errlentry.C
@@ -1,26 +1,25 @@
-/*  IBM_PROLOG_BEGIN_TAG
- *  This is an automatically generated prolog.
- *
- *  $Source: src/usr/errl/errlentry.C $
- *
- *  IBM CONFIDENTIAL
- *
- *  COPYRIGHT International Business Machines Corp. 2011-2012
- *
- *  p1
- *
- *  Object Code Only (OCO) source materials
- *  Licensed Internal Code Source Materials
- *  IBM HostBoot Licensed Internal Code
- *
- *  The source code for this program is not published or other-
- *  wise divested of its trade secrets, irrespective of what has
- *  been deposited with the U.S. Copyright Office.
- *
- *  Origin: 30
- *
- *  IBM_PROLOG_END_TAG
- */
+/* IBM_PROLOG_BEGIN_TAG                                                   */
+/* This is an automatically generated prolog.                             */
+/*                                                                        */
+/* $Source: src/usr/errl/errlentry.C $                                    */
+/*                                                                        */
+/* IBM CONFIDENTIAL                                                       */
+/*                                                                        */
+/* COPYRIGHT International Business Machines Corp. 2011,2012              */
+/*                                                                        */
+/* p1                                                                     */
+/*                                                                        */
+/* Object Code Only (OCO) source materials                                */
+/* Licensed Internal Code Source Materials                                */
+/* IBM HostBoot Licensed Internal Code                                    */
+/*                                                                        */
+/* The source code for this program is not published or otherwise         */
+/* divested of its trade secrets, irrespective of what has been           */
+/* deposited with the U.S. Copyright Office.                              */
+/*                                                                        */
+/* Origin: 30                                                             */
+/*                                                                        */
+/* IBM_PROLOG_END_TAG                                                     */
 /**
  *  @file errlentry.C
  *
@@ -248,7 +247,6 @@ void ErrlEntry::removeBackTrace()
     iv_pBackTrace = NULL;
 }
 
-
 ////////////////////////////////////////////////////////////////////////////
 ////////////////////////////////////////////////////////////////////////////
 void ErrlEntry::addHwCallout(const TARGETING::Target *i_target,
@@ -290,57 +288,6 @@ void ErrlEntry::addProcedureCallout(const HWAS::epubProcedureID i_procedure,
 } // addProcedureCallout
 
 
-////////////////////////////////////////////////////////////////////////////
-////////////////////////////////////////////////////////////////////////////
-errlSeverity_t ErrlEntry::sev() const
-{
-    return iv_User.iv_severity;
-}
-
-
-////////////////////////////////////////////////////////////////////////////
-////////////////////////////////////////////////////////////////////////////
-void ErrlEntry::setSev(const errlSeverity_t i_sev)
-{
-    iv_User.iv_severity = i_sev;
-    return;
-}
-
-
-////////////////////////////////////////////////////////////////////////////
-////////////////////////////////////////////////////////////////////////////
-errlEventType_t ErrlEntry::eventType() const
-{
-    return iv_User.iv_etype;
-}
-
-
-
-////////////////////////////////////////////////////////////////////////////
-////////////////////////////////////////////////////////////////////////////
-void ErrlEntry::setEventType(const errlEventType_t i_eventType)
-{
-    iv_User.iv_etype = i_eventType;
-    return;
-}
-
-////////////////////////////////////////////////////////////////////////////
-////////////////////////////////////////////////////////////////////////////
-epubSubSystem_t ErrlEntry::subSys() const
-{
-    return iv_User.iv_ssid;
-}
-
-
-////////////////////////////////////////////////////////////////////////////
-////////////////////////////////////////////////////////////////////////////
-void ErrlEntry::setSubSys(const epubSubSystem_t i_subSys)
-{
-    iv_User.iv_ssid = i_subSys;
-    return;
-}
-
-
 ///////////////////////////////////////////////////////////////////////////////
 // for use by ErrlManager
 void ErrlEntry::commit( compId_t  i_committerComponent )
diff --git a/src/usr/hwpf/fapi/fapiReturnCode.C b/src/usr/hwpf/fapi/fapiReturnCode.C
index 08eca6c82..97b923406 100644
--- a/src/usr/hwpf/fapi/fapiReturnCode.C
+++ b/src/usr/hwpf/fapi/fapiReturnCode.C
@@ -1,26 +1,25 @@
-/*  IBM_PROLOG_BEGIN_TAG
- *  This is an automatically generated prolog.
- *
- *  $Source: src/usr/hwpf/fapi/fapiReturnCode.C $
- *
- *  IBM CONFIDENTIAL
- *
- *  COPYRIGHT International Business Machines Corp. 2011-2012
- *
- *  p1
- *
- *  Object Code Only (OCO) source materials
- *  Licensed Internal Code Source Materials
- *  IBM HostBoot Licensed Internal Code
- *
- *  The source code for this program is not published or other-
- *  wise divested of its trade secrets, irrespective of what has
- *  been deposited with the U.S. Copyright Office.
- *
- *  Origin: 30
- *
- *  IBM_PROLOG_END_TAG
- */
+/* IBM_PROLOG_BEGIN_TAG                                                   */
+/* This is an automatically generated prolog.                             */
+/*                                                                        */
+/* $Source: src/usr/hwpf/fapi/fapiReturnCode.C $                          */
+/*                                                                        */
+/* IBM CONFIDENTIAL                                                       */
+/*                                                                        */
+/* COPYRIGHT International Business Machines Corp. 2011,2012              */
+/*                                                                        */
+/* p1                                                                     */
+/*                                                                        */
+/* Object Code Only (OCO) source materials                                */
+/* Licensed Internal Code Source Materials                                */
+/* IBM HostBoot Licensed Internal Code                                    */
+/*                                                                        */
+/* The source code for this program is not published or otherwise         */
+/* divested of its trade secrets, irrespective of what has been           */
+/* deposited with the U.S. Copyright Office.                              */
+/*                                                                        */
+/* Origin: 30                                                             */
+/*                                                                        */
+/* IBM_PROLOG_END_TAG                                                     */
 /**
  *  @file fapiReturnCode.C
  *
@@ -46,6 +45,7 @@
  *                          mjjones     03/16/2012  Allow different PLAT errors
  *                          mjjones     05/02/2012  Only trace setEcmdError on err
  *                          mjjones     07/11/2012  Remove a trace
+ *                          brianh      07/31/2012  performance/size optimizations
  *                          mjjones     08/14/2012  Use new ErrorInfo structure
  */
 
@@ -57,15 +57,6 @@ namespace fapi
 {
 
 //******************************************************************************
-// Default Constructor
-//******************************************************************************
-ReturnCode::ReturnCode() :
-    iv_rcValue(FAPI_RC_SUCCESS), iv_pDataRef(NULL)
-{
-
-}
-
-//******************************************************************************
 // Constructor
 //******************************************************************************
 ReturnCode::ReturnCode(const ReturnCodes i_rcValue) :
@@ -139,22 +130,6 @@ ReturnCode & ReturnCode::operator=(const uint32_t i_rcValue)
 }
 
 //******************************************************************************
-// ok function
-//******************************************************************************
-bool ReturnCode::ok() const
-{
-    return (iv_rcValue == FAPI_RC_SUCCESS);
-}
-
-//******************************************************************************
-// returnCode_t cast
-//******************************************************************************
-ReturnCode::operator uint32_t() const
-{
-    return iv_rcValue;
-}
-
-//******************************************************************************
 // setFapiError function
 //******************************************************************************
 void ReturnCode::setFapiError(const ReturnCodes i_rcValue)
diff --git a/src/usr/hwpf/fapi/fapiTarget.C b/src/usr/hwpf/fapi/fapiTarget.C
index 71de0c95b..9546f3d23 100644
--- a/src/usr/hwpf/fapi/fapiTarget.C
+++ b/src/usr/hwpf/fapi/fapiTarget.C
@@ -1,26 +1,25 @@
-/*  IBM_PROLOG_BEGIN_TAG
- *  This is an automatically generated prolog.
- *
- *  $Source: src/usr/hwpf/fapi/fapiTarget.C $
- *
- *  IBM CONFIDENTIAL
- *
- *  COPYRIGHT International Business Machines Corp. 2011-2012
- *
- *  p1
- *
- *  Object Code Only (OCO) source materials
- *  Licensed Internal Code Source Materials
- *  IBM HostBoot Licensed Internal Code
- *
- *  The source code for this program is not published or other-
- *  wise divested of its trade secrets, irrespective of what has
- *  been deposited with the U.S. Copyright Office.
- *
- *  Origin: 30
- *
- *  IBM_PROLOG_END_TAG
- */
+/* IBM_PROLOG_BEGIN_TAG                                                   */
+/* This is an automatically generated prolog.                             */
+/*                                                                        */
+/* $Source: src/usr/hwpf/fapi/fapiTarget.C $                              */
+/*                                                                        */
+/* IBM CONFIDENTIAL                                                       */
+/*                                                                        */
+/* COPYRIGHT International Business Machines Corp. 2011,2012              */
+/*                                                                        */
+/* p1                                                                     */
+/*                                                                        */
+/* Object Code Only (OCO) source materials                                */
+/* Licensed Internal Code Source Materials                                */
+/* IBM HostBoot Licensed Internal Code                                    */
+/*                                                                        */
+/* The source code for this program is not published or otherwise         */
+/* divested of its trade secrets, irrespective of what has been           */
+/* deposited with the U.S. Copyright Office.                              */
+/*                                                                        */
+/* Origin: 30                                                             */
+/*                                                                        */
+/* IBM_PROLOG_END_TAG                                                     */
 /**
  *  @file fapiTarget.C
  *
@@ -123,14 +122,6 @@ bool Target::operator!=(const Target & i_right) const
 }
 
 //******************************************************************************
-// Get the handle.
-//******************************************************************************
-void * Target::get() const
-{
-    return iv_pHandle;
-}
-
-//******************************************************************************
 // Set the handle.
 //******************************************************************************
 void Target::set(void * i_pHandle)
@@ -141,22 +132,6 @@ void Target::set(void * i_pHandle)
 }
 
 //******************************************************************************
-// Get the target type
-//******************************************************************************
-TargetType Target::getType() const
-{
-    return iv_type;
-}
-
-//******************************************************************************
-// Set the target type
-//******************************************************************************
-void Target::setType(const TargetType i_type)
-{
-    iv_type = i_type;
-}
-
-//******************************************************************************
 // Is the target a chip?
 //******************************************************************************
 bool Target::isChip() const
diff --git a/src/usr/targeting/common/entitypath.C b/src/usr/targeting/common/entitypath.C
index af1c30ff8..46ba7d88a 100644
--- a/src/usr/targeting/common/entitypath.C
+++ b/src/usr/targeting/common/entitypath.C
@@ -1,26 +1,25 @@
-//  IBM_PROLOG_BEGIN_TAG
-//  This is an automatically generated prolog.
-//
-//  $Source: src/usr/targeting/entitypath.C $
-//
-//  IBM CONFIDENTIAL
-//
-//  COPYRIGHT International Business Machines Corp. 2011
-//
-//  p1
-//
-//  Object Code Only (OCO) source materials
-//  Licensed Internal Code Source Materials
-//  IBM HostBoot Licensed Internal Code
-//
-//  The source code for this program is not published or other-
-//  wise divested of its trade secrets, irrespective of what has
-//  been deposited with the U.S. Copyright Office.
-//
-//  Origin: 30
-//
-//  IBM_PROLOG_END
-
+/* IBM_PROLOG_BEGIN_TAG                                                   */
+/* This is an automatically generated prolog.                             */
+/*                                                                        */
+/* $Source: src/usr/targeting/common/entitypath.C $                       */
+/*                                                                        */
+/* IBM CONFIDENTIAL                                                       */
+/*                                                                        */
+/* COPYRIGHT International Business Machines Corp. 2011,2012              */
+/*                                                                        */
+/* p1                                                                     */
+/*                                                                        */
+/* Object Code Only (OCO) source materials                                */
+/* Licensed Internal Code Source Materials                                */
+/* IBM HostBoot Licensed Internal Code                                    */
+/*                                                                        */
+/* The source code for this program is not published or otherwise         */
+/* divested of its trade secrets, irrespective of what has been           */
+/* deposited with the U.S. Copyright Office.                              */
+/*                                                                        */
+/* Origin: 30                                                             */
+/*                                                                        */
+/* IBM_PROLOG_END_TAG                                                     */
 /**
  *  @file targeting/common/entitypath.C
  *
@@ -84,17 +83,6 @@ EntityPath::EntityPath()
 }
 
 //******************************************************************************
-// EntityPath::~EntityPath
-//******************************************************************************
-
-EntityPath::~EntityPath()
-{
-    #define TARG_FN "~EntityPath()"
-
-    #undef TARG_FN
-}
-
-//******************************************************************************
 // EntityPath::removeLast
 //******************************************************************************
 
@@ -262,19 +250,6 @@ const EntityPath::PathElement EntityPath::pathElementOfType(
 }
 
 //******************************************************************************
-// EntityPath::size
-//******************************************************************************
-
-uint32_t EntityPath::size() const
-{
-    #define TARG_FN "size()"
-
-    return iv_size;
-
-    #undef TARG_FN
-}
-
-//******************************************************************************
 // EntityPath::setType
 //******************************************************************************
 
@@ -289,19 +264,6 @@ void EntityPath::setType(
 }
 
 //******************************************************************************
-// EntityPath::type
-//******************************************************************************
-
-EntityPath::PATH_TYPE EntityPath::type() const
-{
-    #define TARG_FN "type()"
-
-    return iv_type;
-
-    #undef TARG_FN
-}
-
-//******************************************************************************
 // EntityPath::pathTypeAsString (DEBUG)
 //******************************************************************************