summaryrefslogtreecommitdiffstats
path: root/src/usr/xscom
diff options
context:
space:
mode:
authorDan Crowell <dcrowell@us.ibm.com>2014-03-10 13:46:58 -0500
committerA. Patrick Williams III <iawillia@us.ibm.com>2014-03-13 14:47:57 -0500
commit188fe8cdfebd50988713b70ca5d85e0172902ed1 (patch)
treed972a8f0bd541d574cffd8d1708a87d75a4900f8 /src/usr/xscom
parentc45f4eb0cea9778f0f7de084e0b15043d97a79b0 (diff)
downloadtalos-hostboot-188fe8cdfebd50988713b70ca5d85e0172902ed1.tar.gz
talos-hostboot-188fe8cdfebd50988713b70ca5d85e0172902ed1.zip
Make XSCOM errors unrecoverable
Change-Id: Ibdeab50c5730ab5d6e0773cec180b44fcf2f05c8 CQ: SW250922 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/9453 Tested-by: Jenkins Server Reviewed-by: Douglas R. Gilbert <dgilbert@us.ibm.com> Reviewed-by: Michael Baiocchi <baiocchi@us.ibm.com> Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr/xscom')
-rw-r--r--src/usr/xscom/piberror.C4
-rw-r--r--src/usr/xscom/xscom.C4
2 files changed, 6 insertions, 2 deletions
diff --git a/src/usr/xscom/piberror.C b/src/usr/xscom/piberror.C
index 498d36991..3b1a2e9f5 100644
--- a/src/usr/xscom/piberror.C
+++ b/src/usr/xscom/piberror.C
@@ -100,6 +100,10 @@ void addFruCallouts(TARGETING::Target* i_target,
break;
default:
+ // should never commit a log that gets here so that is a
+ // code bug
+ io_errl->addProcedureCallout(HWAS::EPUB_PRC_HB_CODE,
+ HWAS::SRCI_PRIORITY_HIGH);
break;
}
diff --git a/src/usr/xscom/xscom.C b/src/usr/xscom/xscom.C
index 9b62d6f78..a2b846662 100644
--- a/src/usr/xscom/xscom.C
+++ b/src/usr/xscom/xscom.C
@@ -512,11 +512,11 @@ errlHndl_t xScomDoOp(DeviceFW::OperationType i_opType,
* @errortype
* @moduleid XSCOM_DO_OP
* @reasoncode XSCOM_STATUS_ERR
- * @userdata1 HMER value
+ * @userdata1 HMER value (piberr in bits 21:23)
* @userdata2 XSCom address
* @devdesc XSCom access error
*/
- l_err = new ERRORLOG::ErrlEntry(ERRORLOG::ERRL_SEV_INFORMATIONAL,
+ l_err = new ERRORLOG::ErrlEntry(ERRORLOG::ERRL_SEV_UNRECOVERABLE,
XSCOM_DO_OP,
XSCOM_STATUS_ERR,
io_hmer,
OpenPOWER on IntegriCloud