diff options
| author | Christian Geddes <crgeddes@us.ibm.com> | 2018-02-20 14:30:47 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-02-24 21:16:20 -0500 |
| commit | c5983ddc358548ca4b9bb563cfd1d68c92f54a30 (patch) | |
| tree | b26c3c2edca04398c61f5888ca3b5332fc3076c9 /src/usr/util/runtime/rt_fwnotify.C | |
| parent | 8ea7d7ed5db4ce693fa5b261a2edd567681334d3 (diff) | |
| download | talos-hostboot-c5983ddc358548ca4b9bb563cfd1d68c92f54a30.tar.gz talos-hostboot-c5983ddc358548ca4b9bb563cfd1d68c92f54a30.zip | |
Skip attempting sbe_retry when HBRT receives SBE_ERR from HWSV
Because there are some errors in the SBE_RETRY handling path we
will skip attemptin the retry for now and just respond that we failed
to recover. This will allow HWSV to perform the dump they want.
Change-Id: Ia49b6f2a7871ca9e754b6bfd7c3ad0db2eac512b
CQ: SW418111
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/54443
CI-Ready: Daniel M. Crowell <dcrowell@us.ibm.com>
CI-Ready: Roland Veloz <rveloz@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/util/runtime/rt_fwnotify.C')
| -rw-r--r-- | src/usr/util/runtime/rt_fwnotify.C | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/src/usr/util/runtime/rt_fwnotify.C b/src/usr/util/runtime/rt_fwnotify.C index 2db519939..612720edf 100644 --- a/src/usr/util/runtime/rt_fwnotify.C +++ b/src/usr/util/runtime/rt_fwnotify.C @@ -132,17 +132,19 @@ void sbeAttemptRecovery(uint64_t i_data) break; } + + // Get the recovery results + // TODO SW415675 Need to attempt sbe retry if requested // Get the SBE Retry Handler, propagating the supplied PLID - SbeRetryHandler l_SBEobj = SbeRetryHandler(SbeRetryHandler:: - SBE_MODE_OF_OPERATION::INFORMATIONAL_ONLY, - l_sbeRetryData->plid); +// SbeRetryHandler l_SBEobj = SbeRetryHandler(SbeRetryHandler:: +// SBE_MODE_OF_OPERATION::INFORMATIONAL_ONLY, +// l_sbeRetryData->plid); // Retry the recovery of the SBE - l_SBEobj.main_sbe_handler(l_target); - - // Get the recovery results - bool l_recoverySuccessful = l_SBEobj.getSbeRestart(); +// l_SBEobj.main_sbe_handler(l_target); +// //bool l_recoverySuccessful = l_SBEobj.getSbeRestart(); + bool l_recoverySuccessful = false; if (nullptr == g_hostInterfaces || nullptr == g_hostInterfaces->firmware_request) { @@ -177,7 +179,7 @@ void sbeAttemptRecovery(uint64_t i_data) // Populate the firmware_request request struct with given data l_req_fw_msg.io_type = hostInterfaces::HBRT_FW_MSG_HBRT_FSP_REQ; - l_req_fw_msg.generic_msg.msgq = GenericFspMboxMessage_t::MSG_SBE_ERROR; + l_req_fw_msg.generic_msg.msgq = GenericFspMboxMessage_t::FSP_HBRT_MESSAGEQ; l_req_fw_msg.generic_msg.__req = GenericFspMboxMessage_t::REQUEST; l_req_fw_msg.generic_msg.data = i_data; |
