summaryrefslogtreecommitdiffstats
path: root/src/usr/targeting/common
diff options
context:
space:
mode:
authorDean Sanner <dsanner@us.ibm.com>2019-07-22 12:54:40 -0500
committerDaniel M Crowell <dcrowell@us.ibm.com>2019-07-24 11:45:09 -0500
commit449d1fabb3739fa89fe31717c028f5e2855aa163 (patch)
tree41318d9e5f39b066a6ad90a7e393faa67e77cdcd /src/usr/targeting/common
parent6b03894470e30343885917d3db131b091ef6e7c7 (diff)
downloadtalos-hostboot-449d1fabb3739fa89fe31717c028f5e2855aa163.tar.gz
talos-hostboot-449d1fabb3739fa89fe31717c028f5e2855aa163.zip
Fix bug in attribute sync
Deserialization pointer was getting double updated. This commit fixes Change-Id: I41f38633f057bcda93f0ed35500dce034cf55425 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80777 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Zachary Clark <zach@ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/targeting/common')
-rw-r--r--src/usr/targeting/common/attributeTank.C5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/usr/targeting/common/attributeTank.C b/src/usr/targeting/common/attributeTank.C
index a9718b789..0d8db2867 100644
--- a/src/usr/targeting/common/attributeTank.C
+++ b/src/usr/targeting/common/attributeTank.C
@@ -443,15 +443,12 @@ void AttributeTank::deserializeAttributes(
// Iterate thru the Attributes
while (l_index < i_attributes.iv_size)
{
- // Progress the offset to the serialized data
- l_serializedData += l_index;
-
// Create a new Attribute
Attribute * l_pAttribute = new Attribute();
// Deserialize the data, if possible
uint32_t l_deserializedDataSize = l_pAttribute->deserialize(
- l_serializedData,
+ l_serializedData + l_index,
i_attributes.iv_size - l_index);
if (!l_deserializedDataSize)
OpenPOWER on IntegriCloud