diff options
author | Dan Crowell <dcrowell@us.ibm.com> | 2019-01-28 10:20:43 -0600 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-01-29 16:01:32 -0600 |
commit | f6b8ae93833ca00cdf97864d44393c688212be4d (patch) | |
tree | 0f76ff2253dcd07cddfe3d36e38c96684ae84c1f /src/usr/targeting/common/xmltohb/attribute_types.xml | |
parent | 5b03768f4279a7f5252baf89a767d7431f56efb7 (diff) | |
download | talos-hostboot-f6b8ae93833ca00cdf97864d44393c688212be4d.tar.gz talos-hostboot-f6b8ae93833ca00cdf97864d44393c688212be4d.zip |
Do not gard cores on the initial core wakeup failure
We have seen rare (but non-zero) errors during slave core wakeup
where we never see the new core reporting in. Currently this
will result in a visible log and a core gard. However, there is
currently no indication this failure is actually due to bad
hardware.
As a workaround, this commit adds an indicator that keeps track
of if a core has failed wakeup previously. The first time we
encounter the error there will be a visible log with a FW callout
and no deconfig or gard of the core. That will trigger a boot
failure and a reboot. If we don't fail on the next boot (which
is expected), the counter will be cleared. If we do fail again
there will be a visible log (with a new SRC) that calls out the
core as the primary cause, plus does a deconfig+gard.
Change-Id: I3a25537cf9c9c8e0b679519b67e9ae4e3492736d
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/70992
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/targeting/common/xmltohb/attribute_types.xml')
-rw-r--r-- | src/usr/targeting/common/xmltohb/attribute_types.xml | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/src/usr/targeting/common/xmltohb/attribute_types.xml b/src/usr/targeting/common/xmltohb/attribute_types.xml index c31202b92..d75aaca3d 100644 --- a/src/usr/targeting/common/xmltohb/attribute_types.xml +++ b/src/usr/targeting/common/xmltohb/attribute_types.xml @@ -5808,6 +5808,25 @@ </attribute> <attribute> + <description> + Tracks if a specific core has previously experienced a timeout during + initial activation. + 0 = No previous errors reported; + 1 = Core failed on the last attempt to be started + </description> + <id>PREVIOUS_WAKEUP_FAIL</id> + <persistency>non-volatile</persistency> + <readable/> + <writeable/> + <simpleType> + <uint8_t> + <default>0</default> + </uint8_t> + </simpleType> + <no_export/> + </attribute> + + <attribute> <complexType> <description>Structure which defines a target's primary capabilities. A target can only support at most FSI SCOM and one of the other two SCOM |