diff options
| author | Elizabeth Liner <eliner@us.ibm.com> | 2018-02-09 15:03:02 -0600 |
|---|---|---|
| committer | William G. Hoffa <wghoffa@us.ibm.com> | 2018-02-27 13:05:58 -0500 |
| commit | 8f1ef46890d9d53df652cfa823f310adae39d47f (patch) | |
| tree | 5a6a5f18d8e726eb43670cc1fcc46c0c11dce63a /src/usr/sbeio | |
| parent | fed203b290c12b7b634c04eeec2b95fc496a726f (diff) | |
| download | talos-hostboot-8f1ef46890d9d53df652cfa823f310adae39d47f.tar.gz talos-hostboot-8f1ef46890d9d53df652cfa823f310adae39d47f.zip | |
Adding visible error once we know that the SBE is erroring
There is a path of the sbe_retry_handler that is missing a
visible error (Once we realize that there is an issue with the
SBE, and we're attempting a boot). This commit adds in that change
Change-Id: Ia613d0b5210aec7bfa923f565d3f57192e585361
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53774
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
CI-Ready: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Diffstat (limited to 'src/usr/sbeio')
| -rw-r--r-- | src/usr/sbeio/common/sbe_retry_handler.C | 31 |
1 files changed, 29 insertions, 2 deletions
diff --git a/src/usr/sbeio/common/sbe_retry_handler.C b/src/usr/sbeio/common/sbe_retry_handler.C index ed7bfb11d..e2889bf16 100644 --- a/src/usr/sbeio/common/sbe_retry_handler.C +++ b/src/usr/sbeio/common/sbe_retry_handler.C @@ -880,10 +880,37 @@ bool SbeRetryHandler::sbe_boot_fail_handler(TARGETING::Target * i_target, SBE_TRACF("p9_extract_sbe_rc HWP returned action %d and errorlog " "PLID=0x%x, rc=0x%.4X", this->iv_currentAction, l_errl->plid(), l_errl->reasonCode() ); - delete l_errl; - l_errl = nullptr; + errlCommit(l_errl, SBEIO_COMP_ID); } + SBE_TRACF("sbe_boot_fail_handler: We have hit an error in the SBE " + "and hostboot will now attempt to reboot the SBE"); + /*@ + * @errortype + * @severity ERRORLOG::ERRL_SEV_PREDICTIVE + * @moduleid SBEIO_EXTRACT_RC_HANDLER + * @reasoncode SBEIO_ATTEMPTING_REBOOT + * @userdata1 HUID of proc which had the SBE timeout + * @userdata2 Current action to be taken on the SBE + * @devdesc HWP has returned a reboot action to be taken + * Hostboot will now attempt to reboot the SBE + * @custdesc A processor in the system has failed to initialize. + * Hostboot is attempting a recovery. + */ + l_errl = new ERRORLOG::ErrlEntry(ERRORLOG::ERRL_SEV_PREDICTIVE, + SBEIO_EXTRACT_RC_HANDLER, + SBEIO_ATTEMPTING_REBOOT, + TARGETING::get_huid(i_target), + this->iv_currentAction); + l_errl->collectTrace("SBEIO_TRACE",KILOBYTE/4); + + // Set the PLID of the error log to caller's PLID if provided + if(iv_callerErrorLogPLID) + { + l_errl->plid(iv_callerErrorLogPLID); + } + errlCommit(l_errl,SBEIO_COMP_ID); + if(INITSERVICE::spBaseServicesEnabled()) { #ifndef __HOSTBOOT_RUNTIME |
