diff options
| author | Christian Geddes <crgeddes@us.ibm.com> | 2018-03-14 18:26:16 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-04-06 10:15:43 -0400 |
| commit | ba8c8bfc02ca3d42a3caf3f8f797df07487c1dab (patch) | |
| tree | b0d8d1a4797b787a3b1194f5198746d4bd92c874 /src/usr/sbeio/test | |
| parent | 02f8995967cc97988cf3cdb40b1805915517bbaf (diff) | |
| download | talos-hostboot-ba8c8bfc02ca3d42a3caf3f8f797df07487c1dab.tar.gz talos-hostboot-ba8c8bfc02ca3d42a3caf3f8f797df07487c1dab.zip | |
sbe_retry_handler refactor
Previously the sbe_retry_handler had logic and wording that
assumed that it was being used to tell if the slave sbe booted or not.
However this code has many more use cases then that. Also there was some
indirect recursion that made the code hard to follow. With this refactor
the code should be easier to follow and the vocabulary used should be more
generic.
Change-Id: If6520197b3dd561857e336ed89d9356c1f2601d6
CQ: SW416106
RTC: 167191
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/55896
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Tested-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/sbeio/test')
| -rw-r--r-- | src/usr/sbeio/test/sbe_retry_handler_test.H | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/usr/sbeio/test/sbe_retry_handler_test.H b/src/usr/sbeio/test/sbe_retry_handler_test.H index bfe6808d7..9a3719895 100644 --- a/src/usr/sbeio/test/sbe_retry_handler_test.H +++ b/src/usr/sbeio/test/sbe_retry_handler_test.H @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2017 */ +/* Contributors Listed Below - COPYRIGHT 2017,2018 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -125,12 +125,12 @@ class SbeRetryHandlerTest : public CxxTest::TestSuite uint32_t l_sbeStarted = l_cpu_target->getAttr< TARGETING::ATTR_SBE_IS_STARTED>(); - if(l_SBEobj.getSbeRestart() && !l_sbeStarted) + if(l_SBEobj.isSbeAtRuntime() && !l_sbeStarted) { TS_FAIL("testSBEStarted: If the class element that " "the SBE started is true, then the SBE attribute also " "needs to be true"); - }else if(!(l_SBEobj.getSbeRestart() && l_sbeStarted)) + }else if(!(l_SBEobj.isSbeAtRuntime() && l_sbeStarted)) { TS_FAIL("testSBEStarted: If the class element " "that the SBE started is false, then the SBE attribute " |
