diff options
| author | Christian Geddes <crgeddes@us.ibm.com> | 2018-09-11 12:48:27 -0500 |
|---|---|---|
| committer | William G. Hoffa <wghoffa@us.ibm.com> | 2018-09-12 16:19:13 -0500 |
| commit | 192ca8aa60bd0f568f0ec40d58294b761665d91e (patch) | |
| tree | 36ce476d212a21d4236a1451b252b472c4107e04 /src/usr/sbeio/sbe_psudd.C | |
| parent | 7c5afbddbf0a3f795ad8404319e09a3ff00b11b8 (diff) | |
| download | talos-hostboot-192ca8aa60bd0f568f0ec40d58294b761665d91e.tar.gz talos-hostboot-192ca8aa60bd0f568f0ec40d58294b761665d91e.zip | |
Ensure we collect PPE trace if psu op times out
There was a bug in the code where if we are running on a FSP system
in simics we will not run the magic instruction to capture PPE trace
at the time of the psu op timeout. This commit insures we will call
sbe-trace and save the simics console output to file for later debug
this will help with the defect listed in this commit.
Change-Id: I7caa776f06197f7732a5dcabdcc01a3b91cdfba3
CQ: SW444734
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65992
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Diffstat (limited to 'src/usr/sbeio/sbe_psudd.C')
| -rw-r--r-- | src/usr/sbeio/sbe_psudd.C | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/usr/sbeio/sbe_psudd.C b/src/usr/sbeio/sbe_psudd.C index 35fd841eb..ab53d0d3e 100644 --- a/src/usr/sbeio/sbe_psudd.C +++ b/src/usr/sbeio/sbe_psudd.C @@ -780,6 +780,10 @@ errlHndl_t SbePsu::pollForPsuComplete(TARGETING::Target * i_target, } psuResponse* l_resp = reinterpret_cast<psuResponse*>(l_respRegs); + // Collect SBE traces in simics + MAGIC_INST_GET_SBE_TRACES(i_target->getAttr<TARGETING::ATTR_POSITION>(), + SBEIO_PSU_RESPONSE_TIMEOUT); + if(!(l_resp->primaryStatus & SBE_PRI_FFDC_ERROR)) { SBE_TRACF("Error: PSU Timeout and no FFDC present"); @@ -912,10 +916,6 @@ errlHndl_t SbePsu::pollForPsuComplete(TARGETING::Target * i_target, l_errl->collectTrace(SBEIO_COMP_NAME); } - MAGIC_INST_GET_SBE_TRACES( - i_target->getAttr<TARGETING::ATTR_POSITION>(), - SBEIO_PSU_RESPONSE_TIMEOUT); - break; } |
