diff options
author | Dan Crowell <dcrowell@us.ibm.com> | 2014-01-07 09:30:51 -0600 |
---|---|---|
committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2014-01-10 16:19:14 -0600 |
commit | aa83ebd12d6cf6d6ead06e45ab61d46a53a15be3 (patch) | |
tree | d6a587a8582ac9d085b08e028c757a0ea94bb825 /src/usr/runtime/tce.C | |
parent | ea2a49ff0cd3827458025f75d5b6bd7054d18779 (diff) | |
download | talos-hostboot-aa83ebd12d6cf6d6ead06e45ab61d46a53a15be3.tar.gz talos-hostboot-aa83ebd12d6cf6d6ead06e45ab61d46a53a15be3.zip |
Remove leftover fixme/todo and update error callouts
Remove all untagged fixme/todo comments
Adde new parm to error log constructor to avoid extra code in
common software error case
Update error callouts
Add strncpy
Change-Id: I8bd8f48193a96b79db91ed35c4fd485e6da38dba
RTC: 67921
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/7921
Tested-by: Jenkins Server
Reviewed-by: Michael Baiocchi <baiocchi@us.ibm.com>
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr/runtime/tce.C')
-rw-r--r-- | src/usr/runtime/tce.C | 48 |
1 files changed, 29 insertions, 19 deletions
diff --git a/src/usr/runtime/tce.C b/src/usr/runtime/tce.C index 619364671..493d8146c 100644 --- a/src/usr/runtime/tce.C +++ b/src/usr/runtime/tce.C @@ -5,7 +5,7 @@ /* */ /* IBM CONFIDENTIAL */ /* */ -/* COPYRIGHT International Business Machines Corp. 2013 */ +/* COPYRIGHT International Business Machines Corp. 2013,2014 */ /* */ /* p1 */ /* */ @@ -39,7 +39,7 @@ #include <assert.h> trace_desc_t* g_trac_tce = NULL; -TRAC_INIT(&g_trac_tce, "TCE", 4*KILOBYTE); +TRAC_INIT(&g_trac_tce, TCE_TRACE_NAME, 4*KILOBYTE); namespace TCE @@ -145,8 +145,8 @@ namespace TCE RUNTIME::MOD_TCE_MAP, RUNTIME::RC_TCE_INVALID_SIZE, tceTablePhysAddr, - tceTableSize); - + tceTableSize, + true /*Add HB SW Callout*/); break; } @@ -170,8 +170,8 @@ namespace TCE RUNTIME::MOD_TCE_MAP, RUNTIME::RC_TCE_ADDR_NOT_ALIGNED, tceTablePhysAddr, - 0); - + 0, + true /*Add HB SW Callout*/); break; } @@ -211,7 +211,8 @@ namespace TCE RUNTIME::MOD_TCE_MAP, RUNTIME::RC_TCE_DEV_MAP_FAIL, tceTablePhysAddr, - tceTableSize); + tceTableSize, + true /*Add HB SW Callout*/); } } }while(0); @@ -323,7 +324,8 @@ namespace TCE RUNTIME::MOD_TCE_INIT_HDW, RUNTIME::RC_TCE_DEV_MAP_FAIL, PsiBridgeAddr, - tceTablePhysAddr); + tceTablePhysAddr, + true /*Add HB SW Callout*/); break; } @@ -371,7 +373,8 @@ namespace TCE RUNTIME::MOD_TCE_INIT_HDW, RUNTIME::RC_TCE_DEV_UNMAP_FAIL, reinterpret_cast<uint64_t>(mmio_ptr), - rc); + rc, + true /*Add HB SW Callout*/); break; } @@ -439,7 +442,9 @@ namespace TCE RUNTIME::MOD_TCE_ALLOCATE, RUNTIME::RC_TCE_INIT_NOT_RUN, i_startingAddress, - i_size); + i_size, + true /*Add HB SW Callout*/); + errl->collectTrace(TCE_TRACE_NAME,KILOBYTE); break; } @@ -480,8 +485,8 @@ namespace TCE RUNTIME::MOD_TCE_ALLOCATE, RUNTIME::RC_TCE_ADDR_NOT_ALIGNED, i_startingAddress, - i_size); - + i_size, + true /*Add HB SW Callout*/); break; } @@ -506,7 +511,8 @@ namespace TCE RUNTIME::MOD_TCE_ALLOCATE, RUNTIME::RC_TCE_INVALID_SIZE, i_startingAddress, - i_size); + i_size, + true /*Add HB SW Callout*/); break; } @@ -612,8 +618,9 @@ namespace TCE RUNTIME::MOD_TCE_ALLOCATE, RUNTIME::RC_TCE_NOT_ENOUGH_FREE_ENTRIES, i_startingAddress, - i_size); - + i_size, + true /*Add HB SW Callout*/); + break; } }while(0); @@ -673,7 +680,9 @@ namespace TCE RUNTIME::MOD_TCE_DEALLOCATE, RUNTIME::RC_TCE_INVALID_SIZE, startingIndex, - numTcesNeeded); + numTcesNeeded, + true /*Add HB SW Callout*/); + errl->collectTrace(TCE_TRACE_NAME,KILOBYTE); errlCommit(errl,RUNTIME_COMP_ID); @@ -731,10 +740,11 @@ namespace TCE RUNTIME::MOD_TCE_DEALLOCATE, RUNTIME::RC_TCE_ENTRY_NOT_CONTIGUOUS, i_startingToken, - i_size); - + i_size, + true /*Add HB SW Callout*/); + errl->collectTrace(TCE_TRACE_NAME,KILOBYTE); errlCommit(errl,RUNTIME_COMP_ID); - + break; } }while(0); |