Turn InitService::doShutdown into a NO_RETURN

    There are a few places outside of initservice where Hostboot
    shutdown needs to be called.  Currently the doShutdown returns
    so each of these places have a while(1); style loop.  In the
    case of start_payload, their implementation of this loop was
    incorrect and causes us to take longer than desired to actually
    shutdown.

    I have changed doShutdown into a NO_RETURN function that keeps
    the correct loop done in a common way.

    See defect SW183911 for more background.

Change-Id: I819eecadcddd2436f1c52571e48258316b43f38c
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/3028
Tested-by: Jenkins Server
Reviewed-by: ADAM R. MUHLE <armuhle@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>

1 files changed, 0 insertions, 2 deletions

diff --git a/src/usr/pnor/pnorrp.C b/src/usr/pnor/pnorrp.C
index 03159fb15..974f91d3a 100644
--- a/src/usr/pnor/pnorrp.C
+++ b/src/usr/pnor/pnorrp.C
@@ -425,7 +425,6 @@ errlHndl_t PnorRP::readTOC()
         {
             //Shutdown if we detected a partition table issue for any reason
             INITSERVICE::doShutdown( PNOR::RC_PARTITION_TABLE_INVALID);
-            while(1) { task_yield(); }
         }
 
         ffs_hb_user_t* ffsUserData = NULL;
@@ -492,7 +491,6 @@ errlHndl_t PnorRP::readTOC()
                 TRACFCOMP(g_trac_pnor, "E>PnorRp::readTOC:  Partition(%s) at base address (0x%.8x) extends past end of flash device",
                           cur_entry->name, iv_TOC[cur_side][secId].flashAddr);
                 INITSERVICE::doShutdown( PNOR::RC_PARTITION_TABLE_INVALID);
-                while(1) { task_yield(); }
             }
 
             cur_entry++;