diff options
| author | Dan Crowell <dcrowell@us.ibm.com> | 2014-01-07 09:30:51 -0600 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2014-01-10 16:19:14 -0600 |
| commit | aa83ebd12d6cf6d6ead06e45ab61d46a53a15be3 (patch) | |
| tree | d6a587a8582ac9d085b08e028c757a0ea94bb825 /src/usr/pnor/pnordd.C | |
| parent | ea2a49ff0cd3827458025f75d5b6bd7054d18779 (diff) | |
| download | talos-hostboot-aa83ebd12d6cf6d6ead06e45ab61d46a53a15be3.tar.gz talos-hostboot-aa83ebd12d6cf6d6ead06e45ab61d46a53a15be3.zip | |
Remove leftover fixme/todo and update error callouts
Remove all untagged fixme/todo comments
Adde new parm to error log constructor to avoid extra code in
common software error case
Update error callouts
Add strncpy
Change-Id: I8bd8f48193a96b79db91ed35c4fd485e6da38dba
RTC: 67921
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/7921
Tested-by: Jenkins Server
Reviewed-by: Michael Baiocchi <baiocchi@us.ibm.com>
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr/pnor/pnordd.C')
| -rw-r--r-- | src/usr/pnor/pnordd.C | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/src/usr/pnor/pnordd.C b/src/usr/pnor/pnordd.C index e8bd3d738..4d67da3e0 100644 --- a/src/usr/pnor/pnordd.C +++ b/src/usr/pnor/pnordd.C @@ -5,7 +5,7 @@ /* */ /* IBM CONFIDENTIAL */ /* */ -/* COPYRIGHT International Business Machines Corp. 2011,2013 */ +/* COPYRIGHT International Business Machines Corp. 2011,2014 */ /* */ /* p1 */ /* */ @@ -722,7 +722,7 @@ errlHndl_t PnorDD::pollSfcOpComplete(uint64_t i_pollTime) if( l_err ) { break; } // check for errors or timeout - // TODO: What errors do we check? + // TODO: RTC:62718 What errors do we check? if( (sfc_stat.done == 0) ) { TRACFCOMP(g_trac_pnor, @@ -746,8 +746,8 @@ errlHndl_t PnorDD::pollSfcOpComplete(uint64_t i_pollTime) poll_time), TWO_UINT32_TO_UINT64(sfc_stat.data32,0)); - l_err->collectTrace("PNOR"); - l_err->collectTrace("XSCOM"); + l_err->collectTrace(PNOR_COMP_NAME); + l_err->collectTrace(XSCOM_COMP_NAME); //@todo (RTC:37744) - Any cleanup or recovery needed? break; } @@ -849,8 +849,8 @@ errlHndl_t PnorDD::micronFlagStatus(uint64_t i_pollTime) poll_time), TWO_UINT32_TO_UINT64(opStatus,0)); - l_err->collectTrace("PNOR"); - l_err->collectTrace("XSCOM"); + l_err->collectTrace(PNOR_COMP_NAME); + l_err->collectTrace(XSCOM_COMP_NAME); //Erase & Program error bits are sticky, so they need to be cleared. @@ -1366,8 +1366,8 @@ errlHndl_t PnorDD::readLPC(uint32_t i_addr, PNOR::RC_LPC_ERROR, TWO_UINT32_TO_UINT64(i_addr,poll_time), eccb_stat.data64); - l_err->collectTrace("PNOR"); - l_err->collectTrace("XSCOM"); + l_err->collectTrace(PNOR_COMP_NAME); + l_err->collectTrace(XSCOM_COMP_NAME); //@todo (RTC:37744) - Any cleanup or recovery needed? break; } @@ -1475,8 +1475,8 @@ errlHndl_t PnorDD::writeLPC(uint32_t i_addr, PNOR::RC_LPC_ERROR, TWO_UINT32_TO_UINT64(0,i_addr), eccb_stat.data64); - l_err->collectTrace("PNOR"); - l_err->collectTrace("XSCOM"); + l_err->collectTrace(PNOR_COMP_NAME); + l_err->collectTrace(XSCOM_COMP_NAME); //@todo (RTC:37744) - Any cleanup or recovery needed? break; } |
