summaryrefslogtreecommitdiffstats
path: root/src/usr/mbox
diff options
context:
space:
mode:
authorMike Jones <mjjones@us.ibm.com>2013-12-04 13:26:00 -0600
committerA. Patrick Williams III <iawillia@us.ibm.com>2013-12-04 14:30:21 -0600
commite7f0a7104c2ef9d825aeabcb740ba203eb0ef190 (patch)
treecb30b6eda1de1c5a5ae312619dee5e46552fdcdf /src/usr/mbox
parente78b6592dea62686cc755c2b2e5fd06a842527d3 (diff)
downloadtalos-hostboot-e7f0a7104c2ef9d825aeabcb740ba203eb0ef190.tar.gz
talos-hostboot-e7f0a7104c2ef9d825aeabcb740ba203eb0ef190.zip
Race condition in mailbox leads to MSG_INITIAL_DMA being dropped
Change-Id: Ia7d525a7757c4721a2771ffdd2c0be4272346157 RTC: 92838 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/7532 Reviewed-by: Andrew J. Geissler <andrewg@us.ibm.com> Reviewed-by: Douglas R. Gilbert <dgilbert@us.ibm.com> Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com> Tested-by: Jenkins Server
Diffstat (limited to 'src/usr/mbox')
-rw-r--r--src/usr/mbox/mailboxsp.C5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/usr/mbox/mailboxsp.C b/src/usr/mbox/mailboxsp.C
index 791919323..2add8a16e 100644
--- a/src/usr/mbox/mailboxsp.C
+++ b/src/usr/mbox/mailboxsp.C
@@ -171,6 +171,9 @@ errlHndl_t MailboxSp::_init()
if(mbxComm)
{
+ // Enable the mailbox
+ iv_disabled = false;
+
// Send message to FSP on base DMA buffer zone
msg_t * msg = msg_allocate();
msg->type = MSG_INITIAL_DMA;
@@ -183,8 +186,6 @@ errlHndl_t MailboxSp::_init()
INITSERVICE::registerShutdownEvent(iv_msgQ,
MSG_MBOX_SHUTDOWN,
INITSERVICE::MBOX_PRIORITY);
-
- iv_disabled = false;
}
// else leave iv_disabled as true;
OpenPOWER on IntegriCloud