diff options
| author | Matt Ploetz <maploetz@us.ibm.com> | 2017-03-07 17:22:09 -0600 |
|---|---|---|
| committer | William G. Hoffa <wghoffa@us.ibm.com> | 2017-03-30 12:59:22 -0400 |
| commit | 3c6ce44ffcb6ae2289535f9d036902d30fac3669 (patch) | |
| tree | 51c6076ff20b1f4fdb22fed219df5736edf80977 /src/usr/isteps | |
| parent | 7e53643075803b2654bebec85f693c90d1b503f6 (diff) | |
| download | talos-hostboot-3c6ce44ffcb6ae2289535f9d036902d30fac3669.tar.gz talos-hostboot-3c6ce44ffcb6ae2289535f9d036902d30fac3669.zip | |
Remove unused attributes in processMrw and computeProcPcieConfigAttrs
Change-Id: I7d84e2bef86ec17acc722f4ec9c9c19341d29ac8
RTC:160422
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/37640
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Prachi Gupta <pragupta@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Diffstat (limited to 'src/usr/isteps')
| -rw-r--r-- | src/usr/isteps/istep08/host_proc_pcie_scominit.C | 31 |
1 files changed, 12 insertions, 19 deletions
diff --git a/src/usr/isteps/istep08/host_proc_pcie_scominit.C b/src/usr/isteps/istep08/host_proc_pcie_scominit.C index d1825cb5d..aa498962f 100644 --- a/src/usr/isteps/istep08/host_proc_pcie_scominit.C +++ b/src/usr/isteps/istep08/host_proc_pcie_scominit.C @@ -551,20 +551,10 @@ errlHndl_t computeProcPcieConfigAttrs(TARGETING::Target * i_pProcChipTarget) laneMaskNonBifurcated),"Failed to get " "ATTR_PEC_PCIE_LANE_MASK_NON_BIFURCATED attribute"); - TARGETING::ATTR_PEC_PCIE_IOP_REVERSAL_NON_BIFURCATED_type - laneReversalNonBifurcated = {0}; - assert(l_pec->tryGetAttr< - TARGETING::ATTR_PEC_PCIE_IOP_REVERSAL_NON_BIFURCATED>( - laneReversalNonBifurcated),"Failed to get " - "ATTR_PEC_PCIE_IOP_REVERSAL_NON_BIFURCATED attribute"); memcpy(effectiveLaneMask,laneMaskNonBifurcated, sizeof(effectiveLaneMask)); - memcpy(effectiveLaneReversal,laneReversalNonBifurcated, - sizeof(effectiveLaneReversal)); - - #ifdef DYNAMIC_BIFURCATION TARGETING::ATTR_PEC_PCIE_LANE_MASK_BIFURCATED_type laneMaskBifurcated = {0}; @@ -626,15 +616,18 @@ errlHndl_t computeProcPcieConfigAttrs(TARGETING::Target * i_pProcChipTarget) // TODO: Dynamic Bifurcation - For future partner development // Only set if dynamic bifurcation and we need to re-compute - // the swap setting + // the swap and reversal setting l_pec->setAttr< TARGETING::ATTR_PEC_PCIE_IOP_SWAP>(effectiveLaneSwap); + + l_pec->setAttr< + TARGETING::ATTR_PEC_PCIE_IOP_REVERSAL>(effectiveLaneReversal); + #endif + l_pec->setAttr< TARGETING::ATTR_PROC_PCIE_LANE_MASK>(effectiveLaneMask); - l_pec->setAttr< - TARGETING::ATTR_PEC_PCIE_IOP_REVERSAL>(effectiveLaneReversal); } else { @@ -642,16 +635,16 @@ errlHndl_t computeProcPcieConfigAttrs(TARGETING::Target * i_pProcChipTarget) TARGETING::ATTR_PROC_PCIE_LANE_MASK>(effectiveLaneMask), "Failed to get ATTR_PROC_PCIE_LANE_MASK attribute"); - assert(l_pec->tryGetAttr< - TARGETING::ATTR_PEC_PCIE_IOP_REVERSAL> - (effectiveLaneReversal), - "Failed to get ATTR_PEC_PCIE_IOP_REVERSAL attribute"); - // While we aren't using the attribute in this function, we - // should still make sure it's set + // should still make sure swap and reversal are set assert(l_pec->tryGetAttr< TARGETING::ATTR_PROC_PCIE_IOP_SWAP>(effectiveLaneSwap), "Failed to get ATTR_PROC_PCIE_IOP_SWAP attribute"); + + assert(l_pec->tryGetAttr< + TARGETING::ATTR_PEC_PCIE_IOP_REVERSAL> + (effectiveLaneReversal), + "Failed to get ATTR_PEC_PCIE_IOP_REVERSAL attribute"); } TARGETING::ATTR_PROC_PCIE_PHB_ACTIVE_type pecPhbActiveMask = 0; |
