cumulus: changes to boot simics all the way to test cases

Change-Id: Ibc62f59635db28e50197139276b9b4c6b59ccc3e
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/44768
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>

1 files changed, 31 insertions, 26 deletions

diff --git a/src/usr/isteps/istep07/call_mss_volt.C b/src/usr/isteps/istep07/call_mss_volt.C
index 3f992a87f..7e0540257 100644
--- a/src/usr/isteps/istep07/call_mss_volt.C
+++ b/src/usr/isteps/istep07/call_mss_volt.C
@@ -85,43 +85,48 @@ void* call_mss_volt( void *io_pArgs )
     TARGETING::TargetHandleList l_membufTargetList;
     getAllChips(l_membufTargetList, TYPE_MEMBUF);
 
-    std::vector< fapi2::Target<fapi2::TARGET_TYPE_MEMBUF_CHIP> > l_membufFapiTargetsList;
+    TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
+                "call_mss_volt: %d membuf targets", l_membufTargetList.size());
 
-    for(auto & l_membuf_target : l_membufTargetList)
+    if (l_membufTargetList.size() > 0)
     {
-        fapi2::Target <fapi2::TARGET_TYPE_MEMBUF_CHIP>
-                    l_membuf_fapi_target (l_membuf_target);
-
-        l_membufFapiTargetsList.push_back( l_membuf_fapi_target );
-    }
+        std::vector< fapi2::Target<fapi2::TARGET_TYPE_MEMBUF_CHIP> > l_membufFapiTargetsList;
 
-    TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
-                "Calling p9c_mss_volt on list of membuf targets");
+        for(auto & l_membuf_target : l_membufTargetList)
+        {
+            fapi2::Target <fapi2::TARGET_TYPE_MEMBUF_CHIP>
+                        l_membuf_fapi_target (l_membuf_target);
 
-    // p9c_mss_volt.C (vector of centaurs)
-    FAPI_INVOKE_HWP(l_err, p9c_mss_volt, l_membufFapiTargetsList);
+            l_membufFapiTargetsList.push_back( l_membuf_fapi_target );
+        }
 
-    // process return code
-    if ( l_err )
-    {
         TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
-                "ERROR 0x%.8X:  p9c_mss_volt HWP() failed",
-                l_err->reasonCode());
+                    "Calling p9c_mss_volt on list of membuf targets");
+
+        // p9c_mss_volt.C (vector of centaurs)
+        FAPI_INVOKE_HWP(l_err, p9c_mss_volt, l_membufFapiTargetsList);
+
+        // process return code
+        if ( l_err )
+        {
+            TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
+                    "ERROR 0x%.8X:  p9c_mss_volt HWP() failed",
+                    l_err->reasonCode());
 
-        // Create IStep error log and cross reference to error that occurred
-        l_StepError.addErrorDetails(l_err);
+            // Create IStep error log and cross reference to error that occurred
+            l_StepError.addErrorDetails(l_err);
 
-        // Commit Error
-        errlCommit( l_err, HWPF_COMP_ID );
+            // Commit Error
+            errlCommit( l_err, HWPF_COMP_ID );
+        }
+        else
+        {
+            TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
+                "SUCCESS :  p9c_mss_volt HWP");
+        }
     }
     else
     {
-        TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
-            "SUCCESS :  p9c_mss_volt HWP");
-    }
-
-    if(l_StepError.getErrorHandle() == NULL)
-    {
         TARGETING::TargetHandleList l_mcsTargetList;
         getAllChiplets(l_mcsTargetList, TYPE_MCS);