diff options
author | Christian Geddes <crgeddes@us.ibm.com> | 2019-04-26 10:02:44 -0500 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-05-01 08:42:31 -0500 |
commit | decb0b6a03b108af9f5818ebd9dc7f95b3ce342b (patch) | |
tree | 40c1b49a88e533403a1e71ae20285a7405eb6b5b /src/usr/isteps/istep07/call_mss_eff_config.C | |
parent | 7254582b9b25bcefd35981512b5857f6c0953325 (diff) | |
download | talos-hostboot-decb0b6a03b108af9f5818ebd9dc7f95b3ce342b.tar.gz talos-hostboot-decb0b6a03b108af9f5818ebd9dc7f95b3ce342b.zip |
Remove workaround setting EFF_DIMM_SIZE attribute
We were missing some functionality in the eff_config HWP that set
this attribute so we had to put a workaround in place to make sure
it was set correctly. This value should be getting read out of the
SPD during eff_config now so we can remove this workaround.
Change-Id: I373f92c0e2b2238dfac54d9ae50973ed3ff00a57
RTC: 207850
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76569
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/isteps/istep07/call_mss_eff_config.C')
-rw-r--r-- | src/usr/isteps/istep07/call_mss_eff_config.C | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/usr/isteps/istep07/call_mss_eff_config.C b/src/usr/isteps/istep07/call_mss_eff_config.C index 3f9b52371..8c6754d1b 100644 --- a/src/usr/isteps/istep07/call_mss_eff_config.C +++ b/src/usr/isteps/istep07/call_mss_eff_config.C @@ -310,10 +310,6 @@ void* call_mss_eff_config( void *io_pArgs ) const fapi2::Target <fapi2::TARGET_TYPE_MEM_PORT> l_fapi_memport_target (l_memport_target); - // TODO RTC: 207850 Remove workaround setting EFF_DIMM_SIZE when MSS has code that sets this - uint32_t l_defaultMemSize[] = {0x8, 0x0}; - FAPI_ATTR_SET(fapi2::ATTR_MEM_EFF_DIMM_SIZE, l_fapi_memport_target, l_defaultMemSize); - l_fapi_memport_targets.push_back(l_fapi_memport_target); TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace, |