diff options
| author | Andrew Jeffery <andrewrj@au1.ibm.com> | 2018-10-05 12:59:29 +0930 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-10-10 13:38:21 -0500 |
| commit | 1b481183921d9877a5693219249bb9c4cd8ccf69 (patch) | |
| tree | 85b5197eeece8bbb7b75a55c476f76bdf63e8e17 /src/usr/ipmi/ipmidd.H | |
| parent | e9ade5b4dbf715290726d24631e445ffd929c749 (diff) | |
| download | talos-hostboot-1b481183921d9877a5693219249bb9c4cd8ccf69.tar.gz talos-hostboot-1b481183921d9877a5693219249bb9c4cd8ccf69.zip | |
ipmi: IpmiDD and IpmiRP must never free resources
An IPMI-based PNOR implementation will be introduced in the future. If
it is in use (and it likely will be), then IpmiDD and IpmiRP must be
functional right up until the shutdown() syscall is invoked. This is
necessary because hostboot assumes parts of the PNOR can be paged in at
any time (though not necessarily dirtied and flushed), and IPMI is now
required to fulfil the requests.
Remove the unnecessary shutdown-related code from both classes.
Change-Id: I82276e5e12c8b917d655000a456b72a2ccacdb5f
Signed-off-by: Andrew Jeffery <andrewrj@au1.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67077
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/ipmi/ipmidd.H')
| -rw-r--r-- | src/usr/ipmi/ipmidd.H | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/src/usr/ipmi/ipmidd.H b/src/usr/ipmi/ipmidd.H index ef6ed814f..a9b8ada8c 100644 --- a/src/usr/ipmi/ipmidd.H +++ b/src/usr/ipmi/ipmidd.H @@ -107,11 +107,6 @@ class IpmiDD errlHndl_t reset(void); /** - * @brief shutdown the device driver - */ - void handleShutdown(void); - - /** * @brief Get the queue on which IpmiDD publishes hardware events * * The events on the queue are consumed by IpmiRP. This "publish" approach @@ -156,11 +151,6 @@ class IpmiDD mutex_t iv_mutex; /** - * @brief Shut down resources - */ - bool iv_shutdown_now; - - /** * @brief True if we told the RP to try a write again */ bool iv_eagains; |

