summaryrefslogtreecommitdiffstats
path: root/src/usr/initservice
diff options
context:
space:
mode:
authorChen Du <duchen@us.ibm.com>2019-01-28 15:23:17 -0600
committerDaniel M. Crowell <dcrowell@us.ibm.com>2019-03-15 10:34:40 -0500
commitc4031acbfb0525325bc61cbb353e91acd5f3cc60 (patch)
tree1b03ddbda31fd698e9ead0ad908cacef084c422d /src/usr/initservice
parent87cc9b25b008bbd84bb56208f07cfb36bd42db24 (diff)
downloadtalos-hostboot-c4031acbfb0525325bc61cbb353e91acd5f3cc60.tar.gz
talos-hostboot-c4031acbfb0525325bc61cbb353e91acd5f3cc60.zip
Dropped messages at shutdown
Mailbox is needed to send attrs to FSP but it is disabled after a shutdown request, which causes messages to be dropped. Solution is to process messages as normal, but after the shutdown is requested we then ignore all future attr messages Change-Id: I7f3cc4bea66f324ae9ab8dbffe59bf9a7a7edc87 CQ: SW448904 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/71012 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/initservice')
-rw-r--r--src/usr/initservice/istepdispatcher/istepdispatcher.C10
1 files changed, 9 insertions, 1 deletions
diff --git a/src/usr/initservice/istepdispatcher/istepdispatcher.C b/src/usr/initservice/istepdispatcher/istepdispatcher.C
index e9915aaf4..e8db88f33 100644
--- a/src/usr/initservice/istepdispatcher/istepdispatcher.C
+++ b/src/usr/initservice/istepdispatcher/istepdispatcher.C
@@ -2138,7 +2138,15 @@ void IStepDispatcher::handleIStepRequestMsg(msg_t * & io_pMsg)
// Send the potentially modified set of Attribute overrides and any
// Attributes to sync (to Cronus) to the FSP
- fapi2::theAttrOverrideSync().sendAttrOverridesAndSyncsToFsp();
+ errlHndl_t l_errl = TARGETING::AttrRP::sendAttrOverridesAndSyncs();
+
+ if (l_errl)
+ {
+ TRACFCOMP(g_trac_initsvc, ERR_MRK
+ "doIstep: send attr overrides and syncs to FSP"
+ " failed, see 0x%08X for details", l_errl->eid());
+ errlCommit(l_errl, INITSVC_COMP_ID);
+ }
// Transfer ownership of the message pointer back from iv_pIstepMsg
mutex_lock(&iv_mutex);
OpenPOWER on IntegriCloud