diff options
author | Andrew Jeffery <andrewrj@au1.ibm.com> | 2018-10-15 14:50:54 +1030 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-10-15 16:11:03 -0500 |
commit | 95165ec1e1116f5675c8410f230ecce95af86c6d (patch) | |
tree | 77bf916f2256c57324e2d9f76fc8a97adfa19867 /src/usr/initservice | |
parent | 79549236b644e839dc672aaf5964add580c6caa4 (diff) | |
download | talos-hostboot-95165ec1e1116f5675c8410f230ecce95af86c6d.tar.gz talos-hostboot-95165ec1e1116f5675c8410f230ecce95af86c6d.zip |
Revert "sio: Add test for availability - LPC error tweak"
This reverts commit 627379aeaa27e30d66ebb0aecf218708d465162c, which
incorrectly attempted to account for LPC errors during testing for SIO
absence. The broken patch interprets the OPBM status as LPCHC status and
expects an LPCHC SYNC Abnormal error, however as it's the OPBM status
that indicates the error we never hit the LPCHC error path to populate
the errl with the error RC expected by the SIO driver.
Change-Id: Ib993d4a2b9b4e5018d9273a1c82f8b5c21ec9a25
Signed-off-by: Andrew Jeffery <andrewrj@au1.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67459
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/initservice')
-rw-r--r-- | src/usr/initservice/bootconfig/bootconfig_ast2400.C | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/src/usr/initservice/bootconfig/bootconfig_ast2400.C b/src/usr/initservice/bootconfig/bootconfig_ast2400.C index 87caa32a5..c7e0a3d8b 100644 --- a/src/usr/initservice/bootconfig/bootconfig_ast2400.C +++ b/src/usr/initservice/bootconfig/bootconfig_ast2400.C @@ -212,21 +212,6 @@ errlHndl_t AST2400BootConfig::readAndProcessBootConfig() size_t l_len = sizeof(uint8_t); do { - // The BMC may have disabled SIO, in which case we use a default set of - // boot flags - bool haveSio; - l_err = SIO::isAvailable(haveSio); - if (l_err) - { - break; - } - - if (!haveSio) - { - processBootFlagsV1(0); - break; - } - // read the register holding the agreed upon magic // number to indicate registers have been configured |