diff options
| author | Dan Crowell <dcrowell@us.ibm.com> | 2019-02-27 11:02:04 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-03-19 14:36:50 -0500 |
| commit | 2c2978d3a443680043d909e3a2c6812ef67d7a0f (patch) | |
| tree | 5d50e454040f3ac6d65a5d7eec9f0c7ed78cd28f /src/usr/initservice | |
| parent | d7910f680f5c6c019b6ca10c19c030935f3ef56d (diff) | |
| download | talos-hostboot-2c2978d3a443680043d909e3a2c6812ef67d7a0f.tar.gz talos-hostboot-2c2978d3a443680043d909e3a2c6812ef67d7a0f.zip | |
Add ASSERT trace buffer to task crash log
A common cause of task crashes is an explicit assert. Without
full traces we can't differentiate an assert from a nullptr error,
and we don't know which line failed. This will add the ASSERT
trace to the error log that gets created for any task crash.
Change-Id: Ieaccf74ab7c8688109b80b0e22818e45cfdb8028
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72557
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/initservice')
| -rw-r--r-- | src/usr/initservice/baseinitsvc/initservice.C | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/usr/initservice/baseinitsvc/initservice.C b/src/usr/initservice/baseinitsvc/initservice.C index 2f95e8c1e..d06b36f6a 100644 --- a/src/usr/initservice/baseinitsvc/initservice.C +++ b/src/usr/initservice/baseinitsvc/initservice.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2011,2018 */ +/* Contributors Listed Below - COPYRIGHT 2011,2019 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -438,6 +438,9 @@ errlHndl_t InitService::executeFn( l_tidretrc, l_childsts ); + l_errl->collectTrace("ASSERT",128); + l_errl->collectTrace("INITSVC",512); + // break out of do block break; } // endif tidretrc |
