diff options
| author | Christian Geddes <crgeddes@us.ibm.com> | 2019-04-05 15:58:40 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-04-18 10:38:28 -0500 |
| commit | e583424484de98e8be66549370fb28453ccb98e4 (patch) | |
| tree | 4485d1d5dd18f91c0db72af79e33f1203f75312f /src/usr/ibscom | |
| parent | 9d139bd7d99a87c6d11f6569482218badb49cc8b (diff) | |
| download | talos-hostboot-e583424484de98e8be66549370fb28453ccb98e4.tar.gz talos-hostboot-e583424484de98e8be66549370fb28453ccb98e4.zip | |
Validate OMI INBAND BAR offset attributes against calculated values
While setting up the virtual memory mapped IO to the OCMB chips we
make some assumptions that the OCMB MMIO spaces will be contiguous.
The p9a_omi_setup_bars HWP uses OMI_INBAND_BAR_BASE_ADDR_OFFSET to
set the scom registers that determine the physical offset mapped
to the IO. When setting up the Virtual addresses hostboot uses to
represent the physical mmio address, we must validate that the attribute
matches with what we calculated. While doing this we found that the
virtual address attribute was being calculated incorrectly. It was
not localizing the OCMB position relative to the MC which is required
when calculating the offset into the MC bar.
Change-Id: I0ebbcd38e19a238e2cc16791bb0595536788bb7f
RTC: 201493
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75631
Reviewed-by: Matthew Raybuck <matthew.raybuck@ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/ibscom')
| -rw-r--r-- | src/usr/ibscom/ibscom.C | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/usr/ibscom/ibscom.C b/src/usr/ibscom/ibscom.C index e3cb6d468..8939454a3 100644 --- a/src/usr/ibscom/ibscom.C +++ b/src/usr/ibscom/ibscom.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2012,2018 */ +/* Contributors Listed Below - COPYRIGHT 2012,2019 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -66,7 +66,6 @@ namespace IBSCOM // SCOM Register addresses const uint32_t MBS_FIR = 0x02011400; const uint32_t MBSIBERR0 = 0x0201141B; -const uint64_t IBSCOM_BASE = 0x0006000000000000; const uint64_t BIT_18_MASK = 0x0000000000002000; // Register XSCcom access functions to DD framework @@ -217,7 +216,7 @@ errlHndl_t getTargetVirtualAddress(Target* i_target, uint8_t l_chipId = l_parentChip->getAttr<ATTR_PROC_EFF_FABRIC_CHIP_ID>(); - l_IBScomAddr = computeMemoryMapOffset( IBSCOM_BASE, + l_IBScomAddr = computeMemoryMapOffset( MMIO_BASE, l_groupId, l_chipId ); l_IBScomAddr = l_IBScomAddr + l_IBScomBaseAddrOffset; |
