Fix buffer overruns in memory procedures.

Change-Id: Iaaa3a9bba730ee645545e648f155a5007b177472
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/6255
Tested-by: Jenkins Server
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>

4 files changed, 7 insertions, 14 deletions

diff --git a/src/usr/hwpf/hwp/dram_training/mss_draminit_trainadv/mss_draminit_training_advanced.C b/src/usr/hwpf/hwp/dram_training/mss_draminit_trainadv/mss_draminit_training_advanced.C
index e2da3baf9..fdd424e2a 100644
--- a/src/usr/hwpf/hwp/dram_training/mss_draminit_trainadv/mss_draminit_training_advanced.C
+++ b/src/usr/hwpf/hwp/dram_training/mss_draminit_trainadv/mss_draminit_training_advanced.C
@@ -201,8 +201,7 @@ fapi::ReturnCode mss_draminit_training_advanced_cloned(const fapi::Target & i_ta
 {
     //const fapi::Target is centaur.mba
     fapi::ReturnCode rc;
-    char procedure_name[32]; 
-    sprintf(procedure_name, "mss_draminit_training_advanced");
+    const char* procedure_name = "mss_draminit_training_advanced";
     FAPI_INF("+++++++ Executing %s +++++++", procedure_name);
 	
     // Define attribute variables
diff --git a/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_bulk_pwr_throttles.C b/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_bulk_pwr_throttles.C
index 67dc21d8b..d22ff381e 100644
--- a/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_bulk_pwr_throttles.C
+++ b/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_bulk_pwr_throttles.C
@@ -151,8 +151,7 @@ extern "C" {
     {
 	fapi::ReturnCode rc;
 
-	char procedure_name[32];
-	sprintf(procedure_name, "mss_bulk_pwr_throttles");
+	const char* procedure_name = "mss_bulk_pwr_throttles";
 	FAPI_IMP("*** Running %s on %s ***", procedure_name,
 		 i_target_mba.toEcmdString());
 
diff --git a/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_eff_config_thermal.C b/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_eff_config_thermal.C
index fe7b458ad..65381e568 100644
--- a/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_eff_config_thermal.C
+++ b/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_eff_config_thermal.C
@@ -202,8 +202,7 @@ extern "C" {
     {
 	fapi::ReturnCode rc = fapi::FAPI_RC_SUCCESS;
 
-	char procedure_name[32];
-	sprintf(procedure_name, "mss_eff_config_thermal");
+	const char* procedure_name = "mss_eff_config_thermal";
 	FAPI_IMP("*** Running %s on %s ***", procedure_name,
 		 i_target_mba.toEcmdString());
 
@@ -1197,8 +1196,7 @@ extern "C" {
     {
 	fapi::ReturnCode rc = fapi::FAPI_RC_SUCCESS;
 
-	char procedure_name[32];
-	sprintf(procedure_name, "mss_eff_config_thermal_term");
+	const char* procedure_name = "mss_eff_config_thermal_term";
 	FAPI_IMP("*** Running %s ***", procedure_name);
 
 	uint8_t number_nets_term_rd;
@@ -2045,8 +2043,7 @@ extern "C" {
     {
 	fapi::ReturnCode rc = fapi::FAPI_RC_SUCCESS;
 
-	char procedure_name[32];
-	sprintf(procedure_name, "mss_eff_config_thermal_get_cen_drv_value");
+	const char* procedure_name = "mss_eff_config_thermal_get_cen_drv_value";
 	FAPI_IMP("*** Running %s ***", procedure_name);
 
 	switch (i_cen_dq_dqs_drv_imp)
diff --git a/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_throttle_to_power.C b/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_throttle_to_power.C
index 5fc5e4d70..59a7d2950 100644
--- a/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_throttle_to_power.C
+++ b/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_throttle_to_power.C
@@ -117,8 +117,7 @@ extern "C" {
     {
 	fapi::ReturnCode rc = fapi::FAPI_RC_SUCCESS;
 
-	char procedure_name[32];
-	sprintf(procedure_name, "mss_throttle_to_power");
+	const char* procedure_name = "mss_throttle_to_power";
 	FAPI_IMP("*** Running %s ***", procedure_name);
 
 	uint32_t throttle_n_per_mba;
@@ -194,8 +193,7 @@ extern "C" {
     {
 	fapi::ReturnCode rc = fapi::FAPI_RC_SUCCESS;
 
-	char procedure_name[32];
-	sprintf(procedure_name, "mss_throttle_to_power_calc");
+	const char* procedure_name = "mss_throttle_to_power_calc";
 	FAPI_IMP("*** Running %s ***", procedure_name);
 
 	const uint8_t MAX_NUM_PORTS = 2;