summaryrefslogtreecommitdiffstats
path: root/src/usr/hwpf/hwp/utility_procedures
diff options
context:
space:
mode:
authorThi Tran <thi@us.ibm.com>2013-03-13 13:45:03 -0500
committerA. Patrick Williams III <iawillia@us.ibm.com>2013-03-14 22:56:47 -0500
commit35ba1f71b968d8c74d9dfa87d0356ab05f9b874a (patch)
treed69a942d52b45f26cfd64a1c3320836a71afd0ec /src/usr/hwpf/hwp/utility_procedures
parent440475617047e5e98dd42bb019e92a8b70e26ec0 (diff)
downloadtalos-hostboot-35ba1f71b968d8c74d9dfa87d0356ab05f9b874a.tar.gz
talos-hostboot-35ba1f71b968d8c74d9dfa87d0356ab05f9b874a.zip
TULETA Bring Up - HW procedures update - maint_cmds/unmask_errors 03/13/2013
Change-Id: I33389cfefa8da628c935c3db1493375531d8ce33 Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/3538 Tested-by: Jenkins Server Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr/hwpf/hwp/utility_procedures')
-rw-r--r--src/usr/hwpf/hwp/utility_procedures/mss_unmask_errors.C12
1 files changed, 5 insertions, 7 deletions
diff --git a/src/usr/hwpf/hwp/utility_procedures/mss_unmask_errors.C b/src/usr/hwpf/hwp/utility_procedures/mss_unmask_errors.C
index 2d0dfd2ff..994650b30 100644
--- a/src/usr/hwpf/hwp/utility_procedures/mss_unmask_errors.C
+++ b/src/usr/hwpf/hwp/utility_procedures/mss_unmask_errors.C
@@ -20,7 +20,7 @@
/* Origin: 30 */
/* */
/* IBM_PROLOG_END_TAG */
-// $Id: mss_unmask_errors.C,v 1.2 2013/01/31 22:35:01 gollub Exp $
+// $Id: mss_unmask_errors.C,v 1.3 2013/03/08 22:03:00 gollub Exp $
//------------------------------------------------------------------------------
// Don't forget to create CVS comments when you check in your changes!
//------------------------------------------------------------------------------
@@ -33,6 +33,7 @@
// | | | errors masked until mss_unmask_fetch_errors,
// | | | so they will be masked during memdiags, and
// | | | unmasked before scrub is started.
+// 1.3 | 03/08/13 | gollub | Masking MBSPA[0] for DD1, and using MBSPA[8] instead.
//------------------------------------------------------------------------------
// Includes
@@ -1700,14 +1701,11 @@ fapi::ReturnCode mss_unmask_maint_errors(const fapi::Target & i_target,
// to be valid errors for PRD to log.
- // 0 Command_Complete unmasked
- // NOTE: This bit broken in DD1
+ // 0 Command_Complete mask (broken on DD1)
+ // NOTE: This bit broken in DD1.
// It can be made to come on when cmd completes clean, or make to come
// on when cmd stops on error, but can't be set to do both.
- // I am unmasking it since it should work for init commands which
- // will always complete clean. This should at least allow FW to
- // get cmd complete attention for sf init cmd.
- l_ecmd_rc |= l_mbaspa_mask.clearBit(0);
+ l_ecmd_rc |= l_mbaspa_mask.setBit(0);
// 1 Hard_CE_ETE_Attn mask (until after memdiags)
// NOTE: FW memdiags needs this masked because they want to wait till
OpenPOWER on IntegriCloud