diff options
| author | Bill Schwartz <whs@us.ibm.com> | 2013-10-17 08:03:36 -0500 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2013-11-08 15:19:40 -0600 |
| commit | 06fdca58e18f8a6dae366a12e03b97c7b28d5742 (patch) | |
| tree | fdb22b6969b05b85cb7b097455ed4101374a5ac1 /src/usr/hwpf/hwp/start_payload/start_payload.C | |
| parent | fd4fe707fca2059867b4573f3f6f1bd3f708b542 (diff) | |
| download | talos-hostboot-06fdca58e18f8a6dae366a12e03b97c7b28d5742.tar.gz talos-hostboot-06fdca58e18f8a6dae366a12e03b97c7b28d5742.zip | |
istepreasoncodes.H is a merge bottleneck
Eliminate congestion on istepreasoncodes.H by removing error tags and
moduleId/Reason codes from iSteps calling IStepError.addErrorDetails.
ISteps pass only the failing error log. IStepError.addErrorDetails will get
the iStep and substep from the istep dispatcher and add to user data.
Change-Id: If8f8796bfeafb80b5dbcea21629137260b07bc72
RTC: 59658
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/6719
Tested-by: Jenkins Server
Reviewed-by: MIKE J. JONES <mjjones@us.ibm.com>
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr/hwpf/hwp/start_payload/start_payload.C')
| -rw-r--r-- | src/usr/hwpf/hwp/start_payload/start_payload.C | 32 |
1 files changed, 6 insertions, 26 deletions
diff --git a/src/usr/hwpf/hwp/start_payload/start_payload.C b/src/usr/hwpf/hwp/start_payload/start_payload.C index 9394dfaf1..c56e59a9e 100644 --- a/src/usr/hwpf/hwp/start_payload/start_payload.C +++ b/src/usr/hwpf/hwp/start_payload/start_payload.C @@ -341,20 +341,10 @@ void* call_host_runtime_setup( void *io_pArgs ) TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace, "istep start_payload_failed see plid 0x%x", l_err->plid()); - /*@ - * @errortype - * @reasoncode ISTEP_START_PAYLOAD_FAILED - * @severity ERRORLOG::ERRL_SEV_UNRECOVERABLE - * @moduleid ISTEP_HOST_RUNTIME_SETUP - * @userdata1 bytes 0-1: plid identifying first error - * bytes 2-3: reason code of first error - * @userdata2 bytes 0-1: total number of elogs included - * bytes 2-3: N/A - * @devdesc host_runtime_setup failed - */ - l_StepError.addErrorDetails(ISTEP_START_PAYLOAD_FAILED, - ISTEP_HOST_RUNTIME_SETUP, l_err ); + // Create IStep error log and cross reference error that occurred + l_StepError.addErrorDetails( l_err ); + // Commit Error errlCommit(l_err, ISTEP_COMP_ID); } @@ -419,20 +409,10 @@ void* call_host_start_payload( void *io_pArgs ) TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace, "istep start_payload_failed see plid 0x%x", l_errl->plid()); - /*@ - * @errortype - * @reasoncode ISTEP_START_PAYLOAD_FAILED - * @severity ERRORLOG::ERRL_SEV_UNRECOVERABLE - * @moduleid ISTEP_HOST_START_PAYLOAD - * @userdata1 bytes 0-1: plid identifying first error - * bytes 2-3: reason code of first error - * @userdata2 bytes 0-1: total number of elogs included - * bytes 2-3: N/A - * @devdesc host_start_payload failed - */ - l_StepError.addErrorDetails(ISTEP_START_PAYLOAD_FAILED, - ISTEP_HOST_START_PAYLOAD, l_errl ); + // Create IStep error log and cross reference error that occurred + l_StepError.addErrorDetails( l_errl ); + // Commit Error errlCommit(l_errl, ISTEP_COMP_ID); } |
