INITPROC: Hostboot - from defect SW226528 Week 9/24

Change-Id: I0b03d4b8a21db1ab0802bd30a958c15f404ed3c7
CQ:SW226528
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/6545
Tested-by: Jenkins Server
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>

3 files changed, 15 insertions, 6 deletions

diff --git a/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_bulk_pwr_throttles.C b/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_bulk_pwr_throttles.C
index d22ff381e..2300be718 100644
--- a/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_bulk_pwr_throttles.C
+++ b/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_bulk_pwr_throttles.C
@@ -20,7 +20,7 @@
 /* Origin: 30                                                             */
 /*                                                                        */
 /* IBM_PROLOG_END_TAG                                                     */
-// $Id: mss_bulk_pwr_throttles.C,v 1.13 2013/07/22 14:10:45 pardeik Exp $
+// $Id: mss_bulk_pwr_throttles.C,v 1.14 2013/09/19 19:02:06 bellows Exp $
 // $Source: /afs/awd/projects/eclipz/KnowledgeBase/.cvsroot/eclipz/chips/
 //          centaur/working/procedures/ipl/fapi/mss_bulk_pwr_throttles.C,v $
 //------------------------------------------------------------------------------
@@ -70,6 +70,7 @@
 //------------------------------------------------------------------------------
 // Version:|  Author: |  Date:  | Comment:
 //---------|----------|---------|-----------------------------------------------
+//   1.14  | bellows  |19-SEP-13| fixed possible buffer overrun found by stradale
 //   1.13  | pardeik  |19-JUL-13| removed code to identify if throttles are 
 //         |          |         |   based on thermal or power reasons since the
 //         |          |         |   runtime throttles will now be determined
@@ -152,6 +153,7 @@ extern "C" {
 	fapi::ReturnCode rc;
 
 	const char* procedure_name = "mss_bulk_pwr_throttles";
+
 	FAPI_IMP("*** Running %s on %s ***", procedure_name,
 		 i_target_mba.toEcmdString());
 
diff --git a/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_eff_config_thermal.C b/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_eff_config_thermal.C
index 65381e568..7fe7da0ff 100644
--- a/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_eff_config_thermal.C
+++ b/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_eff_config_thermal.C
@@ -20,7 +20,7 @@
 /* Origin: 30                                                             */
 /*                                                                        */
 /* IBM_PROLOG_END_TAG                                                     */
-// $Id: mss_eff_config_thermal.C,v 1.17 2013/07/22 14:09:20 pardeik Exp $
+// $Id: mss_eff_config_thermal.C,v 1.18 2013/09/19 19:02:12 bellows Exp $
 // $Source: /afs/awd/projects/eclipz/KnowledgeBase/.cvsroot/eclipz/chips/
 //          centaur/working/procedures/ipl/fapi/mss_eff_config_thermal.C,v $
 //------------------------------------------------------------------------------
@@ -53,6 +53,7 @@
 //------------------------------------------------------------------------------
 // Version:|  Author: |  Date:  | Comment:
 //---------|----------|---------|-----------------------------------------------
+//   1.18  | bellows  |19-SEP-13| fixed possible buffer overrun found by stradale
 //   1.17  | pardeik  |19-JUL-13| Use runtime throttles for IPL for scominit
 //         |          |         | Removed MRW safemode throttle stuff
 //         |          |         | Always determine runtime throttles now
@@ -203,6 +204,7 @@ extern "C" {
 	fapi::ReturnCode rc = fapi::FAPI_RC_SUCCESS;
 
 	const char* procedure_name = "mss_eff_config_thermal";
+
 	FAPI_IMP("*** Running %s on %s ***", procedure_name,
 		 i_target_mba.toEcmdString());
 
@@ -1196,7 +1198,8 @@ extern "C" {
     {
 	fapi::ReturnCode rc = fapi::FAPI_RC_SUCCESS;
 
-	const char* procedure_name = "mss_eff_config_thermal_term";
+	const char*  procedure_name = "mss_eff_config_thermal_term";
+
 	FAPI_IMP("*** Running %s ***", procedure_name);
 
 	uint8_t number_nets_term_rd;
@@ -1827,8 +1830,8 @@ extern "C" {
     {
 	fapi::ReturnCode rc = fapi::FAPI_RC_SUCCESS;
 
-	char procedure_name[32];
-	sprintf(procedure_name, "mss_eff_config_thermal_get_wc_term");
+	const char * procedure_name = "mss_eff_config_thermal_get_wc_term";
+
 	FAPI_IMP("*** Running %s ***", procedure_name);
 
 	uint8_t l_cen_dq_dqs_rcv_imp[NUM_PORTS];
@@ -2044,6 +2047,7 @@ extern "C" {
 	fapi::ReturnCode rc = fapi::FAPI_RC_SUCCESS;
 
 	const char* procedure_name = "mss_eff_config_thermal_get_cen_drv_value";
+
 	FAPI_IMP("*** Running %s ***", procedure_name);
 
 	switch (i_cen_dq_dqs_drv_imp)
diff --git a/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_throttle_to_power.C b/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_throttle_to_power.C
index 59a7d2950..0ad3e1bed 100644
--- a/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_throttle_to_power.C
+++ b/src/usr/hwpf/hwp/mc_config/mss_eff_config/mss_throttle_to_power.C
@@ -20,7 +20,7 @@
 /* Origin: 30                                                             */
 /*                                                                        */
 /* IBM_PROLOG_END_TAG                                                     */
-// $Id: mss_throttle_to_power.C,v 1.9 2012/12/12 20:10:47 pardeik Exp $
+// $Id: mss_throttle_to_power.C,v 1.10 2013/09/19 19:02:19 bellows Exp $
 // $Source: /afs/awd/projects/eclipz/KnowledgeBase/.cvsroot/eclipz/chips/
 //          centaur/working/procedures/ipl/fapi/mss_throttle_to_power.C,v $
 //------------------------------------------------------------------------------
@@ -47,6 +47,7 @@
 //------------------------------------------------------------------------------
 // Version:|  Author: |  Date:  | Comment:
 //---------|----------|---------|-----------------------------------------------
+//   1.10  | bellows  |19-SEP-13| fixed possible buffer overrun found by stradale
 //   1.9   | pardeik  |04-DEC-12| update lines to have a max width of 80 chars
 //         |          |         | added FAPI_ERR before return code lines
 //         |          |         | made trace statements for procedures FAPI_IMP
@@ -118,6 +119,7 @@ extern "C" {
 	fapi::ReturnCode rc = fapi::FAPI_RC_SUCCESS;
 
 	const char* procedure_name = "mss_throttle_to_power";
+
 	FAPI_IMP("*** Running %s ***", procedure_name);
 
 	uint32_t throttle_n_per_mba;
@@ -194,6 +196,7 @@ extern "C" {
 	fapi::ReturnCode rc = fapi::FAPI_RC_SUCCESS;
 
 	const char* procedure_name = "mss_throttle_to_power_calc";
+
 	FAPI_IMP("*** Running %s ***", procedure_name);
 
 	const uint8_t MAX_NUM_PORTS = 2;