diff options
| author | Bill Schwartz <whs@us.ibm.com> | 2014-03-07 13:44:36 -0600 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2014-03-13 14:48:28 -0500 |
| commit | e1fe2626b37d3c9471e896145182f8a833545ac0 (patch) | |
| tree | a9d15e9b4d093a6c9c0a4163d4f1fda672031366 /src/usr/hwpf/hwp/dmi_training | |
| parent | 188fe8cdfebd50988713b70ca5d85e0172902ed1 (diff) | |
| download | talos-hostboot-e1fe2626b37d3c9471e896145182f8a833545ac0.tar.gz talos-hostboot-e1fe2626b37d3c9471e896145182f8a833545ac0.zip | |
Resolve HWPs querying Centaur Ring data before ATTR_MSS_FREQ setup
Verified with Gary Peterson that using the default frequency is OK
Change-Id: Iaad452daa86335db66e9549c48ee1b5cba7370a3
RTC: 92232
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/9394
Tested-by: Jenkins Server
Reviewed-by: STEPHEN M. CPREK <smcprek@us.ibm.com>
Reviewed-by: MIKE J. JONES <mjjones@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr/hwpf/hwp/dmi_training')
| -rw-r--r-- | src/usr/hwpf/hwp/dmi_training/dmi_training.C | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/usr/hwpf/hwp/dmi_training/dmi_training.C b/src/usr/hwpf/hwp/dmi_training/dmi_training.C index 25a2693bd..3a426d0ff 100644 --- a/src/usr/hwpf/hwp/dmi_training/dmi_training.C +++ b/src/usr/hwpf/hwp/dmi_training/dmi_training.C @@ -739,9 +739,6 @@ void* call_dmi_io_dccal( void *io_pArgs ) // io_dccal.C is going to look for a PLL ring with a "stub" // mem freq -- so set to a default, then clear it (so as not // to mess up MSS HWP later - // Note: io_dccal actually scans the ring in, is it really OK to use the - // ring corresponding to a default memory frequency of 1600MHz? - // RTC issue 92232 will resolve this TARGETING::Target* l_membuf_target = (const_cast<TARGETING::Target*>(l_itr->second)); l_membuf_target->setAttr<TARGETING::ATTR_MSS_FREQ>(1600); @@ -920,7 +917,6 @@ void* call_dmi_io_run_training( void *io_pArgs ) // particular EC level, the frequency only selects the data. Ideally the // Accessor would be able to return the ring length without a frequency, // a workaround is to set ATTR_MSS_FREQ to a default value here - // RTC issue 92232 will resolve this workaround. TARGETING::Target* l_membuf_target = (const_cast<TARGETING::Target*>(l_itr->second)); l_membuf_target->setAttr<TARGETING::ATTR_MSS_FREQ>(1600); @@ -928,7 +924,7 @@ void* call_dmi_io_run_training( void *io_pArgs ) FAPI_INVOKE_HWP(l_err, dmi_io_run_training, l_fapi_master_target, l_fapi_slave_target); - // Clear ATTR_MSS_FREQ. RTC issue 92232 + // Clear ATTR_MSS_FREQ. l_membuf_target->setAttr<TARGETING::ATTR_MSS_FREQ>(0); if (l_err) |
