diff options
| author | Elliott Dahle <dedahle@us.ibm.com> | 2013-09-19 16:20:19 -0500 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2013-10-03 11:34:53 -0500 |
| commit | 6c2c08f207bcc9b31de885d57b0fba95fa13b939 (patch) | |
| tree | 2ed6d03edd86394ee65eda195bd132f7a45c5f8f /src/usr/hwpf/hwp/dimm_attributes.xml | |
| parent | 31c08a8a79c92f52b10fbeb32928aa88a5968cee (diff) | |
| download | talos-hostboot-6c2c08f207bcc9b31de885d57b0fba95fa13b939.tar.gz talos-hostboot-6c2c08f207bcc9b31de885d57b0fba95fa13b939.zip | |
Facilitate transition from using EFF attribute to reading actual C_DIMM VPD
Change ATTR_VPD_DIMM_SPARE attribute to match EFF_DIMM_SPARE attribute
in target and data type to ensure proper operation when a HWP
switches to reading real Centaur VPD.
Change-Id: I3a6f26d94c42fdb37f4063b1f3a51eb4faaec022
RTC: 84528
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/6281
Tested-by: Jenkins Server
Reviewed-by: MIKE J. JONES <mjjones@us.ibm.com>
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Reviewed-by: William H. Schwartz <whs@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr/hwpf/hwp/dimm_attributes.xml')
| -rw-r--r-- | src/usr/hwpf/hwp/dimm_attributes.xml | 21 |
1 files changed, 4 insertions, 17 deletions
diff --git a/src/usr/hwpf/hwp/dimm_attributes.xml b/src/usr/hwpf/hwp/dimm_attributes.xml index e066c0e20..5dcd070f9 100644 --- a/src/usr/hwpf/hwp/dimm_attributes.xml +++ b/src/usr/hwpf/hwp/dimm_attributes.xml @@ -75,10 +75,10 @@ <attribute> <id>ATTR_VPD_DIMM_SPARE</id> - <targetType>TARGET_TYPE_DIMM</targetType> + <targetType>TARGET_TYPE_MBA_CHIPLET</targetType> <description> - Spare DRAM availability for each rank on the DIMM. - There are 8 DQ lines to spare DRAMs. + Spare DRAM availability for all DIMMs connected to the target MBA. + For each rank on a DIMM, there are 8 DQ lines to spare DRAMs. - NO_SPARE: No spare DRAMs - LOW_NIBBLE: x4 DRAMs in use, one spare DRAM connected to SP_DQ0-3 - HIGH_NIBBLE: x4 DRAMs in use, one spare DRAM connected to SP_DQ4-7 @@ -86,20 +86,6 @@ 1/ x4 DRAMs in use, two spare DRAMs connected to SP_DQ0-7 2/ x8 DRAMs in use, one spare DRAM connected to SP_DQ0-7 For C-DIMMs, this is in a VPD field : Record:VSPD, Keyword:AM - For IS-DIMMs, the platform should return 0 indicating - no spares for any rank. - The top 2 bits are for rank 0 e.g: - if (((val AND 0xc0) >> 6) == - ENUM_ATTR_VPD_DIMM_SPARE_LOW_NIBBLE) {...} - The next 2 bits are for rank 1 e.g: - if (((val AND 0x30) >> 4) == - ENUM_ATTR_VPD_DIMM_SPARE_NO_SPARE) {...} - The next 2 bits are for rank 2 e.g: - if (((val AND 0x0c) >> 2) == - ENUM_ATTR_VPD_DIMM_SPARE_HIGH_NIBBLE) {...} - The bottom 2 bits are for rank 3 e.g: - if ((val AND 0x03) == - ENUM_ATTR_VPD_DIMM_SPARE_FULL_BYTE) {...} </description> <valueType>uint8</valueType> <enum> @@ -108,6 +94,7 @@ HIGH_NIBBLE = 0x02, FULL_BYTE = 0x03 </enum> + <array>2 2 4</array> <platInit/> </attribute> |
