diff options
| author | Brian Horton <brianh@linux.ibm.com> | 2015-04-23 15:41:49 -0500 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2015-04-24 09:36:04 -0500 |
| commit | c51fe7ff734e26f131d5adc13181bd9894be3d91 (patch) | |
| tree | 94d6a7685353ac77b5fb4a7d577474ad55b0f0d1 /src/usr/hwas/common | |
| parent | e88b1050d6409695b949d037e4f2c6bfdae897e0 (diff) | |
| download | talos-hostboot-c51fe7ff734e26f131d5adc13181bd9894be3d91.tar.gz talos-hostboot-c51fe7ff734e26f131d5adc13181bd9894be3d91.zip | |
add comments for BEAM errors
Change-Id: I39444e50e96c40718c76fce6a3931cdb84557279
RTC: 127549
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/17389
Tested-by: Jenkins Server
Reviewed-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr/hwas/common')
| -rw-r--r-- | src/usr/hwas/common/hwas.C | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/src/usr/hwas/common/hwas.C b/src/usr/hwas/common/hwas.C index d6a866756..ad187d2c6 100644 --- a/src/usr/hwas/common/hwas.C +++ b/src/usr/hwas/common/hwas.C @@ -681,18 +681,15 @@ void checkCriticalResources(uint32_t & io_commonPlid, uint8_t l_critical = 1; PredicateAttrVal<ATTR_RESOURCE_IS_CRITICAL> l_isCritical(l_critical); - l_customPredicate.push(&l_isFunctional).Not().push(&l_isCritical).And(); - targetService().getAssociated( l_plist, i_pTop, TargetService::CHILD, TargetService::ALL, &l_customPredicate); //if this list has ANYTHING then something critical has been deconfigured if(l_plist.size()) { - HWAS_ERR("Insufficient HW to continue IPL: (critical resource" - " not functional)"); + HWAS_ERR("Insufficient HW to continue IPL: (critical resource not functional)"); /*@ * @errortype * @severity ERRL_SEV_UNRECOVERABLE @@ -717,18 +714,18 @@ void checkCriticalResources(uint32_t & io_commonPlid, case 3: userdata2 = static_cast<uint64_t>(get_huid(l_plist[2])); + /*fall through*/ // keep BEAM quiet case 2: userdata2 |= static_cast<uint64_t>(get_huid(l_plist[1])) << 32; + /*fall through*/ // keep BEAM quiet case 1: userdata1 = (static_cast<uint64_t>(l_plist.size()) << 32) | static_cast<uint64_t>(get_huid(l_plist[0])); } - - l_errl = hwasError(ERRL_SEV_UNRECOVERABLE, MOD_CHECK_MIN_HW, RC_SYSAVAIL_MISSING_CRITICAL_RESOURCE, |
