diff options
| author | Missy Connell <missyc@us.ibm.com> | 2012-04-11 11:01:32 -0500 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2012-05-08 16:37:36 -0500 |
| commit | 5d0c443dd8e532f2e6779d2b83ce6218db11e000 (patch) | |
| tree | 8880d69997f70d474866df893acf89156bef8926 /src/usr/fsi | |
| parent | cb5ba5f436c90aa169519b8776ec45112a25d575 (diff) | |
| download | talos-hostboot-5d0c443dd8e532f2e6779d2b83ce6218db11e000.tar.gz talos-hostboot-5d0c443dd8e532f2e6779d2b83ce6218db11e000.zip | |
Update MboxDD to fix up remaining code review comments from handoff.
Added enums for the status control register
Added comments in the dd code
Removed the check on a read if input buf is larger than the max
amount of data read.
Made changes to read/write not on a 32bit boundary
Remove Mboxdd class and used mbox namespace
RTC: 38020
Change-Id: Ia2842a380ed90d370dd1503aa0b189813229c7a4
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/886
Tested-by: Jenkins Server
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr/fsi')
| -rw-r--r-- | src/usr/fsi/test/fsiprestest.H | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/src/usr/fsi/test/fsiprestest.H b/src/usr/fsi/test/fsiprestest.H index 5797e3b3d..b30483934 100644 --- a/src/usr/fsi/test/fsiprestest.H +++ b/src/usr/fsi/test/fsiprestest.H @@ -37,7 +37,6 @@ using namespace TARGETING; using namespace DeviceFW; extern trace_desc_t* g_trac_fsi; -uint64_t target_to_uint64(const TARGETING::Target* i_target); class FSIPresTest : public CxxTest::TestSuite @@ -70,7 +69,7 @@ class FSIPresTest : public CxxTest::TestSuite while(target) { TS_TRACE("FSI-PRES: Testing target %x", - target_to_uint64(*target)); + TARGETING::get_huid(*target)); // Read presence detect. errlHndl_t l_errl = NULL; @@ -83,10 +82,10 @@ class FSIPresTest : public CxxTest::TestSuite if (l_errl) { TS_FAIL("FSI-PRES: Cannot perform presence detect. %x", - target_to_uint64(*target)); + TARGETING::get_huid(*target)); TRACFCOMP(g_trac_fsi, "Failed presence detect. %x", - target_to_uint64(*target)); + TARGETING::get_huid(*target)); } else if ((*target == l_masterChip) && (!present)) { @@ -114,11 +113,11 @@ class FSIPresTest : public CxxTest::TestSuite { TS_FAIL("FSI-PRES: " "Error performing read to present device. %x", - target_to_uint64(*target)); + TARGETING::get_huid(*target)); TRACFCOMP(g_trac_fsi, "FSI-PRES: FSI-read failed with %d on %x", l_errl->reasonCode(), - target_to_uint64(*target)); + TARGETING::get_huid(*target)); // commit this log for debug l_errl->collectTrace("UNIT_TEST",512); errlCommit(l_errl,FSI_COMP_ID); @@ -127,15 +126,15 @@ class FSIPresTest : public CxxTest::TestSuite { TS_FAIL("FSI-PRES: No error performing " "read to non-present device. %x", - target_to_uint64(*target)); + TARGETING::get_huid(*target)); TRACFCOMP(g_trac_fsi, "FSI-PRES: FSI-read did not fail. %x", - target_to_uint64(*target)); + TARGETING::get_huid(*target)); } else { TS_TRACE("FSI-PRES: Read chip-id %x on %x", - fsi_data, target_to_uint64(*target)); + fsi_data, TARGETING::get_huid(*target)); } // Delete any logs that got produced |
