diff options
| author | Andrew Geissler <andrewg@us.ibm.com> | 2018-05-18 14:01:16 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-05-29 15:43:55 -0400 |
| commit | f1186fdef28f6e23a9bda17bbef1d0e217c0430d (patch) | |
| tree | 900225ca940bd34b64bb5f550e5879d79aa2d0ee /src/usr/fapi2/plat_utils.C | |
| parent | fc79c535382d9ca609059d39076121dea33c28d8 (diff) | |
| download | talos-hostboot-f1186fdef28f6e23a9bda17bbef1d0e217c0430d.tar.gz talos-hostboot-f1186fdef28f6e23a9bda17bbef1d0e217c0430d.zip | |
Update getChildTargetsForCDG to use CEN PORT/DIMM
The port and dimm sockets come off of the centaur on cumulus.
Update this function to look at the correct attributes.
These attribute do not exist on Cumulus so the default will
be to just return all dimms under the input target.
This code change affected the test case so an update was required
there as well (i.e. the fix for this defect).
Change-Id: I102c40acc124100e90dd832aeed94716c0f18811
CQ:SW428864
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59073
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/fapi2/plat_utils.C')
| -rw-r--r-- | src/usr/fapi2/plat_utils.C | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/usr/fapi2/plat_utils.C b/src/usr/fapi2/plat_utils.C index e6445e219..e340b2d60 100644 --- a/src/usr/fapi2/plat_utils.C +++ b/src/usr/fapi2/plat_utils.C @@ -997,6 +997,8 @@ void processEICDGs(const ErrorInfo & i_errInfo, /// For DIMMs: DIMM Socket Number /// For Chips: Chip Position /// For Chiplets: Chiplet Position +/// @param[o] o_childTargets List of child targets matching input +/// criteria. /// void getChildTargetsForCDG( const fapi2::Target<fapi2::TARGET_TYPE_ALL>& i_parentTarget, @@ -1081,11 +1083,11 @@ void getChildTargetsForCDG( // Match i_childPort and i_childNum if ( ((i_childPort == ErrorInfoChildrenCDG::ALL_CHILD_PORTS) || (i_childPort == - (*l_itr)->getAttr<TARGETING::ATTR_MBA_PORT>())) + (*l_itr)->getAttr<TARGETING::ATTR_CEN_MBA_PORT>())) && ((i_childNum == ErrorInfoChildrenCDG::ALL_CHILD_NUMBERS) || (i_childNum == - (*l_itr)->getAttr<TARGETING::ATTR_MBA_DIMM>())) ) + (*l_itr)->getAttr<TARGETING::ATTR_CEN_MBA_DIMM>())) ) { o_childTargets.push_back(*l_itr); } |
