diff options
author | Ilya Smirnov <ismirno@us.ibm.com> | 2018-01-30 14:46:48 -0600 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-02-12 12:01:07 -0500 |
commit | 4648dad462fddbd4e4bd829b04b1a7090be409b5 (patch) | |
tree | 2ccf0047a8548f236853bfc688786fc8d279fa71 /src/usr/fapi2/plat_utils.C | |
parent | c80dab12a8551cc1d7b22c1c142f6bbf2bf3da8e (diff) | |
download | talos-hostboot-4648dad462fddbd4e4bd829b04b1a7090be409b5.tar.gz talos-hostboot-4648dad462fddbd4e4bd829b04b1a7090be409b5.zip |
Populate the Severity of PLAT Errors
An issue was observed where recovered PLAT error logs were not
being properly hidden/skipped and incorrect severity was
assigned to those error logs. The reason is that the path of
code that PLAT errors take fails to overwrite the default severity
(unrecoverable). A fix is to explicitly set the severity of all
errors at the end of rcToErrl.
Change-Id: Ib0aff72a800e0ed7a5b48e753049d2f3422406b4
CQ:SW410923
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53221
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Prachi Gupta <pragupta@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/fapi2/plat_utils.C')
-rw-r--r-- | src/usr/fapi2/plat_utils.C | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/usr/fapi2/plat_utils.C b/src/usr/fapi2/plat_utils.C index dc4493391..d134582ea 100644 --- a/src/usr/fapi2/plat_utils.C +++ b/src/usr/fapi2/plat_utils.C @@ -955,6 +955,10 @@ errlHndl_t rcToErrl(ReturnCode & io_rc, l_pError->collectTrace(FAPI_IMP_TRACE_NAME, 384 ); l_pError->collectTrace(FAPI_SCAN_TRACE_NAME, 256 ); l_pError->collectTrace(FAPI_DBG_TRACE_NAME, 256 ); + + // Make sure the severity is set correctly for all errors. + // The severity of PLAT errors is not set above, so set it here. + l_pError->setSev(i_sev); } FAPI_DBG("Exiting rcToErrl"); |